Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2240

Fix Search box error - quotes and spaces

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1.5
    • Sprint:
      Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10

      Description

      Searching sometimes produces a server error if the search string contains one or more space characters and is enclosed in double quotes.

      To repeat:

      Go to App Store and search the following string, enclosed in double quotes:

      "hello world"

      What should happen is that the entire phrase "hello world" should be searched.

      Note that we allow spaces in categories, e.g., "histone modification" on the main App Store.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1388 [ 17463 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            I found some google link about haystack issues

            https://github.com/django-haystack/django-haystack/issues/632

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - I found some google link about haystack issues https://github.com/django-haystack/django-haystack/issues/632
            noor91zahara Noor Zahara (Inactive) made changes -
            Story Points 0.5 1.5
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Code diff - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2240#diff
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            ann.loraine Ann Loraine made changes -
            Sprint Spring 3 : 3 Feb to 14 Feb [ 86 ] Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 21 Feb [ 86, 87 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Recommend PR.

            Show
            ann.loraine Ann Loraine added a comment - Recommend PR.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            This has been handled as a part of IGBF-2242. So it is better to merge this as a part of IGBF-2242.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - This has been handled as a part of IGBF-2242 . So it is better to merge this as a part of IGBF-2242 .
            Hide
            ann.loraine Ann Loraine added a comment -

            Please check previous comment - IGBF-2242 is repeated twice so I am not sure which issue to look at.

            Show
            ann.loraine Ann Loraine added a comment - Please check previous comment - IGBF-2242 is repeated twice so I am not sure which issue to look at.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            Sorry for the confusion. https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2242#diff is the one to be reviewed and merged.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Sorry for the confusion. https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2242#diff is the one to be reviewed and merged.
            noor91zahara Noor Zahara (Inactive) made changes -
            Link This issue is blocked by IGBF-2242 [ IGBF-2242 ]
            nfreese Nowlan Freese made changes -
            Sprint Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb [ 86, 87 ] Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 86, 87, 89 ]
            nfreese Nowlan Freese made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Sprint Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 86, 87, 89 ] Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 86, 87, 89, 90 ]
            nfreese Nowlan Freese made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment -

            Deployed to https://dev-appstore-2.bioviz.org and ready for testing to be done.

            cc: Shamika Gajanan Kulkarni and Noor Zahara

            Show
            ann.loraine Ann Loraine added a comment - Deployed to https://dev-appstore-2.bioviz.org and ready for testing to be done. cc: Shamika Gajanan Kulkarni and Noor Zahara
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Tested this ticket on https://dev-appstore-2.bioviz.org/. The search box is working fine.
            I tried entering search texts like 'Merge', ' "Merge" ', ' "Merge Annotation" ', ' "Tracks" ' (it is one of the categories), ' "tra*" ' (this returns anything that matches 'tra' in category, name, etc.), 'Testing' (again a category), etc.
            It is working fine in all of the above cases and returns the expected results displaying the correct apps.

            Prof. [~aloraine] Please let me know if any other condition needs to be checked.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested this ticket on https://dev-appstore-2.bioviz.org/ . The search box is working fine. I tried entering search texts like 'Merge', ' "Merge" ', ' "Merge Annotation" ', ' "Tracks" ' (it is one of the categories), ' "tra*" ' (this returns anything that matches 'tra' in category, name, etc.), 'Testing' (again a category), etc. It is working fine in all of the above cases and returns the expected results displaying the correct apps. Prof. [~aloraine] Please let me know if any other condition needs to be checked.
            Hide
            ann.loraine Ann Loraine added a comment -

            Please also check for whether the search is also searching the App descriptions.
            Can you state what "etc" means above? (e.g., does it include all possible attributes of an app, including the description that gets updated via repository.xml bundled with the jar file?)

            Show
            ann.loraine Ann Loraine added a comment - Please also check for whether the search is also searching the App descriptions. Can you state what "etc" means above? (e.g., does it include all possible attributes of an app, including the description that gets updated via repository.xml bundled with the jar file?)
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Yes Prof. [~aloraine], it does include the App descriptions too. It includes categories, app descriptions and the name of the app. Sorry for not being clear about this before.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Yes Prof. [~aloraine] , it does include the App descriptions too. It includes categories, app descriptions and the name of the app. Sorry for not being clear about this before.
            nfreese Nowlan Freese made changes -
            Sprint Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 86, 87, 89, 90 ] Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10 [ 86, 87, 89, 90, 91 ]
            nfreese Nowlan Freese made changes -
            Rank Ranked higher
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            I have successfully tested this ticket to search for matches in App name, Categories and App Description. Moving this ticket to closed.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - I have successfully tested this ticket to search for matches in App name, Categories and App Description. Moving this ticket to closed.
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Noor Zahara [ noor91zahara ]

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: