Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May
Description
Investigate the use of the functions getParser() and getIndexWriter(). Kindly contact Srishti Tiwari for more details.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Sprint | Spring 3 : 3 Feb to 14 Feb [ 86 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 21 Feb [ 86, 87 ] |
| Rank | Ranked higher |
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Sprint | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb [ 86, 87 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 86, 87, 89 ] |
| Rank | Ranked higher |
| Assignee | Srishti Tiwari [ stiwari8 ] | Ann Loraine [ aloraine ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Shamika Gajanan Kulkarni or Srishti Tiwari - please provide more context and background:
- In which class or interface were you investigating the the functions getParser() and getIndexWriter()?
- Why is it important to investigate these functions? Please write a brief user story to explain why it was important to investigate these functions.
Assigning to Srishti Tiwari since she has worked on this most.
| Assignee | Ann Loraine [ aloraine ] | Srishti Tiwari [ stiwari8 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Hi [~aloraine],
These methods were investigated in interface
com.affymetrix.genometry.parsers.FileTypeHandler.java and all classes implementing it.
It was necessary to understand how different files being parsed and so that the same could be implemented for files with 23andme extensions.
It was earlier discussed that it could be removed or not as their usage was not known. I figured out that it was being used for two classes as mentioned in my first comment. So we cannot remove them.
Followup:
Please edit above comment to include:
- package and module for interface FileTypeHandler.java
- why were you investigating those two methods in particular? were you trying to see if they could be removed from the interface or what?
| Sprint | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 86, 87, 89 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 86, 87, 89, 90 ] |
| Rank | Ranked higher |
| Sprint | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar [ 86, 87, 89, 90 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10 [ 86, 87, 89, 90, 91 ] |
| Rank | Ranked higher |
| Assignee | Srishti Tiwari [ stiwari8 ] | Ann Loraine [ aloraine ] |
| Sprint | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10 [ 86, 87, 89, 90, 91 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr [ 86, 87, 89, 90, 91, 92 ] |
| Rank | Ranked higher |
| Sprint | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr [ 86, 87, 89, 90, 91, 92 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May [ 86, 87, 89, 90, 91, 92, 93 ] |
| Rank | Ranked higher |
| Sprint | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May [ 86, 87, 89, 90, 91, 92, 93 ] | Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 86, 87, 89, 90, 91, 92, 93, 94 ] |
| Rank | Ranked higher |
On re-reading the previous comments and notes, I see the questions were answered and the task is complete. Moving to Done!
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Ann Loraine [ aloraine ] | Srishti Tiwari [ stiwari8 ] |
getIndexWriter() is either returning null or in turn calling getParser() in the same class, except for two places as stated below.
In FileTypeHolder, for two addFileTypeHandler - "Binary" and "PSL" the getIndexWriter() method is returning a parser itself, but initializing the parser in a special way.