Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2290

Toasts obstructing buttons in Right Panel

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Attachments

        Activity

        Hide
        nfreese Nowlan Freese added a comment -

        Karthik Raveendran Is there a specific example of the toast notifications obstructing buttons in the right panel? After merging I cannot find any examples of the toast obstructing buttons.

        I did notice a weird behavior where the toast notification after clicking Save in the Metadata right panel is itself a button, and clicking it caused the right-panel to load again. Not sure if related.

        Show
        nfreese Nowlan Freese added a comment - Karthik Raveendran Is there a specific example of the toast notifications obstructing buttons in the right panel? After merging I cannot find any examples of the toast obstructing buttons. I did notice a weird behavior where the toast notification after clicking Save in the Metadata right panel is itself a button, and clicking it caused the right-panel to load again. Not sure if related.
        Hide
        karthik Karthik Raveendran added a comment -

        While using Bootstrap 4 toasts, when the hide function is used, the CSS changes visibility attribute to hidden, which does not destroy the element just hides it. Which means it will still occupy the space assigned for it.

        The toasts that appear for View In IGB notifications and warning such as "Opening file in IGB..." or "Error: IGB is not running" is the main issue here. When the right panel is open, sometimes (if the browser is sized in a way that facilitates this) these toasts, while hidden, obstruct the buttons in right panel.

        Show
        karthik Karthik Raveendran added a comment - While using Bootstrap 4 toasts, when the hide function is used, the CSS changes visibility attribute to hidden, which does not destroy the element just hides it. Which means it will still occupy the space assigned for it. The toasts that appear for View In IGB notifications and warning such as "Opening file in IGB..." or "Error: IGB is not running" is the main issue here. When the right panel is open, sometimes (if the browser is sized in a way that facilitates this) these toasts, while hidden, obstruct the buttons in right panel.
        Hide
        karthik Karthik Raveendran added a comment - - edited

        So I moved the View In IGB toasts to the middle panel and re-positioned them to work around the issue.

        Show
        karthik Karthik Raveendran added a comment - - edited So I moved the View In IGB toasts to the middle panel and re-positioned them to work around the issue.
        Hide
        nfreese Nowlan Freese added a comment - - edited

        Now the toast notification has a fixed position, which if the user is scrolled down lower in the page the toast does not show up for them as it appears higher in the page.

        Show
        nfreese Nowlan Freese added a comment - - edited Now the toast notification has a fixed position, which if the user is scrolled down lower in the page the toast does not show up for them as it appears higher in the page.
        Hide
        nfreese Nowlan Freese added a comment - - edited

        Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/147/igbf-2290b-fixed-the-toast-position-issue/diff

        I'm seeing some odd behavior where the Opening File in IGB toast is now showing even when IGB is not running, and it is appearing on top of the IGB is Not Running warning.

        Show
        nfreese Nowlan Freese added a comment - - edited Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/147/igbf-2290b-fixed-the-toast-position-issue/diff I'm seeing some odd behavior where the Opening File in IGB toast is now showing even when IGB is not running, and it is appearing on top of the IGB is Not Running warning.
        Hide
        nfreese Nowlan Freese added a comment -

        Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/148/igbf-2290b-fixed-toast-notification/diff

        Karthik Raveendran Was everything reverted in this merge? It looks like the toast notifications are back on the right side. The toast notifications seem to look/work well I don't see any problems. I'm going to reassign to you and leave it up to you to decide if the issue should be closed.

        Show
        nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/148/igbf-2290b-fixed-toast-notification/diff Karthik Raveendran Was everything reverted in this merge? It looks like the toast notifications are back on the right side. The toast notifications seem to look/work well I don't see any problems. I'm going to reassign to you and leave it up to you to decide if the issue should be closed.
        Hide
        nfreese Nowlan Freese added a comment -

        Karthik Raveendran

        I will test that the toasts are no longer obstructing right-panel buttons.

        Karthik, can you take a look at the Save toast in the metadata right-panel acting as a button?

        Show
        nfreese Nowlan Freese added a comment - Karthik Raveendran I will test that the toasts are no longer obstructing right-panel buttons. Karthik, can you take a look at the Save toast in the metadata right-panel acting as a button?
        Hide
        nfreese Nowlan Freese added a comment -

        The toasts no longer appear to be obstructing right-panel buttons.

        Show
        nfreese Nowlan Freese added a comment - The toasts no longer appear to be obstructing right-panel buttons.
        Hide
        nfreese Nowlan Freese added a comment -

        Just noticed that the submitted toast when running analyses never disappears.

        Karthik Raveendran Can you take a look at this?

        Show
        nfreese Nowlan Freese added a comment - Just noticed that the submitted toast when running analyses never disappears. Karthik Raveendran Can you take a look at this?
        Hide
        karthik Karthik Raveendran added a comment -

        Issue has been resolved in IGBF-2299

        Show
        karthik Karthik Raveendran added a comment - Issue has been resolved in IGBF-2299
        Hide
        nfreese Nowlan Freese added a comment -

        Karthik Raveendran

        Can you take a look at the rp_metadata.html for the save metadata toast? The save toast is acting like a button, and I'm wondering if its because of the way its wrapped inside a button tag (see code below):

        <button class="btn btn-primary w-25" id="savemetadata_rp" onclick="saveMetaData()" >Save
        <div class="toast metaSave hide" role="alert" data-autohide="true" data-delay="2000" style="position:absolute;right:40px;bottom:15px;">
        <div class="toast-header">
        <i class="fas fa-save fa-bounce fa-lg mr-2"></i>
        <strong class="mr-auto text-success ">Saved!</strong>
        </div>
        </div>
        </button>

        Show
        nfreese Nowlan Freese added a comment - Karthik Raveendran Can you take a look at the rp_metadata.html for the save metadata toast? The save toast is acting like a button, and I'm wondering if its because of the way its wrapped inside a button tag (see code below): <button class="btn btn-primary w-25" id="savemetadata_rp" onclick="saveMetaData()" >Save <div class="toast metaSave hide" role="alert" data-autohide="true" data-delay="2000" style="position:absolute;right:40px;bottom:15px;"> <div class="toast-header"> <i class="fas fa-save fa-bounce fa-lg mr-2"></i> <strong class="mr-auto text-success ">Saved!</strong> </div> </div> </button>
        Hide
        karthik Karthik Raveendran added a comment -

        Issue resolved in btibucket branch IGBF-2290c

        Show
        karthik Karthik Raveendran added a comment - Issue resolved in btibucket branch IGBF-2290 c
        Hide
        nfreese Nowlan Freese added a comment -

        Metadata save toast is no longer acting like a button.

        Closing issue.

        Show
        nfreese Nowlan Freese added a comment - Metadata save toast is no longer acting like a button. Closing issue.

          People

          • Assignee:
            karthik Karthik Raveendran
            Reporter:
            karthik Karthik Raveendran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: