Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.6 Major Release
-
Story Points:2.5
-
Epic Link:
-
Sprint:Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun
Description
IGB lets people save images from the currently displayed data scene. To save an image, users can click the camera icon in the icon toolbar (top left) *or* they can choose File > Save Image.
When they do that, a "Save Image" window opens with many options.
Currently, there are four image types users can save:
- Whole Frame (the default setting)
- Main View
- Main View (with Labels)
- Sliced View (with Labels)
In addition, users can save images in the following formats:
- PNG
- SVG
- JPEG
Thus there are 4 times 3 combinations of image types and image file formats a user can choose!
However, currently if a Windows platform users selects "Whole Frame" and "svg" format, the image file created is empty.
For this task, first ensure you are able to reproduce the above bug. Also, check SVG saving for each of the four image options - Whole Frame, Main View, etc. Also, check the behavior on a Mac computer.
First, change the default option to "Main View with Labels" on every platform.
If you can save the file correctly on a Mac and the bug is indeed Windows-specific, then do this:
- On Windows computers only, show a modal alert message letting Windows users (only on Windows!) know that SVG with Whole Frame saving option is not available.
Proposed wording:
"Unfortunately, IGB Windows users cannot save an SVG image in the Whole Frame setting. Please select another option to save an SVG image."
Whole Frame should be bold font.
Attachments
Issue Links
- is blocked by
-
IGBF-2143 Fix exporting whole frame svg on windows
-
- Ready for Pull Request
-
Activity
I have reviewed this ticket. Noor Zahara it is working fine on Windows platform. The dialog box appears when we try to save a svg image for Whole Frame option with the message printed properly. However, I see that Prof. [~aloraine] has mentioned that the default option should be changed to "Main View with Labels" instead of "Whole Frame", and it still displays "Whole Frame" as default. Can you please look into this and make the changes?
I have made the changes.
Kindly check now.
Reviewed the ticket. It is fine now. The default option selected is "Main View with Labels". Kindly submit a PR for the same Noor Zahara.
Shamika Gajanan Kulkarni - please test using the "early access" installer on Windows
Prutha Kulkarni - please test using the "early access" installer for Windows on Mac
Prof. [~aloraine] I tried saving .svg image using the Early Access installer. However, the dialog box is not appearing. I don't think its reflecting the changes with respect to this ticket.
Thanks for letting me know.
I just now redeployed the master branch installers.
Can you try again?
Also, to confirm the version, choose Help > About IGB.
The commit hash for the most recent commit will be shown.
cc: Shamika Gajanan Kulkarni
Yes Prof. [~aloraine] I shall try again. Thank you.
Tested this ticket using Early access installer. It is fine now. The commit id also reflects the latest commit.
I tested the same on MAC and I am able to save the image in SVG format. But, The default option selected is "Whole Frame" and not "Main View (with labels)".
Attached MAC screen recording for the reference.
This appears to be working as expected in Windows 10. A message pops up letting the user know that "Unfortunately, IGB Windows users cannot save an SVG image in the Whole Frame setting. Please select another option to save an SVG image" when trying to save a "Whole Frame" as a svg file. The default option was already to "Main View with Labels" as well.
Re-reading Prutha's comment, it appears that the problem is the the Whole Frame option is still the default on MacOS. Even though that's not the requested behavior in the ticket (see description), I think this is fine.
So probably this can moved forward to "Done".
cc: Jay Chamma
Note: When you move it forward, re-assign it the original developer - Noor Zahara
[~aloraine]
Moved to done and re-assigned the issue to Noor Zahara
I have attached the dialog box that opens when a user tries to save a svg image on windows.
Code diff https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2315#diff