Logic for filtering terminated EC2 has been added to the play mentioned in the description PR created.

https://bitbucket.org/aloraine/appstore-playbooks/pull-requests/2/igbf-2326-filter-for-the-required-play-has

Please read this and use the same workflow for making branches and submitting PRs:

• https://canvas.instructure.com/courses/1164217/pages/understand-igb-development-workflow?module_item_id=12709540

Key points:

• Do all work on topic branches, not master branch.
• Submit PRs from topic branches (on your fork) to master branch (on team repo)
• Get someone to do first-level review before submitting a PR.
• Add links to your topic branch in Jira ticket.
• Nobody should have more than one ticket assigned to them at a time, except for in the "To-Do" column. In that case, those tickets should mainly be things you've already worked on, such as a topic branch that got put back into "To-Do" because a change request. Or, they could be things you personally want to work on – because you think it would be fun to do or because you're the only person who can do it!

For this particular issue, it should go into the "Needs first level review" column for a bit so that I or someone else can take a look. If the reviewer has no changes requests, they'll move the ticket forward into "Ready for Pull Request" and re-assign it to yourself. At that point, submit a PR.

The goal here is to avoid a bunch of PRs piling up because merging is harder for older PRs.

Chester Dias

I had not seen this doc link before. I will follow it, thanks for letting me know.

Thank you for understanding. I never told you about it until now.

Hi Dr Loraine,
First-Level Review Request: Please review the branch containing the code base for the current ticket.
https://bitbucket.org/chesterdias/appstore-playbooks-igbf-2318/branch/IGBF-2326#diff

A note on the process:
When you are ready for first level review, move the ticket into the "Needs First Level Review" column (as you have done) but also please un-assign it. That lets everybody know it is ready for someone else to pick it up and do the review.
cc: Chester Dias

sure. Done. Thanks for letting me know

Two requests:

1) Please edit above link to the branch using this convention (example):

• https://bitbucket.org/aloraine/appstore-playbooks/branch/IGBF-2307#diff

This makes it easier to find the exact changes on the branch.

2) Add a Jira link to your repository.

Choose Settings > Links > Add new Link

Then choose:

Link type: Jira
Link url: https://jira.transvar.org/
Link key: IGBF

click Save to save the link.

Done.

One last (final) request:

Please edit the commit message - remote ":" and replace with "-" in the jira ticket name so that bitbucket can build a link back to the ticket itself.

e.g.,

change to:

IGBF-2326 Filter for the required play has been added to ignore the terminated instances

from

IGBF:2326 Filter for the required play has been added to ignore the terminated instances

Also, since you will be needing to edit the commit message, do please edit the message to use imperative voice following the convention in https://chris.beams.io/posts/git-commit/

This makes it much easier to scan loads of commit messages and quickly understand the evolution of the code.

Some illustrations!

terrible - just a noun only:

• IGBF-12345 Sandwich

better, but not imperative voice and no reason supplied for the commit:

• IGBF-12345 Sandwich was made

getting better - imperative voice but no reason supplied as yet:

• IGBF-12345 Make a sandwich

best so far! imperative voice and reason supplied for the commit:

• IGBF-12345 Make a sandwich to feed the hungry

or

• IGBF-12345 Make a sandwich as requested by https://xkcd.com/149/

Also, it is totally fine to re-write the commit history of a branch that has not yet been merged in master. Think of it as your own (mostly) private playground to do whatever you want.

Once you are ready to submit a PR, typically you will squash the commits into one single commit. his makes it much easier later on to cherrypick your commit into other branches as needed. Also, it makes training new people much easier because they can more easily view and comprehend the final changes made by a developer to a solve a problem.

Comment amended to link to Jira

https://bitbucket.org/chesterdias/appstore-playbooks-igbf-2318/branch/IGBF-2326#diff

Please submit PR when convenient.

PR submitted...awaiting for merge approval
https://bitbucket.org/aloraine/appstore-playbooks/pull-requests/3/igbf-2326-filter-for-ignoring-terminated

PR request was going to my fork. I merged it before realizing it was going to my fork not the team repository. Normally PRs should go to the team repository, not our forks. So I just now submitted a PR to the team repository and merged it.

my mistake.sorry

Functionality works post merge