Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul
Description
During testing, there's a test case that contacts igbquickload.org.
This is bad because if the remote quickload site is unavailable, the test fails. We should actually be testing the code itself and not the network during unit testing of IGB code base.
Investigate why and how this is happening and fix it.
Attachments
Issue Links
- relates to
-
IGBF-1459 Improve testing in quickload module; relieve dependencies on externally hosted files
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1531 [ 17617 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] | Srishti Tiwari [ stiwari8 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Hi Dr. Loraine, I have added the suggested changes in the Branch. Please review the same.
https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2341#diff
Change request:
The contents.txt file added to the "test" resources directory should contain only those genomes that are available it its quickly directory. Please delete all lines except the A_thaliana_Jun_2009 ones.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Hi Dr. Loraine,
I have removed extra genomes from the quickload directory.
Thanks,
Srishti
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Sprint | Spring 7 : 13 Apr to 24 Apr [ 92 ] | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May [ 92, 93 ] |
| Rank | Ranked higher |
Is the quickload site supposed to be broken? (not sure)
- contents.txt lists a genome that is not in the quickload
- synonyms.txt is an empty file
To check that the QL site is valid, add it to IGB and try to open the genomes (or genome) it contains.
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Hi Dr. Loraine,
I only added the values which were required for the existing test cases to work.
synonyms.txt is empty because in one of the test cases its presence is being checked. It is not necessary for it to have values.
contents.txt contains those two values because there are test cases around it.
I will try to add a test case which checks whether there is a genome present for every entry in contents.txt.
Thanks for the explanation - that sound fine.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Please review the above changes here:
https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2341#diff
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May [ 92, 93 ] | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 92, 93, 94 ] |
| Rank | Ranked higher |
| Sprint | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 92, 93, 94 ] | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 92, 93, 94, 95 ] |
| Rank | Ranked higher |
| Sprint | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 92, 93, 94, 95 ] | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun [ 92, 93, 94, 95, 96 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Nowlan Freese [ nfreese ] | Ann Loraine [ aloraine ] |
| Sprint | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun [ 92, 93, 94, 95, 96 ] | Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 July [ 92, 93, 94, 95, 96, 97 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
Merged.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
QuickloadDataProviderTest and QuickloadUtilsTest tests completed successfully with no internet.
Closing issue.
| Assignee | Nowlan Freese [ nfreese ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Please Review:
In this, I added a few files in test resources folder to create a quickload and removed the dependency of the actual quickload URL.
https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/7b87f57564a0c1e20c43fd21121f6caf2b0c6646