Details
-
Type:
New Feature
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.25
-
Epic Link:
-
Sprint:Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May
Description
deployS3 role was migrated to a new role named appstore_s3 as part of IGBF-2342.
However, it has not been tested.
For this task, modify role appstore_s3 as required to ensure that the S3 bucket is created.
In addition, create a role that will allow the AppStore VM to modify the newly created S3 bucket. Assign the role to the VM.
The role should have name ec2_name
Attachments
Activity
Requested Changes are made, Please review
https://bitbucket.org/chesterdias/chester-local-appstore-playbooks/branch/IGBF-2346#diff
Change requests - please take a look:
- Do not make any changes to EC instance as it is not created yet - please note order of role execution in set_up.yml.
- Accordingly, check role appstore_ec2 to ensure it is created using the new syntax.
Please note: the master branch version of appstore_s3/tasks/main.yml does not create a stand-alone policy but instead simply modifies a role that is created in the previous task. The proposed changes are an improvement on this because a stand-alone policy is being created, which is a better because this same policy can be separately attached to IAM users, thus allowing them to use the AWS console to make changes to their App Store's bucket.
- Change "policy_name" in task "Create IAM Managed Policy" to {{ s3_bucket_name }}.
- Change "name" in task "Create IAM role if not present for Ec2" to {{ s3_bucket_name }}
- Carefully compare proposed changes to master branch version to ensure existing functionality or assumptions will not be disrupted. If they are, please fix accordingly.
I have checked the order, the proposed change has been added.
I have moved the for 'granting a role to ec2' to appstore_ec2 since the ec2 won't be created till that execution point.
Please review the change:https://bitbucket.org/chesterdias/chester-local-appstore-playbooks/branch/IGBF-2346#diff
If you have time left today, could you work on this one?
(if yes, move it to In Progress)