Requested Changes are made, Please review
https://bitbucket.org/chesterdias/chester-local-appstore-playbooks/branch/IGBF-2346#diff

Change requests - please take a look:

• Do not make any changes to EC instance as it is not created yet - please note order of role execution in set_up.yml.

• Accordingly, check role appstore_ec2 to ensure it is created using the new syntax.

Please note: the master branch version of appstore_s3/tasks/main.yml does not create a stand-alone policy but instead simply modifies a role that is created in the previous task. The proposed changes are an improvement on this because a stand-alone policy is being created, which is a better because this same policy can be separately attached to IAM users, thus allowing them to use the AWS console to make changes to their App Store's bucket.

• Change "policy_name" in task "Create IAM Managed Policy" to {{ s3_bucket_name }}.

• Change "name" in task "Create IAM role if not present for Ec2" to {{ s3_bucket_name }}

• Carefully compare proposed changes to master branch version to ensure existing functionality or assumptions will not be disrupted. If they are, please fix accordingly.

I have checked the order, the proposed change has been added.
I have moved the for 'granting a role to ec2' to appstore_ec2 since the ec2 won't be created till that execution point.

Please review the change:https://bitbucket.org/chesterdias/chester-local-appstore-playbooks/branch/IGBF-2346#diff