Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2373

Move transcript isoform App into a separate repository

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      0.25
    • Sprint:
      Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun

      Description

      Following previously describe workflows, migrate transcript isoform app from the "experimental apps" repository into a separate repository just for this one app.

      As before, preserve the commit history of the app.

      See similar, related issues for tips on how to do this, if required. This was most recently done for the NCBI Primer App by Pooja Nikhare.

      Please note:

      This should be done only after IGBF-2123 code has been merged into master.

        Attachments

          Issue Links

            Activity

            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            created a new repo for the app which can be found at:
            https://bitbucket.org/pkulka10/transcriptisoform/src/master/
            Please let me know if you want me to transfer the ownership of the repository to lorainelab.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - created a new repo for the app which can be found at: https://bitbucket.org/pkulka10/transcriptisoform/src/master/ Please let me know if you want me to transfer the ownership of the repository to lorainelab.
            Hide
            ann.loraine Ann Loraine added a comment -

            Commits are visible from way back. Do please go ahead and transfer the repo to lorainelab.

            Show
            ann.loraine Ann Loraine added a comment - Commits are visible from way back. Do please go ahead and transfer the repo to lorainelab.
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            I have transferred the ownership to lorainelab now.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - I have transferred the ownership to lorainelab now.
            Hide
            ann.loraine Ann Loraine added a comment -

            Repository transfer is accepted.
            Moving back to "to do" and assigning to myself as a reminder to set up bitbucket pipelines for this new repo.

            Show
            ann.loraine Ann Loraine added a comment - Repository transfer is accepted. Moving back to "to do" and assigning to myself as a reminder to set up bitbucket pipelines for this new repo.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            There is no pipeline file in the repo. This needs to be added.

            To do this:

            • Copy NCBI primer App bitbucket pipelines file and update it for the new App
            • Check that we are using the latest Docker image by looking at the bitbucket pipelines file for the IGB repository.
            Show
            ann.loraine Ann Loraine added a comment - - edited There is no pipeline file in the repo. This needs to be added. To do this: Copy NCBI primer App bitbucket pipelines file and update it for the new App Check that we are using the latest Docker image by looking at the bitbucket pipelines file for the IGB repository.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            The repository for Transcript Isoform is https://bitbucket.org/lorainelab/transcriptisoform.
            The repository for NCBI Primer App is https://bitbucket.org/lorainelab/ncbi-primer

            Show
            ann.loraine Ann Loraine added a comment - - edited The repository for Transcript Isoform is https://bitbucket.org/lorainelab/transcriptisoform . The repository for NCBI Primer App is https://bitbucket.org/lorainelab/ncbi-primer
            Hide
            ann.loraine Ann Loraine added a comment -

            Recommended workflow:

            • Fork Transcript Isoform App.
            • Enable bitbucket piplines on your new fork.
            • Create a bitbucket.yml file in your fork.
            • Copy the text from NCBI Primer App Bitbucket pipeline into that file.
            • Edit it (replace NCBI primer app reference with "transcript isoform")
            • Add a BB_AUTH_STRING as a new repository variable in your fork.
            • Run the pipeline manually to test.
            Show
            ann.loraine Ann Loraine added a comment - Recommended workflow: Fork Transcript Isoform App. Enable bitbucket piplines on your new fork. Create a bitbucket.yml file in your fork. Copy the text from NCBI Primer App Bitbucket pipeline into that file. Edit it (replace NCBI primer app reference with "transcript isoform") Add a BB_AUTH_STRING as a new repository variable in your fork. Run the pipeline manually to test.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Link to branch: https://bitbucket.org/Rweidenh/transcriptisoform/branch/IGBF-2373

            The pipelines file is added and
            the Docker image is updated to jre-1.8.0_241

            mvn clean package error
            It appears that the POM needs to be reconfigured.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Link to branch: https://bitbucket.org/Rweidenh/transcriptisoform/branch/IGBF-2373 The pipelines file is added and the Docker image is updated to jre-1.8.0_241 mvn clean package error It appears that the POM needs to be reconfigured.
            Hide
            ann.loraine Ann Loraine added a comment -

            Please re-read:

            https://canvas.instructure.com/courses/1164217/pages/understand-igb-development-workflow?module_item_id=12709540

            Once the installer is built, developer adds a link to their topic branch to the Jira issue as a Comment. They then move the issue into the next column - "Needs 1st Level Review" - and un-assigns the issue. This signals to everyone else that the issue is now ready for review, and anyone with time and expertise can pick it up.

            When you move to "Needs 1st Level Review" you need to un-assign the issue so that everyone knows it's ready to be picked up and reviewed. If you leave it assigned to yourself, everyone else will think you are planning to review it. They won't see that you were the original developer unless they click on it and read it.

            cc: Jay Chamma

            Show
            ann.loraine Ann Loraine added a comment - Please re-read: https://canvas.instructure.com/courses/1164217/pages/understand-igb-development-workflow?module_item_id=12709540 Once the installer is built, developer adds a link to their topic branch to the Jira issue as a Comment. They then move the issue into the next column - "Needs 1st Level Review" - and un-assigns the issue. This signals to everyone else that the issue is now ready for review, and anyone with time and expertise can pick it up. When you move to "Needs 1st Level Review" you need to un-assign the issue so that everyone knows it's ready to be picked up and reviewed. If you leave it assigned to yourself, everyone else will think you are planning to review it. They won't see that you were the original developer unless they click on it and read it. cc: Jay Chamma
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Change requests:

            • Edit the commit message to include the ticket name (see examples from commit history)

            Also, to make working with the fork more convenient

            • Add a Jira link to your transcript isoform fork - see new page in Canvas course with info on how to do this

            I realized when I looked at your fork that I failed to include the Jira link configuration step.

            I fixed this just now by adding a new page and reorganizing an existing page.

            Please go back to the IGB class Module titled "Setting up" and read the content again.

            Then try to add the Jira link to your IGB fork and to your fork of the Transcript Isoform repository. Add any comments you have here for me to take a look.

            I would like to improve the on-boarding materials so your feedback could be super helpful!

            cc: Logan Weidenhammer

            Show
            ann.loraine Ann Loraine added a comment - - edited Change requests: Edit the commit message to include the ticket name (see examples from commit history) Also, to make working with the fork more convenient Add a Jira link to your transcript isoform fork - see new page in Canvas course with info on how to do this I realized when I looked at your fork that I failed to include the Jira link configuration step. I fixed this just now by adding a new page and reorganizing an existing page. Please go back to the IGB class Module titled "Setting up" and read the content again. Then try to add the Jira link to your IGB fork and to your fork of the Transcript Isoform repository. Add any comments you have here for me to take a look. I would like to improve the on-boarding materials so your feedback could be super helpful! cc: Logan Weidenhammer
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

            Commit message is edited to include the ticket name IGBF-2373 with a short description.

            The Jira link is added to my Transcript Isoform fork per the canvas instructions.

            Canvas page feedback:

            Under "Set up your local IGB development environment" > "Clone your fork to your local computer" > "3. Install the version of Java needed by IGB".
            The link for number 3 goes to netbeans.org. Should it instead go to the latest JDK download site? https://www.oracle.com/java/technologies/javase-downloads.html
            Or the Oracle Java Archive where they can choose the version to download? https://www.oracle.com/java/technologies/oracle-java-archive-downloads.html

            And on the "Understand IGB development workflow" page > "Functional review" where it talks about the topic branch installer, it was helpful to me to be told that the 'installer' was referring to the 'exe' file. So I think adding something about that to the Functional review section would be helpful for on-boarding.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited Commit message is edited to include the ticket name IGBF-2373 with a short description. The Jira link is added to my Transcript Isoform fork per the canvas instructions. Canvas page feedback: Under "Set up your local IGB development environment" > "Clone your fork to your local computer" > "3. Install the version of Java needed by IGB". The link for number 3 goes to netbeans.org. Should it instead go to the latest JDK download site? https://www.oracle.com/java/technologies/javase-downloads.html Or the Oracle Java Archive where they can choose the version to download? https://www.oracle.com/java/technologies/oracle-java-archive-downloads.html And on the "Understand IGB development workflow" page > "Functional review" where it talks about the topic branch installer, it was helpful to me to be told that the 'installer' was referring to the 'exe' file. So I think adding something about that to the Functional review section would be helpful for on-boarding.
            Hide
            ann.loraine Ann Loraine added a comment -

            Thanks for the feedback Logan Weidenhammer !

            Show
            ann.loraine Ann Loraine added a comment - Thanks for the feedback Logan Weidenhammer !
            Hide
            ann.loraine Ann Loraine added a comment -

            Ready for PR.

            Show
            ann.loraine Ann Loraine added a comment - Ready for PR.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Should I create a pull request from my fork's master branch to the lab's master even though the topic branch pipeline does not build?

            The POM needs to be reconfigured.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Should I create a pull request from my fork's master branch to the lab's master even though the topic branch pipeline does not build? The POM needs to be reconfigured.
            Hide
            ann.loraine Ann Loraine added a comment -

            Changes should always be made on a topic branch, which you then push to your fork. You then issue a PR from the topic branch on your fork to the master branch on the team repo.

            Can you let me know if there is misleading documentation about that somewhere?

            Show
            ann.loraine Ann Loraine added a comment - Changes should always be made on a topic branch, which you then push to your fork. You then issue a PR from the topic branch on your fork to the master branch on the team repo. Can you let me know if there is misleading documentation about that somewhere?
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            I think the documentation is good. The problem for me was understanding the effect of rebasing versus merging, so I did some reading on that. Confirming that the topic branch is used to create a pull request directly to the master branch on the team repo does help a lot.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - I think the documentation is good. The problem for me was understanding the effect of rebasing versus merging, so I did some reading on that. Confirming that the topic branch is used to create a pull request directly to the master branch on the team repo does help a lot.

              People

              • Assignee:
                Unassigned
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: