[IGBF-2431] Fix top menu bar styling on mobile - JIRA UNCC

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Labels:
None

Story Points:
0.75
Epic Link:
Improve IGB for users
Sprint:
Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul, Summer 3: 6 Jul - 17 Jul

Description

After porting the bioviz menu bar into the genome dashboard project, there have been some styling conflict issues. These were resolved for the desktop version of the site, however, the mobile version menu does not stay open when toggled. For this ticket, modify the menu styling to resemble the appearance and behavior present on mobile bioviz.org.

Attachments

Issue Links

blocks

IGBF-2414 Investigate: Include bioviz menu bar in genome-dashboard

Closed

is blocked by

IGBF-2442 Update to bootstrap 4 on bioviz and genome dashboard

Closed

Activity

Ascending order - Click to sort in descending order

Philip Badzuh (Inactive) created issue - 15/Jun/20 10:21 AM

Philip Badzuh (Inactive) made changes - 15/Jun/20 10:21 AM

Field	Original Value	New Value
Epic Link		IGBF-1765 [ 17855 ]

Philip Badzuh (Inactive) made changes - 15/Jun/20 10:21 AM

Link

This issue blocks ~~IGBF-2414~~ [ ~~IGBF-2414~~ ]

Philip Badzuh (Inactive) made changes - 15/Jun/20 11:07 AM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 16/Jun/20 11:47 AM

Please see my changes at the branch below:
https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2431#diff

Prevent bootstrap 3 and 4 javascript and css from conflicting - opt for bootstrap 3, on which the bioviz menu is based
menu now functions as expected and resembles that of bioviz.org on mobile

Show

Philip Badzuh (Inactive) added a comment - 16/Jun/20 11:47 AM Please see my changes at the branch below: https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2431#diff Prevent bootstrap 3 and 4 javascript and css from conflicting - opt for bootstrap 3, on which the bioviz menu is based menu now functions as expected and resembles that of bioviz.org on mobile

Philip Badzuh (Inactive) made changes - 16/Jun/20 11:47 AM

Story Points

0.5

0.75

Philip Badzuh (Inactive) made changes - 16/Jun/20 11:47 AM

Status

In Progress [ 3 ]

Needs 1st Level Review [ 10005 ]

Philip Badzuh (Inactive) made changes - 16/Jun/20 11:47 AM

Assignee

Philip Badzuh [ pbadzuh ]

Ann Loraine made changes - 19/Jun/20 2:44 PM

Link

This issue relates to ~~IGBF-2442~~ [ ~~IGBF-2442~~ ]

Ann Loraine made changes - 19/Jun/20 2:46 PM

Status

Needs 1st Level Review [ 10005 ]

First Level Review in Progress [ 10301 ]

Ann Loraine made changes - 19/Jun/20 2:46 PM

Status

First Level Review in Progress [ 10301 ]

Ready for Pull Request [ 10304 ]

Ann Loraine made changes - 19/Jun/20 2:46 PM

Assignee

Philip Badzuh [ pbadzuh ]

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 19/Jun/20 2:47 PM

Please see PR below:
https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/21/igbf-2431-fix-top-menu-bar-styling-on/diff

Show

Philip Badzuh (Inactive) added a comment - 19/Jun/20 2:47 PM Please see PR below: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/21/igbf-2431-fix-top-menu-bar-styling-on/diff

Philip Badzuh (Inactive) made changes - 19/Jun/20 2:47 PM

Status

Ready for Pull Request [ 10304 ]

Pull Request Submitted [ 10101 ]

Philip Badzuh (Inactive) made changes - 19/Jun/20 2:47 PM

Assignee

Philip Badzuh [ pbadzuh ]

Ann Loraine made changes - 19/Jun/20 5:05 PM

Status

Pull Request Submitted [ 10101 ]

Reviewing Pull Request [ 10303 ]

Ann Loraine made changes - 19/Jun/20 5:05 PM

Status

Reviewing Pull Request [ 10303 ]

Merged Needs Testing [ 10002 ]

Hide

Permalink

Ann Loraine added a comment - 19/Jun/20 5:07 PM

Merged and deployed to test.bioviz.org.

Show

Ann Loraine added a comment - 19/Jun/20 5:07 PM Merged and deployed to test.bioviz.org.

Hide

Permalink

Ann Loraine added a comment - 19/Jun/20 7:26 PM

Looks like this new change may break info icon functionality. Testing now.

Show

Ann Loraine added a comment - 19/Jun/20 7:26 PM Looks like this new change may break info icon functionality. Testing now.

Hide

Permalink

Ann Loraine added a comment - 19/Jun/20 7:37 PM

Reverting commit due to problem with "i" icon functionality. Moving back to "To-Do" for Philip Badzuh to take a look at on Monday. (Please note: It can wait until then! No need to do anything over the weekend. Enjoy your days off!)

Show

Ann Loraine added a comment - 19/Jun/20 7:37 PM Reverting commit due to problem with "i" icon functionality. Moving back to "To-Do" for Philip Badzuh to take a look at on Monday. (Please note: It can wait until then! No need to do anything over the weekend. Enjoy your days off!)

Ann Loraine made changes - 19/Jun/20 7:37 PM

Status

Merged Needs Testing [ 10002 ]

Post-merge Testing In Progress [ 10003 ]

Ann Loraine made changes - 19/Jun/20 7:37 PM

Status

Post-merge Testing In Progress [ 10003 ]

To-Do [ 10305 ]

Ann Loraine made changes - 19/Jun/20 7:37 PM

Assignee

Philip Badzuh [ pbadzuh ]

Ann Loraine made changes - 19/Jun/20 8:02 PM

Rank

Ranked higher

Ann Loraine made changes - 19/Jun/20 8:59 PM

Sprint

Summer 1: 8 Jun - 19 Jun [ 96 ]

Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 July [ 96, 97 ]

Ann Loraine made changes - 19/Jun/20 8:59 PM

Rank

Ranked higher

Ann Loraine made changes - 21/Jun/20 11:39 PM

Link

This issue is blocked by ~~IGBF-2442~~ [ ~~IGBF-2442~~ ]

Ann Loraine made changes - 21/Jun/20 11:39 PM

Link

This issue relates to ~~IGBF-2442~~ [ ~~IGBF-2442~~ ]

Philip Badzuh (Inactive) made changes - 22/Jun/20 10:03 AM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Philip Badzuh (Inactive) made changes - 22/Jun/20 10:07 AM

Status

In Progress [ 3 ]

To-Do [ 10305 ]

Philip Badzuh (Inactive) made changes - 30/Jun/20 6:40 PM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Philip Badzuh (Inactive) made changes - 01/Jul/20 10:01 AM

Status

In Progress [ 3 ]

To-Do [ 10305 ]

Philip Badzuh (Inactive) made changes - 01/Jul/20 12:19 PM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 02/Jul/20 12:54 PM

Please see the changes on my branch below:
https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2431#diff

These:

Make all of genome dashboard run on bootstrap 4, including the top menu bar pulled in from bioiz

TODO: Update bioviz ansible playbooks to accommodate these changes

Show

Philip Badzuh (Inactive) added a comment - 02/Jul/20 12:54 PM Please see the changes on my branch below: https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2431#diff These: Make all of genome dashboard run on bootstrap 4, including the top menu bar pulled in from bioiz TODO: Update bioviz ansible playbooks to accommodate these changes

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 02/Jul/20 2:08 PM

Please see the branch below:
https://bitbucket.org/pbadzuh/bioviz-playbooks_pbdev/branch/IGBF-2431#diff

This updates bioviz ansible playbooks to support the recent changes made to bioviz in ~~IGBF-2442~~ as well as those mentioned in the previous comment.

Show

Philip Badzuh (Inactive) added a comment - 02/Jul/20 2:08 PM Please see the branch below: https://bitbucket.org/pbadzuh/bioviz-playbooks_pbdev/branch/IGBF-2431#diff This updates bioviz ansible playbooks to support the recent changes made to bioviz in IGBF-2442 as well as those mentioned in the previous comment.

Philip Badzuh (Inactive) made changes - 02/Jul/20 2:08 PM

Status

In Progress [ 3 ]

Needs 1st Level Review [ 10005 ]

Philip Badzuh (Inactive) made changes - 02/Jul/20 2:08 PM

Assignee

Philip Badzuh [ pbadzuh ]

Hide

Permalink

Ann Loraine added a comment - 06/Jul/20 7:25 AM

Please submit PR.

Show

Ann Loraine added a comment - 06/Jul/20 7:25 AM Please submit PR.

Ann Loraine made changes - 06/Jul/20 7:25 AM

Status

Needs 1st Level Review [ 10005 ]

First Level Review in Progress [ 10301 ]

Ann Loraine made changes - 06/Jul/20 7:25 AM

Status

First Level Review in Progress [ 10301 ]

Ready for Pull Request [ 10304 ]

Ann Loraine made changes - 06/Jul/20 7:25 AM

Assignee

Philip Badzuh [ pbadzuh ]

Ann Loraine made changes - 06/Jul/20 8:07 AM

Sprint

Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul [ 96, 97 ]

Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul, Summer 3: 3 Jul - 14 Jul [ 96, 97, 98 ]

Ann Loraine made changes - 06/Jul/20 8:07 AM

Rank

Ranked higher

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 06/Jul/20 10:28 AM

Please see PRs below:
https://bitbucket.org/lorainelab/bioviz-playbooks/pull-requests/3/igbf-2431-update-bioviz-menu-import-task/diff

https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/24/igbf-2431-update-bioviz-bootstrap-4-top/diff

Show

Philip Badzuh (Inactive) added a comment - 06/Jul/20 10:28 AM Please see PRs below: https://bitbucket.org/lorainelab/bioviz-playbooks/pull-requests/3/igbf-2431-update-bioviz-menu-import-task/diff https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/24/igbf-2431-update-bioviz-bootstrap-4-top/diff

Philip Badzuh (Inactive) made changes - 06/Jul/20 10:28 AM

Status

Ready for Pull Request [ 10304 ]

Pull Request Submitted [ 10101 ]

Philip Badzuh (Inactive) made changes - 06/Jul/20 10:28 AM

Assignee

Philip Badzuh [ pbadzuh ]

Ann Loraine made changes - 06/Jul/20 11:10 AM

Status

Pull Request Submitted [ 10101 ]

Reviewing Pull Request [ 10303 ]

Ann Loraine made changes - 06/Jul/20 11:10 AM

Status

Reviewing Pull Request [ 10303 ]

Merged Needs Testing [ 10002 ]

Hide

Permalink

Ann Loraine added a comment - 06/Jul/20 11:11 AM

Merged.

Show

Ann Loraine added a comment - 06/Jul/20 11:11 AM Merged.

Jay Chamma (Inactive) made changes - 09/Jul/20 3:06 PM

Assignee

Jay Chamma [ gchamma ]

Jay Chamma (Inactive) made changes - 09/Jul/20 3:07 PM

Status

Merged Needs Testing [ 10002 ]

Post-merge Testing In Progress [ 10003 ]

Hide

Permalink

Jay Chamma (Inactive) added a comment - 09/Jul/20 3:27 PM - edited

Post merge testing:
The mobile menu for bioviz.org is fixed stays open when toggled

I have checked this fix by:
1. Checking on an android phone by visiting bioviz.org
2. Checking on an iPad by visiting bioviz.org
3. Using the toggle device toolbar option on Chrome to switch my view from a desktop perspective to a mobile perspective on my desktop display.

All testing steps showed no issues and the problem looks to be fixed.

Moving this ticket to "Done" and re-assigning it to Philip Badzuh

Show

Jay Chamma (Inactive) added a comment - 09/Jul/20 3:27 PM - edited Post merge testing: The mobile menu for bioviz.org is fixed stays open when toggled I have checked this fix by: 1. Checking on an android phone by visiting bioviz.org 2. Checking on an iPad by visiting bioviz.org 3. Using the toggle device toolbar option on Chrome to switch my view from a desktop perspective to a mobile perspective on my desktop display. All testing steps showed no issues and the problem looks to be fixed. Moving this ticket to "Done" and re-assigning it to Philip Badzuh

Jay Chamma (Inactive) made changes - 09/Jul/20 3:27 PM

Resolution		Done [ 10000 ]
Status	Post-merge Testing In Progress [ 10003 ]	Closed [ 6 ]

Jay Chamma (Inactive) made changes - 09/Jul/20 3:27 PM

Assignee

Jay Chamma [ gchamma ]

Philip Badzuh [ pbadzuh ]

People

Assignee:

Philip Badzuh (Inactive)

Reporter:

Philip Badzuh (Inactive)

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

15/Jun/20 10:21 AM

Updated:

13/Jul/20 10:05 AM

Resolved:

09/Jul/20 3:27 PM