Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2462

Investigate: Fix checkmarks in View menu on Windows

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug

      Description

      In the usability review done by Logan Weidenhammer, she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.

      Note that this is a serious issue because it prevents Windows users from viewing the View menu items.

      When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.

      Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?

      If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments. Note: What you learn will be used by whomever works on the fix.

      Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1765 [ 17855 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Description In the usability review done by [~rweidenh], she noticed that the IGB View menu contains many items which appear as blue squares when selected.

            Please investigate: Is this a problem with other Windows systems, or was it somehow unique to her machine?

            Please see attached images from Rachel's Windows machine and a Mac computer. The items in the *View* menu are on/off selections and anything that is selected should display the usual icon but with a checkmark next to it.

            Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items.
            In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.

            Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items.

            When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.

            Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?

            Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.

            ann.loraine Ann Loraine made changes -
            Attachment ViewMenuOnMac.png [ 14771 ]
            ann.loraine Ann Loraine made changes -
            Attachment ViewMenuOnWindows.png [ 14772 ]
            ann.loraine Ann Loraine made changes -
            Story Points 2 0.5
            ann.loraine Ann Loraine made changes -
            Description In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.

            Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items.

            When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.

            Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?

            Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.

            In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.

            Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items.

            When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.

            Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?

            If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments and create a new Jira ticket to fix the problem. Please add it to the *current sprint* and link that issue to this one.

            Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.

            ann.loraine Ann Loraine made changes -
            Description In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.

            Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items.

            When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.

            Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?

            If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments and create a new Jira ticket to fix the problem. Please add it to the *current sprint* and link that issue to this one.

            Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.

            In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.

            Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items.

            When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.

            Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?

            If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments. Note: What you learn will be used by whomever works on the fix.

            Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.

            ann.loraine Ann Loraine made changes -
            Link This issue blocks IGBF-2465 [ IGBF-2465 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Summary Investigate: Fix checkmarks in View menu for windows Investigate: Fix checkmarks in View menu on Windows
            ann.loraine Ann Loraine made changes -
            Assignee Prutha Kulkarni [ prutha ]
            ann.loraine Ann Loraine made changes -
            Assignee Prutha Kulkarni [ prutha ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Me and Prutha Kulkarni were working on this today to check the issue on both Mac and Windows. We made the following observations:
            1] The icons for menu items which are not displayed have an icon path pointing to the "blank_placeholder.png". If a proper image icon is passed, the icons are displayed properly.
            2] The problem with the blue background is, it is a placeholder for checkbox which is not visible on Windows. The background is transparent when the checkbox is not checked [the menu item is not selected], and it turns blue on checking the checkbox. Initially all the check-boxes are checked, because of which it is displayed as blue. And for some reason the checkbox and icons are overlapping on Windows.
            3] We were trying to understand the implementation of check-boxes by comparing JCheckBoxMenuItem and JRPCheckBoxMenuItem. JCheckBoxMenuItem is a compiled class whereas JRPCheckBoxMenuItem is a part of igb-swing-implementation and extends JCheckBoxMenuItem. We are thinking if there is any way to get a reference of the menu-item container so that we can set the positions of icons and check-boxes separately. So we will have to dig deeper for this part.

            cc. Prof. [~aloraine]

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Me and Prutha Kulkarni were working on this today to check the issue on both Mac and Windows. We made the following observations: 1] The icons for menu items which are not displayed have an icon path pointing to the "blank_placeholder.png". If a proper image icon is passed, the icons are displayed properly. 2] The problem with the blue background is, it is a placeholder for checkbox which is not visible on Windows. The background is transparent when the checkbox is not checked [the menu item is not selected] , and it turns blue on checking the checkbox. Initially all the check-boxes are checked, because of which it is displayed as blue. And for some reason the checkbox and icons are overlapping on Windows. 3] We were trying to understand the implementation of check-boxes by comparing JCheckBoxMenuItem and JRPCheckBoxMenuItem. JCheckBoxMenuItem is a compiled class whereas JRPCheckBoxMenuItem is a part of igb-swing-implementation and extends JCheckBoxMenuItem. We are thinking if there is any way to get a reference of the menu-item container so that we can set the positions of icons and check-boxes separately. So we will have to dig deeper for this part. cc. Prof. [~aloraine]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment Checkbox.png [ 14775 ]
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            Me and Shamika Gajanan Kulkarni were working on fixing the checkbox and icon overlap in the IGB menu.
            We tried following things today:
            1] We tried to change a few properties of the JCheckBoxMenuItem such as changing background and foreground color, horizontal alignment, gap between icon and text, component orientation. We were able to change those things but found out that the icon and checkbox positions are not changing even we set these properties.
            2] We tried to add extra menu entries to check if the problem was arising because of the icon being part of the menu class constructor.
            3] We also referred the transcript Isoform app as it also renders checkBoxMenu inside IGB menu. Since there were no icons for the submenus, the checkbox was showing up. Then we tried to add the icon to the menu just to make sure if it overlaps with the checkbox and found out that the issue is still there.

            We have attached the screenshot for future reference. Tomorrow we will again try to set some properties to investigate the same.
            cc: [~aloraine]

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - Me and Shamika Gajanan Kulkarni were working on fixing the checkbox and icon overlap in the IGB menu. We tried following things today: 1] We tried to change a few properties of the JCheckBoxMenuItem such as changing background and foreground color, horizontal alignment, gap between icon and text, component orientation. We were able to change those things but found out that the icon and checkbox positions are not changing even we set these properties. 2] We tried to add extra menu entries to check if the problem was arising because of the icon being part of the menu class constructor. 3] We also referred the transcript Isoform app as it also renders checkBoxMenu inside IGB menu. Since there were no icons for the submenus, the checkbox was showing up. Then we tried to add the icon to the menu just to make sure if it overlaps with the checkbox and found out that the issue is still there. We have attached the screenshot for future reference. Tomorrow we will again try to set some properties to investigate the same. cc: [~aloraine]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Story Points 0.5 4
            Show
            prutha Prutha Kulkarni (Inactive) added a comment - Closed Bug link: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4199382
            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Swing rendering issue in Java 8: https://yakovfain.com/2014/06/27/swing-rendering-seems-to-be-broken-in-java-8/
            prutha Prutha Kulkarni (Inactive) made changes -
            Attachment Screen Shot 2020-07-09 at 6.29.58 PM.png [ 14776 ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Comment [ UI after changing settings on mac ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Referred the following links along with the ones mentioned above to get some idea for the next steps.
            https://stackoverflow.com/questions/30701990/add-image-to-jcheckboxmenuitem
            https://stackoverflow.com/questions/10465736/align-icon-and-jcheckbox-in-jpopupmenu

            Me and Prutha Kulkarni tried changing properties like 'setHorizontalTextAlignment', 'setIconTextGap' and 'setMargin' for each of the menu items individually, first for TranscriptIsoForm App [because IGB was taking too long to build] and then for IGB.
            After trying different values, we were able to conclude that each Menu Item had to be customized individually for results based on the length of text in the menu item. I have attached a screenshot for a set of values which seemed to work for Windows.
            However, when the similar values were tried on Mac, it changed the orientation of the checkbox, icon and text of menu item. A screenshot for the same has been attached by Prutha Kulkarni

            Please let us know your views on this, Dr. [~aloraine]

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Referred the following links along with the ones mentioned above to get some idea for the next steps. https://stackoverflow.com/questions/30701990/add-image-to-jcheckboxmenuitem https://stackoverflow.com/questions/10465736/align-icon-and-jcheckbox-in-jpopupmenu Me and Prutha Kulkarni tried changing properties like 'setHorizontalTextAlignment', 'setIconTextGap' and 'setMargin' for each of the menu items individually, first for TranscriptIsoForm App [because IGB was taking too long to build] and then for IGB. After trying different values, we were able to conclude that each Menu Item had to be customized individually for results based on the length of text in the menu item. I have attached a screenshot for a set of values which seemed to work for Windows. However, when the similar values were tried on Mac, it changed the orientation of the checkbox, icon and text of menu item. A screenshot for the same has been attached by Prutha Kulkarni Please let us know your views on this, Dr. [~aloraine]
            prutha Prutha Kulkarni (Inactive) made changes -
            Attachment Screen Shot 2020-07-09 at 6.29.58 PM.png [ 14776 ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Hide
            ann.loraine Ann Loraine added a comment -

            Question regarding this comment:

            • "1] The icons for menu items which are not displayed have an icon path pointing to the "blank_placeholder.png". If a proper image icon is passed, the icons are displayed properly.:

            I do not understand. Why is "blank_placeholder.png" not a proper image icon? Does it not exist in the code base or is it an actual image that is merely transparent?

            cc: Prutha Kulkarni

            Show
            ann.loraine Ann Loraine added a comment - Question regarding this comment: "1] The icons for menu items which are not displayed have an icon path pointing to the "blank_placeholder.png". If a proper image icon is passed, the icons are displayed properly.: I do not understand. Why is "blank_placeholder.png" not a proper image icon? Does it not exist in the code base or is it an actual image that is merely transparent? cc: Prutha Kulkarni
            Hide
            ann.loraine Ann Loraine added a comment -

            IGB class used to display menu items in the View menu:

            As noted above, it extends javax.swing.JCheckBoxMenuItem.

            It implements com.affymetrix.igb.swing.WeightedJRPWidget, used in IGB to determine order (top to bottom) of menu items in the View menu. Note that this interface extends com.affymetrix.igb.swing.JRPWidget. Together, the two interfaces contain only three methods:

            From com.affymetrix.igb.swing.JRPWidget:

            public String getId();
            public boolean consecutiveOK();
            

            From com.affymetrix.igb.swing.WeightedJRPWidget:

            public int getWeight();
            

            Shamika Gajanan Kulkarni and Prutha Kulkarni - please review the code of JRPCheckBoxMenuItem.java and add appropriate annotations and comments to indicate which methods (if any) are overriding the parent class JCheckBoxMenuItem and which methods are implementing promised methods from the interface.

            Note: I think that getId and consecutiveOK are from interactive tutorial code that David Norris worked on as a graduate student in 2014.

            Show
            ann.loraine Ann Loraine added a comment - IGB class used to display menu items in the View menu: https://bitbucket.org/lorainelab/integrated-genome-browser/src/master/core/igb-swing-ext/src/main/java/com/affymetrix/igb/swing/JRPCheckBoxMenuItem.java As noted above, it extends javax.swing.JCheckBoxMenuItem. It implements com.affymetrix.igb.swing.WeightedJRPWidget, used in IGB to determine order (top to bottom) of menu items in the View menu. Note that this interface extends com.affymetrix.igb.swing.JRPWidget. Together, the two interfaces contain only three methods: From com.affymetrix.igb.swing.JRPWidget: public String getId(); public boolean consecutiveOK(); From com.affymetrix.igb.swing.WeightedJRPWidget: public int getWeight(); Shamika Gajanan Kulkarni and Prutha Kulkarni - please review the code of JRPCheckBoxMenuItem.java and add appropriate annotations and comments to indicate which methods (if any) are overriding the parent class JCheckBoxMenuItem and which methods are implementing promised methods from the interface. Note: I think that getId and consecutiveOK are from interactive tutorial code that David Norris worked on as a graduate student in 2014.
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            The "blank_placeholder.png" image is a transparent background image with the same dimensions as that of other icons. It is present in the common directory under "16x16/actions" folder.
            Also, we will review the code for "JRPCheckBoxMenuItem" and we will add appropriate annotations and comments as requested.
            cc: [~aloraine], Shamika Gajanan Kulkarni

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - The "blank_placeholder.png" image is a transparent background image with the same dimensions as that of other icons. It is present in the common directory under "16x16/actions" folder. Also, we will review the code for "JRPCheckBoxMenuItem" and we will add appropriate annotations and comments as requested. cc: [~aloraine] , Shamika Gajanan Kulkarni
            Hide
            ann.loraine Ann Loraine added a comment -

            Next step: Short meeting to discuss the problem. Possibly make a slide deck to lay out the problem and clarify. Moving back to "To-Do" and assigning to Shamika Gajanan Kulkarni to set up a quick meeting.

            Show
            ann.loraine Ann Loraine added a comment - Next step: Short meeting to discuss the problem. Possibly make a slide deck to lay out the problem and clarify. Moving back to "To-Do" and assigning to Shamika Gajanan Kulkarni to set up a quick meeting.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 3: 6 Jul - 17 Jul [ 98 ] Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            Findings on the feasibility of whether we use any existing function to sync MenuItem actions with the preference tab checkbox which corresponds to the same menu item:

            • There are two ways according to me which we can use to achieve desired effect: IgbService, PreferenceUtils
            • IgbService:
              There are two functions which are present in the IGB service implementation currently which access the preference panel and change a particular tab state as "selected". Also, there is a function to get a particular preference tab index.
              Suggestion 1:
              Like these functions we can create a new function for "View settings" if we decide to add a new tab for "View settings". This function would access the "View settings" tab whenever a checkbox menu item is changed and the function would access corresponding checkbox from the "View settings" tab panel and change its value to true/false.
            • PreferenceUtils:
              Currently there is a "Toolbar" tab in the preference panel which lists out each available menu item which IGB offers. It also has a checkbox corresponding each menu item. If we set the checkbox value for a specific menu item to true then the icon for that particular menuItem would appear in the toolbar section. For achieving this, it makes use of preferenceUtils class functions.
              Suggestion 2:
              We could add another function to preferenceUtils class which access the menu Bar and which would check a particular menu item which corresponds to a preference panel "View Settings" tab checkbox item to keep both of them in sync.

            Suggestion 3:
            We could add only one function to IgbService as it is common to both i.e. the menuBar as well as the new "View Settings" preference tab which would take three parameters.
            Parameter 1: Menu item name which is changed
            Parameter 2: Changed value which is either true or false
            Parameter 3: which differentiates whether to reflect changes on preference tab checkbox item corresponding to the menu item or a menu item corresponding to the preference tab checkbox item. Depending upon which checkbox is clicked i.e. if the menu item checkbox is clicked then this parameter would contain "pref panel" as we need to sync the changes with it and vice versa.
            As per the value of parameter 3 there there would be an if/else case where we would handle the changes.
            According to me IgbService is the best place where we can get the references to most of the IGB components easily.

            Dr. [~aloraine] could you please let me know your thoughts on this?
            Jay Chamma, Chirag Chandrahas Shetty feel free to suggest any other solution which you guys think could work best for this situation.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - Findings on the feasibility of whether we use any existing function to sync MenuItem actions with the preference tab checkbox which corresponds to the same menu item: There are two ways according to me which we can use to achieve desired effect: IgbService, PreferenceUtils IgbService: There are two functions which are present in the IGB service implementation currently which access the preference panel and change a particular tab state as "selected". Also, there is a function to get a particular preference tab index. Suggestion 1: Like these functions we can create a new function for "View settings" if we decide to add a new tab for "View settings". This function would access the "View settings" tab whenever a checkbox menu item is changed and the function would access corresponding checkbox from the "View settings" tab panel and change its value to true/false. PreferenceUtils: Currently there is a "Toolbar" tab in the preference panel which lists out each available menu item which IGB offers. It also has a checkbox corresponding each menu item. If we set the checkbox value for a specific menu item to true then the icon for that particular menuItem would appear in the toolbar section. For achieving this, it makes use of preferenceUtils class functions. Suggestion 2: We could add another function to preferenceUtils class which access the menu Bar and which would check a particular menu item which corresponds to a preference panel "View Settings" tab checkbox item to keep both of them in sync. Suggestion 3: We could add only one function to IgbService as it is common to both i.e. the menuBar as well as the new "View Settings" preference tab which would take three parameters. Parameter 1: Menu item name which is changed Parameter 2: Changed value which is either true or false Parameter 3: which differentiates whether to reflect changes on preference tab checkbox item corresponding to the menu item or a menu item corresponding to the preference tab checkbox item. Depending upon which checkbox is clicked i.e. if the menu item checkbox is clicked then this parameter would contain "pref panel" as we need to sync the changes with it and vice versa. As per the value of parameter 3 there there would be an if/else case where we would handle the changes. According to me IgbService is the best place where we can get the references to most of the IGB components easily. Dr. [~aloraine] could you please let me know your thoughts on this? Jay Chamma , Chirag Chandrahas Shetty feel free to suggest any other solution which you guys think could work best for this situation.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Followup question:

            The toolbar tab contains a tooltip control icon that controls whether or not tooltips appear when users mouse over data items in the main IGB display. It has an "on" and "off" state. It looks like a word balloon from a comic book.

            Also, the View menu contains a checkbox menu item that also controls whether or not tooltips appear when users mouse over data items in the main display. It also has an "on" and "off" state. It contains a smaller version of the same word balloon icon as above.

            If the user clicks the tooltip control icon in the toolbar, the corresponding checkbox menu item in the View menu updates to show the same state, and vice versa.

            How does IGB keep these two widgets synchronized to ensure the reflect the current correct state of the application?

            attn: Prutha Kulkarni

            Show
            ann.loraine Ann Loraine added a comment - - edited Followup question: The toolbar tab contains a tooltip control icon that controls whether or not tooltips appear when users mouse over data items in the main IGB display. It has an "on" and "off" state. It looks like a word balloon from a comic book. Also, the View menu contains a checkbox menu item that also controls whether or not tooltips appear when users mouse over data items in the main display. It also has an "on" and "off" state. It contains a smaller version of the same word balloon icon as above. If the user clicks the tooltip control icon in the toolbar, the corresponding checkbox menu item in the View menu updates to show the same state, and vice versa. How does IGB keep these two widgets synchronized to ensure the reflect the current correct state of the application? attn: Prutha Kulkarni
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment - - edited

            Dr. [~aloraine], I investigated the code for "Show Data Tooltip" and here is what I found:

            • Implementation class for this menu item is "ToggleToolTipAction".
            • When we create IGB menu and the menu item is initialized, we have two icon options. on is 16x16 and the other one is 22x22.
            • When we are using Toolbar tab in the preference panel to create a "Show Data Tooltip" speech bubble button on the toolbar, we are passing the same instance reference i.e. "ToggleToolTipAction" generic action reference to one of the IGBService function which is "addToolbarAction".
            • What this function does is, it calls "addToolbarAction" function from IGBToolbar.java class in order to render it on the toolbar.
            • This function creates a button with the help of 22x22 icon which we had provided at the time of IGB initialization and it adds an actionListener to it.
            • This actionListener is nothing but the same actionListener which is present inside the "ToggleToolTipAction" generic class.
            • Since, both things are referring the same function, the toggle function checks/unchecks the menu item along with changing the toolbar button as well.

            One thing which is not clear is, I couldn't find any image like this at the common directory in core or in codebase from which we can find the exact location of the function which toolbar is using to set the "Show Data Tooltip" sppech bubble to
            Please let me know if you have any ideas on where we could find it.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - - edited Dr. [~aloraine] , I investigated the code for "Show Data Tooltip" and here is what I found: Implementation class for this menu item is "ToggleToolTipAction". When we create IGB menu and the menu item is initialized, we have two icon options. on is 16x16 and the other one is 22x22. When we are using Toolbar tab in the preference panel to create a "Show Data Tooltip" speech bubble button on the toolbar, we are passing the same instance reference i.e. "ToggleToolTipAction" generic action reference to one of the IGBService function which is "addToolbarAction". What this function does is, it calls "addToolbarAction" function from IGBToolbar.java class in order to render it on the toolbar. This function creates a button with the help of 22x22 icon which we had provided at the time of IGB initialization and it adds an actionListener to it. This actionListener is nothing but the same actionListener which is present inside the "ToggleToolTipAction" generic class. Since, both things are referring the same function, the toggle function checks/unchecks the menu item along with changing the toolbar button as well. One thing which is not clear is, I couldn't find any image like this at the common directory in core or in codebase from which we can find the exact location of the function which toolbar is using to set the "Show Data Tooltip" sppech bubble to Please let me know if you have any ideas on where we could find it.
            prutha Prutha Kulkarni (Inactive) made changes -
            chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
            Attachment view_menu_windows.png [ 14790 ]
            Hide
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

            Added the code to shift the icons of checkboxes to the right side.
            Prutha KulkarniCan you please check alignment on Mac.
            Branch Link: https://bitbucket.org/chirag06/integrated-genome-browser/branch/IGBF-2462

            Show
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Added the code to shift the icons of checkboxes to the right side. Prutha Kulkarni Can you please check alignment on Mac. Branch Link: https://bitbucket.org/chirag06/integrated-genome-browser/branch/IGBF-2462
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Additional request:

            • Please move "Set AutoLoadThreshold to Current View" and "Clamp to View" to positions immediately after the second divider.

            attn: Chirag Chandrahas Shetty

            Show
            ann.loraine Ann Loraine added a comment - - edited Additional request: Please move "Set AutoLoadThreshold to Current View" and "Clamp to View" to positions immediately after the second divider. attn: Chirag Chandrahas Shetty
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment - - edited

            Chirag Chandrahas Shetty, I have installed the IGBF-2462 branch installer on my system and here is what view menu looks like:

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - - edited Chirag Chandrahas Shetty , I have installed the IGBF-2462 branch installer on my system and here is what view menu looks like:
            prutha Prutha Kulkarni (Inactive) made changes -
            Attachment screenshot-1.png [ 14791 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Chirag Chandrahas Shetty [ chirag24 ]
            chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
            Attachment view_menu_items_rearranged.png [ 14792 ]
            chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
            Attachment view_menu_items_rearranged.png [ 14793 ]
            chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
            Attachment view_menu_items_rearranged.png [ 14792 ]
            Hide
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

            [~aloraine] Rearranged the view menu items.

            Show
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - [~aloraine] Rearranged the view menu items.
            ann.loraine Ann Loraine made changes -
            Sprint Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 29 Jul - 12 Aug [ 98, 99, 100 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment -

            Please submit PR.

            Show
            ann.loraine Ann Loraine added a comment - Please submit PR.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                chirag24 Chirag Chandrahas Shetty (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: