Details
-
Type: Bug
-
Status: Closed (View Workflow)
-
Priority: Blocker
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Sprint:Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug
Description
In the usability review done by Logan Weidenhammer, she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.
Note that this is a serious issue because it prevents Windows users from viewing the View menu items.
When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others.
Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine?
If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments. Note: What you learn will be used by whomever works on the fix.
Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one.
Attachments
Issue Links
- blocks
-
IGBF-2465 Fix checkmarks for View menu in Windows
- Closed
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link | IGBF-1765 [ 17855 ] |
Rank | Ranked higher |
Rank | Ranked higher |
Assignee | Ann Loraine [ aloraine ] |
Description |
In the usability review done by [~rweidenh], she noticed that the IGB View menu contains many items which appear as blue squares when selected.
Please investigate: Is this a problem with other Windows systems, or was it somehow unique to her machine? Please see attached images from Rachel's Windows machine and a Mac computer. The items in the *View* menu are on/off selections and anything that is selected should display the usual icon but with a checkmark next to it. Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items. |
In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.
Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items. When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others. Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine? Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one. |
Attachment | ViewMenuOnMac.png [ 14771 ] |
Attachment | ViewMenuOnWindows.png [ 14772 ] |
Story Points | 2 | 0.5 |
Description |
In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.
Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items. When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others. Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine? Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one. |
In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.
Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items. When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others. Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine? If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments and create a new Jira ticket to fix the problem. Please add it to the *current sprint* and link that issue to this one. Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one. |
Description |
In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.
Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items. When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others. Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine? If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments and create a new Jira ticket to fix the problem. Please add it to the *current sprint* and link that issue to this one. Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one. |
In the usability review done by [~rweidenh], she noticed that on her windows machine, the IGB View menu contains many items which appear as blue squares when selected.
Note that this is a serious issue because it prevents Windows users from viewing the *View* menu items. When we checked this on Mac, we noticed that several menu items lacked image icons altogether, including "Show Collapse Option", "Show IGB Track Mark", "Show Filter Mark", "Show Edge Matching", "Show Filter Mark" and others. Please investigate: Is this a problem with other Windows system or was it somehow unique to her machine? If other Windows show the same defect, create a Jira issue to fix the problem. Please describe what you learn in the Comments. Note: What you learn will be used by whomever works on the fix. Also, are there images associated with the above mentioned View menu functions? If yes, please make a note of this in the Comments and create new Jira ticket to investigate why these are not being shown on Mac. Please add it to the next (not current) sprint and link that issue to this one. |
Rank | Ranked higher |
Summary | Investigate: Fix checkmarks in View menu for windows | Investigate: Fix checkmarks in View menu on Windows |
Assignee | Prutha Kulkarni [ prutha ] |
Assignee | Prutha Kulkarni [ prutha ] |
Rank | Ranked higher |
Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Attachment | Checkbox.png [ 14775 ] |
Story Points | 0.5 | 4 |
Attachment | Screen Shot 2020-07-09 at 6.29.58 PM.png [ 14776 ] |
Comment | [ UI after changing settings on mac ] |
Attachment | Checkboxes visible after making changes on Windows.png [ 14777 ] |
Attachment | Screen Shot 2020-07-09 at 6.29.58 PM.png [ 14776 ] |
Attachment | Screenshot after changing menuitem settings on mac.png [ 14778 ] |
Status | In Progress [ 3 ] | To-Do [ 10305 ] |
Sprint | Summer 3: 6 Jul - 17 Jul [ 98 ] | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] |
Rank | Ranked higher |
Attachment | Screen Shot 2020-07-29 at 4.36.48 PM.png [ 14789 ] |
Attachment | view_menu_windows.png [ 14790 ] |
Attachment | screenshot-1.png [ 14791 ] |
Assignee | Shamika Gajanan Kulkarni [ shamika ] | Chirag Chandrahas Shetty [ chirag24 ] |
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Attachment | view_menu_items_rearranged.png [ 14792 ] |
Attachment | view_menu_items_rearranged.png [ 14793 ] |
Attachment | view_menu_items_rearranged.png [ 14792 ] |
Sprint | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 29 Jul - 12 Aug [ 98, 99, 100 ] |
Rank | Ranked higher |
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Resolution | Done [ 10000 ] | |
Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Me and Prutha Kulkarni were working on this today to check the issue on both Mac and Windows. We made the following observations:
1] The icons for menu items which are not displayed have an icon path pointing to the "blank_placeholder.png". If a proper image icon is passed, the icons are displayed properly.
2] The problem with the blue background is, it is a placeholder for checkbox which is not visible on Windows. The background is transparent when the checkbox is not checked [the menu item is not selected], and it turns blue on checking the checkbox. Initially all the check-boxes are checked, because of which it is displayed as blue. And for some reason the checkbox and icons are overlapping on Windows.
3] We were trying to understand the implementation of check-boxes by comparing JCheckBoxMenuItem and JRPCheckBoxMenuItem. JCheckBoxMenuItem is a compiled class whereas JRPCheckBoxMenuItem is a part of igb-swing-implementation and extends JCheckBoxMenuItem. We are thinking if there is any way to get a reference of the menu-item container so that we can set the positions of icons and check-boxes separately. So we will have to dig deeper for this part.
cc. Prof. [~aloraine]