Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2465

Fix checkmarks for View menu in Windows

    Details

    • Story Points:
      2.5
    • Sprint:
      Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug

      Attachments

        Issue Links

          Activity

          ann.loraine Ann Loraine created issue -
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Epic Link IGBF-1765 [ 17855 ]
          ann.loraine Ann Loraine made changes -
          Link This issue is blocked by IGBF-2462 [ IGBF-2462 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Summer 3: 6 Jul - 17 Jul [ 98 ] Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          Hide
          gchamma Jay Chamma (Inactive) added a comment - - edited

          I changed the position of the View menu to be in between Bookmarks and Help menus.

          This is how it looks:

          It no longer covers up the filter symbol or the "collapse option" button.

          To achieve this, the method called initializeParentMenuEntries() in MenuBarManager.java was changed from:

          parentMenuEntries.put(0, fileMenu);
          parentMenuEntries.put(1, editMenu);
          parentMenuEntries.put(5, viewMenu);
          parentMenuEntries.put(10, toolsMenu);
          parentMenuEntries.put(100, helpMenu);

          to

          parentMenuEntries.put(0, fileMenu);
          parentMenuEntries.put(1, editMenu);
          parentMenuEntries.put(5, toolsMenu);
          parentMenuEntries.put(20, viewMenu);
          parentMenuEntries.put(100, helpMenu);

          After implementing it, I realized that the menu can still cover the "collapse option" button if the user stretches the label window of the track to the right, so it's right under the menu.
          The filter mark however is always present on the far left of the track label window, so it does not get affected when the user stretches the track label window to the right.

          In addition, I have seen Chirag's changes of moving the icons of the button to the right of the text and enabling the check mark to be visible, and his changes can be applied over my current changes of moving the View menu's position to make the user experience much better.

          Show
          gchamma Jay Chamma (Inactive) added a comment - - edited I changed the position of the View menu to be in between Bookmarks and Help menus. This is how it looks: It no longer covers up the filter symbol or the "collapse option" button. To achieve this, the method called initializeParentMenuEntries() in MenuBarManager.java was changed from: parentMenuEntries.put(0, fileMenu); parentMenuEntries.put(1, editMenu); parentMenuEntries.put(5, viewMenu); parentMenuEntries.put(10, toolsMenu); parentMenuEntries.put(100, helpMenu); to parentMenuEntries.put(0, fileMenu); parentMenuEntries.put(1, editMenu); parentMenuEntries.put(5, toolsMenu); parentMenuEntries.put(20, viewMenu); parentMenuEntries.put(100, helpMenu); After implementing it, I realized that the menu can still cover the "collapse option" button if the user stretches the label window of the track to the right, so it's right under the menu. The filter mark however is always present on the far left of the track label window, so it does not get affected when the user stretches the track label window to the right. In addition, I have seen Chirag's changes of moving the icons of the button to the right of the text and enabling the check mark to be visible, and his changes can be applied over my current changes of moving the View menu's position to make the user experience much better.
          ann.loraine Ann Loraine made changes -
          Sprint Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 29 Jul - 12 Aug [ 98, 99, 100 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          Hide
          gchamma Jay Chamma (Inactive) added a comment -

          Please see the following commit for changing the View menu position:
          https://bitbucket.org/Gchamma/integrated-genome-browser/commits/2393ea815983dddb015aa01f8a9e05785d62e6c5

          Show
          gchamma Jay Chamma (Inactive) added a comment - Please see the following commit for changing the View menu position: https://bitbucket.org/Gchamma/integrated-genome-browser/commits/2393ea815983dddb015aa01f8a9e05785d62e6c5
          gchamma Jay Chamma (Inactive) made changes -
          Assignee Jay Chamma [ gchamma ]
          gchamma Jay Chamma (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          gchamma Jay Chamma (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          gchamma Jay Chamma (Inactive) made changes -
          Assignee Jay Chamma [ gchamma ] Chirag Chandrahas Shetty [ chirag24 ]
          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Branch: https://bitbucket.org/chirag06/integrated-genome-browser/src/IGBF-2465/
          Hide
          ann.loraine Ann Loraine added a comment -

          Please submit PR.

          Show
          ann.loraine Ann Loraine added a comment - Please submit PR.
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          Show
          gchamma Jay Chamma (Inactive) added a comment - Pull request submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/815/change-view-menu-position-to-be-after/diff
          Hide
          ann.loraine Ann Loraine added a comment -

          I merged this before I noticed a problem with the commit message: It needs to contain the Jira ticket number to ensure that we can easily find the ticket from the ticket commit message. It is too late to fix this now because I've already merged it. Please make note Jay Chamma to include the Jira ticket number in future commit messages.

          Show
          ann.loraine Ann Loraine added a comment - I merged this before I noticed a problem with the commit message: It needs to contain the Jira ticket number to ensure that we can easily find the ticket from the ticket commit message. It is too late to fix this now because I've already merged it. Please make note Jay Chamma to include the Jira ticket number in future commit messages.
          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - pull request submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/816
          Hide
          gchamma Jay Chamma (Inactive) added a comment - - edited

          [~aloraine] My mistake. I will make sure to include the ticket number for future pull requests.

          Show
          gchamma Jay Chamma (Inactive) added a comment - - edited [~aloraine] My mistake. I will make sure to include the ticket number for future pull requests.
          Hide
          ann.loraine Ann Loraine added a comment -

          Both branches are now merged. Master branch installers are building.

          Show
          ann.loraine Ann Loraine added a comment - Both branches are now merged. Master branch installers are building.
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Assignee Chirag Chandrahas Shetty [ chirag24 ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          Hide
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

          Tested this ticket. The position of the View menu is now between Bookmarks and Help menus. The checkmarks are now visible and the icons are shifted to right. Also, there exists a horizontal line separator between MenuItems 'Show All Visual Tools' and 'Show Zoom Stripe' and also between 'Show Full File Path in Track' and 'Set AutoLoad Threshold to Current View'.

          Show
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested this ticket. The position of the View menu is now between Bookmarks and Help menus. The checkmarks are now visible and the icons are shifted to right. Also, there exists a horizontal line separator between MenuItems 'Show All Visual Tools' and 'Show Zoom Stripe' and also between 'Show Full File Path in Track' and 'Set AutoLoad Threshold to Current View'.
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          For the next steps, Logan Weidenhammer - could you run the new master branch installers (from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/) and comment on the change in usability?

          If at all possible, please do this today (Wed).

          Show
          ann.loraine Ann Loraine added a comment - - edited For the next steps, Logan Weidenhammer - could you run the new master branch installers (from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/ ) and comment on the change in usability? If at all possible, please do this today (Wed).
          ann.loraine Ann Loraine made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ] Rachel Weidenhammer [ rweidenh ]
          ann.loraine Ann Loraine made changes -
          Status Post-merge Testing In Progress [ 10003 ] Merged Needs Testing [ 10002 ]
          Hide
          rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

          I have run IGB off of the newest master branch installers from earlier today. It appears that this version, versus the one we were testing off of previously from last week, has a new issue where clicking on "Show all visual tools" or "Hide Visual Tools" is not switching the state of "Show Data Tooltip" and "Show Full File Path In Track" submenu options. Chirag has been able to reproduce this on his machine as well.

          All of Shamika's findings from her previous comment are still accurate: New location of view menu, checkmarks are visible, horizontal separator is present.

          Otherwise the usability is improved. Some items relevant to the functionality affected by the options within the View menu are now visible. The separators also help with understanding how each option differs in it's type of functionality (e.g. on or off). The checkmarks are now present, creating a common look across the options and reducing confusion.

          Going forward, I think we should investigate what has caused the change in function of the "Show All Visual Tools" and "Hide Visual Tools" options in the View menu between this week's installers and last week's installers.

          Moving back to To-Do and requesting investigation into this issue.

          Show
          rweidenh Logan Weidenhammer (Inactive) added a comment - - edited I have run IGB off of the newest master branch installers from earlier today. It appears that this version, versus the one we were testing off of previously from last week, has a new issue where clicking on "Show all visual tools" or "Hide Visual Tools" is not switching the state of "Show Data Tooltip" and "Show Full File Path In Track" submenu options. Chirag has been able to reproduce this on his machine as well. All of Shamika's findings from her previous comment are still accurate: New location of view menu, checkmarks are visible, horizontal separator is present. Otherwise the usability is improved. Some items relevant to the functionality affected by the options within the View menu are now visible. The separators also help with understanding how each option differs in it's type of functionality (e.g. on or off). The checkmarks are now present, creating a common look across the options and reducing confusion. Going forward, I think we should investigate what has caused the change in function of the "Show All Visual Tools" and "Hide Visual Tools" options in the View menu between this week's installers and last week's installers. Moving back to To-Do and requesting investigation into this issue.
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Link This issue relates to IGBF-2506 [ IGBF-2506 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Assignee Rachel Weidenhammer [ rweidenh ] Chirag Chandrahas Shetty [ chirag24 ]
          Hide
          rweidenh Logan Weidenhammer (Inactive) added a comment -

          Chirag Chandrahas Shetty,
          Per Dr. Freese, since the options in question do not act on the main canvas in IGB, they do not need to be toggled by the "Show all visual tools" or "Hide Visual Tools" options.

          The "Show Data Tooltip" and "Show Full File Path In Track" options should be moved to below the dividing line within the View menu.

          Show
          rweidenh Logan Weidenhammer (Inactive) added a comment - Chirag Chandrahas Shetty , Per Dr. Freese, since the options in question do not act on the main canvas in IGB, they do not need to be toggled by the "Show all visual tools" or "Hide Visual Tools" options. The "Show Data Tooltip" and "Show Full File Path In Track" options should be moved to below the dividing line within the View menu.
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Assignee Chirag Chandrahas Shetty [ chirag24 ]
          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Branch: https://bitbucket.org/chirag06/integrated-genome-browser/branch/IGBF-2465
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Assignee Rachel Weidenhammer [ rweidenh ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Sprint Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug [ 98, 99, 100 ] Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug [ 98, 99, 100, 101 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Post-merge Testing In Progress [ 10003 ] Merged Needs Testing [ 10002 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Closed [ 6 ] To-Do [ 10305 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          Hide
          rweidenh Logan Weidenhammer (Inactive) added a comment -

          Tested on Windows

          View menu is in the correct position between “Bookmarks” and “Help”.
          Submenu items are divided by separator lines.
          Check marks are present.
          All items affected by “Show All Visual Tools” and “Hide Visual Tools” are grouped together.
          “Show data tooltip” and “Show Full File Path In Track” are moved to the grouping below.
          Code changes appear appropriate.

          Ready for Pull Request

          Show
          rweidenh Logan Weidenhammer (Inactive) added a comment - Tested on Windows View menu is in the correct position between “Bookmarks” and “Help”. Submenu items are divided by separator lines. Check marks are present. All items affected by “Show All Visual Tools” and “Hide Visual Tools” are grouped together. “Show data tooltip” and “Show Full File Path In Track” are moved to the grouping below. Code changes appear appropriate. Ready for Pull Request
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          rweidenh Logan Weidenhammer (Inactive) made changes -
          Assignee Rachel Weidenhammer [ rweidenh ] Chirag Chandrahas Shetty [ chirag24 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Submitted Pull Request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/819
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Status Reviewing Pull Request [ 10303 ] Pull Request Submitted [ 10101 ]
          chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
          Assignee Chirag Chandrahas Shetty [ chirag24 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged and master branch installers are built. Ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - Merged and master branch installers are built. Ready for testing.
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Working as expected. Moving it to done.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Working as expected. Moving it to done.
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ] Chirag Chandrahas Shetty [ chirag24 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          nfreese Nowlan Freese made changes -
          Fix Version/s 9.1.6 Major Release [ 10604 ]
          ann.loraine Ann Loraine made changes -
          Link This issue relates to IGBF-2663 [ IGBF-2663 ]

            People

            • Assignee:
              chirag24 Chirag Chandrahas Shetty (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: