Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:0.25
-
Epic Link:
-
Sprint:Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep
Description
.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1531 [ 17617 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
I think there shouldn't be a problem if we change all the "bioviz.org" links that pare present in all the IGB modules to "https".
Currently when I searched "bioviz.org" link all over IGB codebase, I found that of all the links which are pointing to "bioviz.org", there are some links which has "https". Whereas, a few of them still have "http". In order to address the issues that might occur in future, even if we point the site to "http" again, we will have to make a few uniform changes in IGB codebase to make each link consistent or we could just change all the links in IGB codebase to "https" instead of changing the bioviz server back to "http".
cc: [~aloraine]
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Sprint | Summer 5: 3 Aug - 14 Aug [ 100 ] | Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug [ 100, 101 ] |
| Rank | Ranked higher |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Ann Loraine [ aloraine ] |
I agree. If there are "http" links going to BioViz.org, let's change them to "https".
| Assignee | Ann Loraine [ aloraine ] | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Please find the code changes here:
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2494#diff
Moving the ticket to First Level Review.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
I have tested the branch, and the error is no longer being thrown with the new changes. Please submit a pull request at your convenience.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Sprint | Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug [ 100, 101 ] | Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 100, 101, 102 ] |
| Rank | Ranked higher |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged and built master branch installers. Ready for testing.
| Sprint | Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 100, 101, 102 ] | Summer 5: 3 Aug - 14 Aug, Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 100, 101, 102, 103 ] |
| Rank | Ranked higher |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Working as expected.
| Assignee | Noor Zahara [ noor91zahara ] | Shamika Gajanan Kulkarni [ shamika ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Moving forward, IGB code that accesses BioViz.org needs to use https instead of http as the protocol.
However, older version of IGB do not do this. So I am concerned that if we continue to redirect http to https on the Web server, we might end up blocking the ability of old versions of IGB to access the Web site.
So I wonder: should I modify the bioviz site to stop redirecting client requests to https?
attn: Philip Badzuh and Prutha Kulkarni
Relevant code is in:
Code is:
- name: httpd.conf become: yes blockinfile: dest: /etc/httpd/conf/httpd.conf insertafter: EOF state: present block: | Alias "/public" "/var/www/genome-dashboard/public" Redirect /igb/news.html https://{{ server_name }}/news.html Redirect /igb/help.html https://{{ server_name }}/help.html <VirtualHost *:80> ServerName {{ server_name }} Redirect / https://{{ server_name }}/ </VirtualHost>