Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2506

Investigate: "Tabs" menu font continuity in IGB

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22, Winter 3 Jan 25 - Feb 5

      Description

      In review of the menus in IGBF-2465, Chirag and Rachel noticed that the "Tabs" menu label is of a different font (maybe smaller size and bolded) compared the other menu labels. It also appears that this label is affected by scaling differently than the others (see attached images).

      Investigate the cause of this difference and suggest a potential solution.

        Attachments

        1. IGB_Tabs_9.1.4.png
          IGB_Tabs_9.1.4.png
          18 kB
        2. IGB_Tabs_9.1.6.png
          IGB_Tabs_9.1.6.png
          18 kB
        3. image.png
          image.png
          32 kB
        4. TabsDifferent.png
          TabsDifferent.png
          16 kB

          Issue Links

            Activity

            Hide
            gchamma Jay Chamma (Inactive) added a comment - - edited

            The Tab menu has 6 anomalies compared to other menus

            1. It has a different font.
            2. The color of the font is different.
            3. When a mouse cursor hovers on the Tabs menu, it does not change the color of the background.
            4. When the Tabs menu is clicked on, the background of the label changes to dark blue compared to a lighter blue for other menus.
            5. When the Tabs menu is clicked on and then the cursor of the mouse is moved off of the menu label, the background color changes back to the normal transparent color (same color as when the menu is un-selected).
            6. If IGB is not the main active app, menus would go grey in color, except the Tabs menu.
              This can be seen by opening IGB and scaling it down in size so you can click on the desktop behind it. Once you click on the desktop, the menus should all go grey, however the Tabs menu does not conform to this behavior.

            The Tab menu was using a font called Dialog.bold with size 12 and color of (55,55,55) which is a dark grey color
            All the other menus are using a font called "Segoe UI" with size 12 and color (0, 0, 0) which is black.

            I was able to get the font names for each menu by using the following methods on the menu (JMenu object):
            getFont() to get the font name
            getFont().getSize() to get the size of the font
            getForeground() to get the color of the label

            I was able to make it so the Tabs menu matches the others by using the following in WindowServiceDefaultImpl.java:
            tabsMenu.setForeground(Color.BLACK);
            tabsMenu.setFont(new Font("Segoe UI", Font.PLAIN, 12));

            That fixed issues 1 and 2, but the remaining issues still persist. I tried fixing that 3,4,5 as well (which can be seen in my IGBF-2506 branch), but I wasn't successful.

            Please see my branch to see and test any (unfinished) changes I made:
            https://bitbucket.org/Gchamma/integrated-genome-browser/branch/IGBF-2506

            Moving this ticket back to "To Do".

            Show
            gchamma Jay Chamma (Inactive) added a comment - - edited The Tab menu has 6 anomalies compared to other menus It has a different font. The color of the font is different. When a mouse cursor hovers on the Tabs menu, it does not change the color of the background. When the Tabs menu is clicked on, the background of the label changes to dark blue compared to a lighter blue for other menus. When the Tabs menu is clicked on and then the cursor of the mouse is moved off of the menu label, the background color changes back to the normal transparent color (same color as when the menu is un-selected). If IGB is not the main active app, menus would go grey in color, except the Tabs menu. This can be seen by opening IGB and scaling it down in size so you can click on the desktop behind it. Once you click on the desktop, the menus should all go grey, however the Tabs menu does not conform to this behavior. The Tab menu was using a font called Dialog.bold with size 12 and color of (55,55,55) which is a dark grey color All the other menus are using a font called "Segoe UI" with size 12 and color (0, 0, 0) which is black. I was able to get the font names for each menu by using the following methods on the menu (JMenu object): getFont() to get the font name getFont().getSize() to get the size of the font getForeground() to get the color of the label I was able to make it so the Tabs menu matches the others by using the following in WindowServiceDefaultImpl.java: tabsMenu.setForeground(Color.BLACK); tabsMenu.setFont(new Font("Segoe UI", Font.PLAIN, 12)); That fixed issues 1 and 2, but the remaining issues still persist. I tried fixing that 3,4,5 as well (which can be seen in my IGBF-2506 branch), but I wasn't successful. Please see my branch to see and test any (unfinished) changes I made: https://bitbucket.org/Gchamma/integrated-genome-browser/branch/IGBF-2506 Moving this ticket back to "To Do".
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment - - edited

            This issue seem to occur just on windows platform. On mac it works fine.

            Observations -

            1. Default font on windows and mac are different. Maybe we could pre-set it so that it is uniform on all the platforms.
            2. Need to implement mouse action for tabs.

            Other things need to be investigated.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited This issue seem to occur just on windows platform. On mac it works fine. Observations - 1. Default font on windows and mac are different. Maybe we could pre-set it so that it is uniform on all the platforms. 2. Need to implement mouse action for tabs. Other things need to be investigated.
            Show
            ann.loraine Ann Loraine added a comment - Also see: https://wiki.transvar.org/display/igbman/Tabbed+panels
            Hide
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - - edited

            Since the other menus (File, Edit, Tools, View, Help) are added using MenuBarManager class, and Tabs menu is added using a different logic, to make the font uniform I tried implementing Tabs menu using MenuBarManager. However, this approach involves a lot of code changes which seemed complex and it needs more digging into to be sure if this approach is the right one.

            Show
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - - edited Since the other menus (File, Edit, Tools, View, Help) are added using MenuBarManager class, and Tabs menu is added using a different logic, to make the font uniform I tried implementing Tabs menu using MenuBarManager. However, this approach involves a lot of code changes which seemed complex and it needs more digging into to be sure if this approach is the right one.
            Show
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Code is not compiling. Link : https://bitbucket.org/chirag06/integrated-genome-browser/commits/677e41ab87156f97c08a8798fd0f0bf39b5642ec
            Hide
            ann.loraine Ann Loraine added a comment -

            For the next step, please submit a PR for Jay's branch. (Add his fork to your local clone as new remote, get his branch, then cherry-pick his single commit onto a new branch on your local. Push your new branch to your fork and submit a PR.)

            Show
            ann.loraine Ann Loraine added a comment - For the next step, please submit a PR for Jay's branch. (Add his fork to your local clone as new remote, get his branch, then cherry-pick his single commit onto a new branch on your local. Push your new branch to your fork and submit a PR.)
            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - - edited [~aloraine] Please review the pull request Link for the branch: https://bitbucket.org/supreeth27/integrated-genome-browser/branch/IGBF-2506#diff Link for pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/848/igbf-2506-tabs-menu-font-continuity-in-igb
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged.

            Show
            ann.loraine Ann Loraine added a comment - Merged.
            Hide
            ann.loraine Ann Loraine added a comment -

            Logan Weidenhammer - Please test this to check that the functionality described in the comments is implemented.

            Show
            ann.loraine Ann Loraine added a comment - Logan Weidenhammer - Please test this to check that the functionality described in the comments is implemented.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            [~aloraine], New screenshots are posted of the Tabs menu label in IGB 9.1.4 and 9.1.6.

            Functionally, it looks like the Tabs menu is a smaller font. My impression was that this implementation was the most economical option time wise due to the Tabs menu label being from a different class.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - [~aloraine] , New screenshots are posted of the Tabs menu label in IGB 9.1.4 and 9.1.6. Functionally, it looks like the Tabs menu is a smaller font. My impression was that this implementation was the most economical option time wise due to the Tabs menu label being from a different class.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Functions in points 4, 5, and 6 from Jay's first comment are still present in IGB 9.1.6.
            As confirmed by Chirag, the changes were not made for these points due to the high amount of code changes needed to implement the fixes.

            The Tabs menu works as intended. Moving to closed.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Functions in points 4, 5, and 6 from Jay's first comment are still present in IGB 9.1.6. As confirmed by Chirag, the changes were not made for these points due to the high amount of code changes needed to implement the fixes. The Tabs menu works as intended. Moving to closed.

              People

              • Assignee:
                rweidenh Logan Weidenhammer (Inactive)
                Reporter:
                rweidenh Logan Weidenhammer (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: