Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2508

Align "Dot' option in "Graph" tab

    Details

    • Story Points:
      0.25
    • Sprint:
      Summer 7: 31 Aug - 11 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23

      Description

      In the "Graph" tab, the option called "Dot' is misaligned compared to the other options available.
      This is a GUI element and can be updated in GraphPanel.java.

      Use the GUI Builder interface to make the change.

        Attachments

        1. After.JPG
          After.JPG
          141 kB
        2. After changes.JPG
          After changes.JPG
          137 kB
        3. Before.JPG
          Before.JPG
          140 kB
        4. DotChange-Graph-IGB.PNG
          DotChange-Graph-IGB.PNG
          331 kB
        5. DotOption.png
          DotOption.png
          1.21 MB
        6. FixAlignment.png
          FixAlignment.png
          41 kB
        7. graph-tab-ss.png
          graph-tab-ss.png
          42 kB
        8. IGB-9.1.4 Release.PNG
          IGB-9.1.4 Release.PNG
          337 kB
        9. Screenshot 2020-10-22 at 12.11.09.png
          Screenshot 2020-10-22 at 12.11.09.png
          544 kB

          Issue Links

            Activity

            gchamma Jay Chamma (Inactive) created issue -
            gchamma Jay Chamma (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-1765 [ 17855 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Description In the "Graph" tab, the option called "Dot' is misaligned compared to the other options available.
            This is a GUI element and can be updated in GraphPanel.java.
            !https://i.imgur.com/kaMSQDx.png!
            In the "Graph" tab, the option called "Dot' is misaligned compared to the other options available.
            This is a GUI element and can be updated in GraphPanel.java.

            Use the GUI Builder interface to make the change.

            !https://i.imgur.com/kaMSQDx.png!
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            The changes are present in the link below:
            https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2508#diff

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The changes are present in the link below: https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2508#diff
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            Looks good.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Looks good.
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 7: 31 Aug - 11 Sep [ 102 ] Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 102, 103 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - PR submitted. https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/827/igbf-2508-align-dot-option-in-graph-tab/diff
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Question for Shamika Gajanan Kulkarni:

            Were any of these changes made by direct manual editing of files?

            Show
            ann.loraine Ann Loraine added a comment - Question for Shamika Gajanan Kulkarni : Were any of these changes made by direct manual editing of files?
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Shamika Gajanan Kulkarni [ shamika ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Additional request:

            • Can you please remove the two merge commits from your branch? I think you can simply rebase the branch directly onto the latest master branch without these two merge commits.
            Show
            ann.loraine Ann Loraine added a comment - Additional request: Can you please remove the two merge commits from your branch? I think you can simply rebase the branch directly onto the latest master branch without these two merge commits.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            1) The changes were made by editing the GUI Builder Interface. The files got updated directly and not manually.
            2) The two merge commits have been removed from the branch and my pull request. Kindly review.

            cc: Prof. [~aloraine]

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - 1) The changes were made by editing the GUI Builder Interface. The files got updated directly and not manually. 2) The two merge commits have been removed from the branch and my pull request. Kindly review. cc: Prof. [~aloraine]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] Pull Request Submitted [ 10101 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Can you please attach before and after images showing IGB in its default window size with the graph tab open?
            To get back to the default window size, reset preferences to defaults.

            Show
            ann.loraine Ann Loraine added a comment - - edited Can you please attach before and after images showing IGB in its default window size with the graph tab open? To get back to the default window size, reset preferences to defaults.
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment After.JPG [ 14865 ]
            Attachment Before.JPG [ 14866 ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Prof. [~aloraine] I have attached the screenshots for before and after images of IGB in its default window size. Can you please check?

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Prof. [~aloraine] I have attached the screenshots for before and after images of IGB in its default window size. Can you please check?
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] Pull Request Submitted [ 10101 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Thank you - I see them!

            I have a change request:

            • Can you change the size of the "Options" section to match the original?
            Show
            ann.loraine Ann Loraine added a comment - Thank you - I see them! I have a change request: Can you change the size of the "Options" section to match the original?
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

            Sure Prof. [~aloraine]. Sorry I wasn't able to do it earlier since the options were losing alignment when I did it due to some reason.
            I have made the changes and attached a screenshot for the same. The options have moved a little near the margins (top and bottom), but if I try to shift them to their original places, the alignment is lost again.
            I have pushed my changes to the branch as a separate commit. Will that be okay? Or would you like me to squash the commits or completely remove the earlier one?

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited Sure Prof. [~aloraine] . Sorry I wasn't able to do it earlier since the options were losing alignment when I did it due to some reason. I have made the changes and attached a screenshot for the same. The options have moved a little near the margins (top and bottom), but if I try to shift them to their original places, the alignment is lost again. I have pushed my changes to the branch as a separate commit. Will that be okay? Or would you like me to squash the commits or completely remove the earlier one?
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Attachment After changes.JPG [ 14867 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] Pull Request Submitted [ 10101 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Ann Loraine [ aloraine ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            This does not seem possible to do. Closing for now.

            Show
            ann.loraine Ann Loraine added a comment - This does not seem possible to do. Closing for now.
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 102, 103 ] Summer 7: 31 Aug - 11 Sep [ 102 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2508#diff

            The changes are present here. Kindly review.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2508#diff The changes are present here. Kindly review.
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Needs 1st Level Review [ 10005 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Nowlan Freese - would you download Shamika's branch installer and review the work?

            Show
            ann.loraine Ann Loraine added a comment - Nowlan Freese - would you download Shamika's branch installer and review the work?
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            nfreese Nowlan Freese made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            nfreese Nowlan Freese made changes -
            Sprint Summer 7: 31 Aug - 11 Sep [ 102 ] Summer 7: 31 Aug - 11 Sep, Fall 2: 28 Sep - 9 Oct [ 102, 104 ]
            Hide
            nfreese Nowlan Freese added a comment -

            [~aloraine] - I'm not able to replicate the problem in release 9.1.4 or 9.1.6 Master (without Shamika's code) on Mac (the Graph tab Dot option appears correctly in all versions on Mac). Based on the attached images this may be a Windows issue. I have asked Chaitanya Kintali to take a look.

            Show
            nfreese Nowlan Freese added a comment - [~aloraine] - I'm not able to replicate the problem in release 9.1.4 or 9.1.6 Master (without Shamika's code) on Mac (the Graph tab Dot option appears correctly in all versions on Mac). Based on the attached images this may be a Windows issue. I have asked Chaitanya Kintali to take a look.
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ] Chaitanya Kintali [ chaitanya ]
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment - - edited

            I have downloaded and installed the IGBF-2508.exe installer from Shamika's repository. I have verified that the dot seems to be aligned with the above options. Please find the screenshot attached. DotChange-Graph-IGB.png

            I was able to replicate this issue in the 9.1.4 release version and can confirm that the dot was not previously aligned. Please check the screenshot attached. IGB-9.1.4 Release.png

            Moving this ticket to ready for a pull request.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - - edited I have downloaded and installed the IGBF-2508 .exe installer from Shamika's repository. I have verified that the dot seems to be aligned with the above options. Please find the screenshot attached. DotChange-Graph-IGB.png I was able to replicate this issue in the 9.1.4 release version and can confirm that the dot was not previously aligned. Please check the screenshot attached. IGB-9.1.4 Release.png Moving this ticket to ready for a pull request.
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Attachment IGB-9.1.4 Release.PNG [ 14882 ]
            Attachment DotChange-Graph-IGB.PNG [ 14883 ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Assignee Chaitanya Kintali [ chaitanya ]
            Hide
            ann.loraine Ann Loraine added a comment -

            No, it is not required. She has already submitted a PR.

            Show
            ann.loraine Ann Loraine added a comment - No, it is not required. She has already submitted a PR.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Merged. Master branch installers built and ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - - edited Merged. Master branch installers built and ready for testing.
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            nfreese Nowlan Freese made changes -
            Comment [ [~aloraine] do you want me to do a pull request for Shamika's branch? ]
            nfreese Nowlan Freese made changes -
            Assignee Chaitanya Kintali [ chaitanya ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -

            Downloaded the latest master installer. Verified the change, the alignment is now visible and proper. Moving this ticket to Done.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - Downloaded the latest master installer. Verified the change, the alignment is now visible and proper. Moving this ticket to Done.
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Assignee Chaitanya Kintali [ chaitanya ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Closed [ 6 ] To-Do [ 10305 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            On Mac, the alignment is wrong. The "Filled Bar" label overlaps the separator. See attached.

            Show
            ann.loraine Ann Loraine added a comment - On Mac, the alignment is wrong. The "Filled Bar" label overlaps the separator. See attached.
            ann.loraine Ann Loraine made changes -
            Attachment FixAlignment.png [ 14904 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 7: 31 Aug - 11 Sep, Fall 2: 28 Sep - 9 Oct [ 102, 104 ] Summer 7: 31 Aug - 11 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23 [ 102, 104, 106 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            noor91zahara Noor Zahara (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            Code diff - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2508-1#diff

            Note - Kindly test on both mac and windows.

            Chirag Chandrahas Shetty has tested on windows.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Code diff - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2508-1#diff Note - Kindly test on both mac and windows. Chirag Chandrahas Shetty has tested on windows.
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment - - edited

            I have tested it on my system. It's working in a Mac environment as well

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - - edited I have tested it on my system. It's working in a Mac environment as well
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Attachment DotOption.png [ 14908 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ] Noor Zahara [ noor91zahara ]
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - PR submitted - https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/836/igbf-2508-align-dot-option-in-graph-tab/diff
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged. Please test using master branch installers for windows and mac from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/

            Show
            ann.loraine Ann Loraine added a comment - Merged. Please test using master branch installers for windows and mac from https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/
            cdias1 Chester Dias (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            cdias1 Chester Dias (Inactive) made changes -
            Assignee Chester Dias [ cdias1 ]
            chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
            Attachment graph-tab-ss.png [ 14921 ]
            Hide
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

            Tested the master exe and looks fine on windows. Please find the image below for reference.

            Show
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Tested the master exe and looks fine on windows. Please find the image below for reference.
            Hide
            cdias1 Chester Dias (Inactive) added a comment -

            The dot radio button is aligned correctly on the mac. Screenshot attached

            Show
            cdias1 Chester Dias (Inactive) added a comment - The dot radio button is aligned correctly on the mac. Screenshot attached
            Hide
            cdias1 Chester Dias (Inactive) added a comment -

            Screenshot of Dot radio button aligned on mac

            Show
            cdias1 Chester Dias (Inactive) added a comment - Screenshot of Dot radio button aligned on mac
            cdias1 Chester Dias (Inactive) made changes -
            cdias1 Chester Dias (Inactive) made changes -
            Assignee Chester Dias [ cdias1 ] Noor Zahara [ noor91zahara ]
            cdias1 Chester Dias (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            nfreese Nowlan Freese made changes -
            Fix Version/s 9.1.6 Major Release [ 10604 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-2662 [ IGBF-2662 ]

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                gchamma Jay Chamma (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: