Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2560

Deploy and test new jar-signing certificate

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      IGB installer build process uses a DigiCert-validated certificate to sign jars used by the Windows installers.

      For this task, deploy the new certificate. Check that the build system works properly. Make sure that the installer can be run and IGB can start up as usual, with no scary warnings about IGB being "untrusted". Search Jira for past issues where this type of thing has occurred before.

      Note that this ticket is private. The location of the key and its file name are confidential.

      This needs to be done before releasing version 9.1.5 of IGB.

        Attachments

          Activity

          ann.loraine Ann Loraine created issue -
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Epic Link IGBF-1765 [ 17855 ]
          ann.loraine Ann Loraine made changes -
          Link This issue blocks IGBF-2554 [ IGBF-2554 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          [~aloraine] - Has the certificate been uploaded ?

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - [~aloraine] - Has the certificate been uploaded ?
          Hide
          ann.loraine Ann Loraine added a comment -

          We need a "pfx" file that combines the certificates from the signing authority (DigiCert) and the private key that was created when we made the CSR (certificate signing request) given to DigiCert.
          DigiCert gave me a "p7b" file that contains certificates but not the private key.
          According to this Web site (https://www.ibm.com/support/knowledgecenter/SSVP8U_9.7.0/com.ibm.drlive.doc/topics/r_extratsslcert.html) we can use openssl to get the private key from the existing pfx file we are using.
          Then, we can use openssl again to package the certificates from the p7b file together with the private key from the existing pfx file to make an all-new "pfx" file that can then be used to sign the jar files.
          What I would recommend doing is you make an IGB branch where the bitbucket pipelines file retrieves the newly created pfx file from somewhere. You can then test the build.
          If the pipeline runs and are you are able to get the installers to build, then get somebody with a windows machine to try to install IGB using the new installer. If it installs without any kind of warning about an "unknown developer" then the "pfx" file is probably OK.
          Search Jira for example errors messages that are shown when the code signing certificate being used is expired.

          Show
          ann.loraine Ann Loraine added a comment - We need a "pfx" file that combines the certificates from the signing authority (DigiCert) and the private key that was created when we made the CSR (certificate signing request) given to DigiCert. DigiCert gave me a "p7b" file that contains certificates but not the private key. According to this Web site ( https://www.ibm.com/support/knowledgecenter/SSVP8U_9.7.0/com.ibm.drlive.doc/topics/r_extratsslcert.html ) we can use openssl to get the private key from the existing pfx file we are using. Then, we can use openssl again to package the certificates from the p7b file together with the private key from the existing pfx file to make an all-new "pfx" file that can then be used to sign the jar files. What I would recommend doing is you make an IGB branch where the bitbucket pipelines file retrieves the newly created pfx file from somewhere. You can then test the build. If the pipeline runs and are you are able to get the installers to build, then get somebody with a windows machine to try to install IGB using the new installer. If it installs without any kind of warning about an "unknown developer" then the "pfx" file is probably OK. Search Jira for example errors messages that are shown when the code signing certificate being used is expired.
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Is there a private key that you have created when you requested for the certificate?

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Is there a private key that you have created when you requested for the certificate?
          Hide
          ann.loraine Ann Loraine added a comment -

          Recover the private key from the current pfx file using openssl as described in the previous comment.

          Show
          ann.loraine Ann Loraine added a comment - Recover the private key from the current pfx file using openssl as described in the previous comment.
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment - - edited

          I have created a pfx file from the p7b file uploaded. I uploaded the file in my local repository of IGB and created a branch to use that file for authentication.
          Tested on windows and works fine.

          Testing Steps -
          Install IGB - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/downloads/IGBF-2560.exe on windows machine and check if it installs with no errors

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - - edited I have created a pfx file from the p7b file uploaded. I uploaded the file in my local repository of IGB and created a branch to use that file for authentication. Tested on windows and works fine. Testing Steps - Install IGB - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/downloads/IGBF-2560.exe on windows machine and check if it installs with no errors
          noor91zahara Noor Zahara (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Question:

          • It sounds like you got hold of a windows machine and tested the installer. Is that right? Can a Windows user install IGB using the installer containing jars signed using the newly made "pfx" file?
          Show
          ann.loraine Ann Loraine added a comment - Question: It sounds like you got hold of a windows machine and tested the installer. Is that right? Can a Windows user install IGB using the installer containing jars signed using the newly made "pfx" file?
          Hide
          ann.loraine Ann Loraine added a comment -

          If the new pfx file is indeed able to sign the jar and a user can then install IGB, I will take care of the next step. What I'm planning to do is replace the existing version-controlled "pfx" file with the new one you have made. No changes to IGB repository will be needed.

          Show
          ann.loraine Ann Loraine added a comment - If the new pfx file is indeed able to sign the jar and a user can then install IGB, I will take care of the next step. What I'm planning to do is replace the existing version-controlled "pfx" file with the new one you have made. No changes to IGB repository will be needed.
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Assignee Noor Zahara [ noor91zahara ]
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Yes, I have tested it on a windows machine. I was able to successfully install IGB with no errors.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Yes, I have tested it on a windows machine. I was able to successfully install IGB with no errors.
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          I have renamed the new "pfx" file to "windows_keystore.pfx" and committed it to this branch:

          This effectively replaces the existing (soon-to-be-expired) key with the new one made by Noor Zahara.

          Noor Zahara - would you please ask a couple of the windows users tomorrow to try to install IGB using installer you created onto their systems?

          If that works out OK, then I will merge the branch into the master branch. This will be enough to deploy the new key - no changes to the IGB code base will be needed.

          Thank you!

          Show
          ann.loraine Ann Loraine added a comment - - edited I have renamed the new "pfx" file to "windows_keystore.pfx" and committed it to this branch: https://bitbucket.org/lorainelab/iipc/branch/IGBF-2560 This effectively replaces the existing (soon-to-be-expired) key with the new one made by Noor Zahara . Noor Zahara - would you please ask a couple of the windows users tomorrow to try to install IGB using installer you created onto their systems? If that works out OK, then I will merge the branch into the master branch. This will be enough to deploy the new key - no changes to the IGB code base will be needed. Thank you!
          ann.loraine Ann Loraine made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          ann.loraine Ann Loraine made changes -
          Assignee Noor Zahara [ noor91zahara ]
          Hide
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

          Installed IGB on a windows machine using IGBF-2560 installer and it is working as expected.

          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Installed IGB on a windows machine using IGBF-2560 installer and it is working as expected.
          Hide
          karthik Karthik Raveendran added a comment -

          Tested on windows machine. Installer ran without warnings. IGB opened as normal.

          Show
          karthik Karthik Raveendran added a comment - Tested on windows machine. Installer ran without warnings. IGB opened as normal.
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          [~aloraine] - Karthik and Chirag have installed IGB on windows machine with no errors related to the certificate.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - [~aloraine] - Karthik and Chirag have installed IGB on windows machine with no errors related to the certificate.
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged PR from branch on iipc to master branch on upstream and updated master on iipc. The new key is now being used to sign jars in IGB main project pipeline.

          To test, please confirm that the new master branch windows installers are working fine.

          Show
          ann.loraine Ann Loraine added a comment - Merged PR from branch on iipc to master branch on upstream and updated master on iipc. The new key is now being used to sign jars in IGB main project pipeline. To test, please confirm that the new master branch windows installers are working fine.
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Needs 1st Level Review [ 10005 ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          ann.loraine Ann Loraine made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          ann.loraine Ann Loraine made changes -
          Link This issue blocks IGBF-2554 [ IGBF-2554 ]
          ann.loraine Ann Loraine made changes -
          Link This issue relates to IGBF-3352 [ IGBF-3352 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: