Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 5 Nov 9 - Nov 20
Description
Task: Implement a right-click menu option to delete a file or folder. Include a confirmation check when deleting a file or folder.
Note: Deleting folders seems to be slow. Once user has clicked to confirm that they want to delete a folder lock the main window for 10 seconds (similar to cut/paste) before refreshing main window.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2376 [ 18533 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Description |
Task: Implement a right-click menu option to delete a file or folder. Include a confirmation check when deleting a file or folder.
Note: Deleting folders seems to be slow. Once user has clicked to confirm that they want to delete a folder lock the main window for 10 seconds (similar to cut/paste) before refreshing main window. |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Couple of changes:
1) Needs to have a confirmation box asking the user if they are sure they would like to delete the file/folder (similar to Google Drive). Needs to include the option to cancel.
2) It looks like the call to delete is submitted as soon as the user clicks Delete. Clicking "Ok, thanks" then causes a page refresh. Assuming changes to 1 above, when the user clicks to confirm delete, lock the page for 5 seconds before refreshing the page. Can put a spinning icon in the confirm button that spins for 5 seconds before refreshing the page. This would be similar to renaming a file/folder.
3) Change the wording regarding the folders to: "Folders may take several minutes to be deleted."
| Attachment | Screen Shot 2020-11-23 at 3.20.17 PM.png [ 14964 ] |
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Last change:
1) If the user clicks to delete file/folder and then clicks No in the confirmation box, need to ungray the file/folder.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Closing issue.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
The delete function was taking more than 10seconds in some cases so I added an alert box instead to let the user know about the delay.