Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2673

Add a Link to Homepage in the Navbar

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Currently there is no way of going back to homepage on the appstore apart from the link in the common nav bar.

      This might be inconvenient for the users as we are generally trained to think that logo or link in the header / navbar will take us to the defined spot.

      Find out a better position to add back to homepage link to add a logo to the left of `Apps for IGB` Header which would take us to the homepage

        Attachments

          Activity

          sameer Sameer Shanbhag (Inactive) created issue -
          sameer Sameer Shanbhag (Inactive) made changes -
          Field Original Value New Value
          Epic Link IGBF-2563 [ 18746 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Assignee Ann Loraine [ aloraine ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Assignee Sai Supreeth Segu [ ssegu ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment -

          I have added a Link to Homepage. Dr. [~aloraine], Please review my changes. I have added a screenshot for the homepage as well.
          Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2673#diff

          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - I have added a Link to Homepage. Dr. [~aloraine] , Please review my changes. I have added a screenshot for the homepage as well. Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2673#diff
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Attachment HomePage_Screenshot.png [ 14997 ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Assignee Sai Supreeth Segu [ ssegu ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Please remove the change to base.css and apply the necessary style tags in template/base.html to:

           <h1>
             <a class="header-hyperlink" href ="/">Apps for IGB</a>
          </h1>
          
          Show
          ann.loraine Ann Loraine added a comment - Please remove the change to base.css and apply the necessary style tags in template/base.html to: <h1> <a class= "header-hyperlink" href = "/" >Apps for IGB</a> </h1>
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ] Sai Supreeth Segu [ ssegu ]
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment - - edited

          Dr. [~aloraine], Please go through this discussion https://stackoverflow.com/questions/41644927/html-hyperlink-underline-on-mouseover/41645138. I have tried implementing the first comment in this link but it's not working as expected

          Developers are saying that:
          You can't do this without Css, if you want to try it's :
          a:hover

          { text-decoration: underline;}
          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - - edited Dr. [~aloraine] , Please go through this discussion https://stackoverflow.com/questions/41644927/html-hyperlink-underline-on-mouseover/41645138 . I have tried implementing the first comment in this link but it's not working as expected Developers are saying that: You can't do this without Css, if you want to try it's : a:hover { text-decoration: underline;}
          Hide
          ann.loraine Ann Loraine added a comment -

          Can you apply the required CSS using "in-line CSS"?

          Please see: https://www.w3schools.com/html/html_css.asp

          Show
          ann.loraine Ann Loraine added a comment - Can you apply the required CSS using "in-line CSS"? Please see: https://www.w3schools.com/html/html_css.asp
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment - - edited

          Hi Professor,

          I suggested him adding the css to the base.css file as we are attempting to change the behaviour of a hover element i.e. a:hover in our case, we can't and shouldn't do it in line as a and a:hover are two different properties which needs to get their value dynamically from css file. I think the implementation makes sense, please let me know if there is any specific requirement on why we need to do it inline.

          Alternative:

          • create a style tag in the header of base.html file to implement that class
          • Using JS Like follow:
          • <a href="/" onMouseOver="this.style.text-decoration='none'" onMouseOut="this.style.text-decoration='none'" >Apps for IGB</a>

          c.c. [~aloraine]

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - - edited Hi Professor, I suggested him adding the css to the base.css file as we are attempting to change the behaviour of a hover element i.e. a:hover in our case, we can't and shouldn't do it in line as a and a:hover are two different properties which needs to get their value dynamically from css file. I think the implementation makes sense, please let me know if there is any specific requirement on why we need to do it inline. Alternative: create a style tag in the header of base.html file to implement that class Using JS Like follow: <a href="/" onMouseOver="this.style.text-decoration='none'" onMouseOut="this.style.text-decoration='none'" >Apps for IGB</a> c.c. [~aloraine]
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          Sure, I understand! If you can keep it in base.html, I would prefer that. The reason is: the more classes and style configurations we add to base.css, the harder it becomes to maintain and modify. It's so much better to keep it lightweight and simple, and only include styles that are being used by multiple other files.

          Show
          ann.loraine Ann Loraine added a comment - - edited Sure, I understand! If you can keep it in base.html, I would prefer that. The reason is: the more classes and style configurations we add to base.css, the harder it becomes to maintain and modify. It's so much better to keep it lightweight and simple, and only include styles that are being used by multiple other files.
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Sure makes sense, we can use the Javascript method i just suggested, which does the same thing.

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Sure makes sense, we can use the Javascript method i just suggested, which does the same thing.
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment -

          Dr. [~aloraine], if we use the method suggested by Sameer Shanbhag, I am unable to set the color of the text to black on hover.
          Sameer Shanbhag, Please let me know if there is any way for setting the color as well

          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] , if we use the method suggested by Sameer Shanbhag , I am unable to set the color of the text to black on hover. Sameer Shanbhag , Please let me know if there is any way for setting the color as well
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          <a href="/" style="color:black" onMouseOver="this.style.textDecoration='none'" onMouseOut="this.style.textDecoration='none'">Apps for IGB</a>

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - <a href="/" style="color:black" onMouseOver="this.style.textDecoration='none'" onMouseOut="this.style.textDecoration='none'">Apps for IGB</a>
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment -

          Made changes as suggested by Dr. [~aloraine] and Sameer Shanbhag. Please review my code changes.
          Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2673#diff

          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - Made changes as suggested by Dr. [~aloraine] and Sameer Shanbhag . Please review my code changes. Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2673#diff
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Assignee Sai Supreeth Segu [ ssegu ]
          ann.loraine Ann Loraine made changes -
          Sprint Fall 6 Nov 30 - Dec 11 [ 109 ] Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23 [ 109, 110 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Assignee Sai Supreeth Segu [ ssegu ]
          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/231/igbf-2673-adding-link-to-home-page
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Assignee Sai Supreeth Segu [ ssegu ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged and new code on master branch deployed to testing site https://devappstore5.bioviz.org.
          Sai Supreeth Segu - kindly confirm the change is shown on testing site. If yes, please move to "Closed".

          Show
          ann.loraine Ann Loraine added a comment - Merged and new code on master branch deployed to testing site https://devappstore5.bioviz.org . Sai Supreeth Segu - kindly confirm the change is shown on testing site. If yes, please move to "Closed".
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Changes Look good!

          Thanks Sai Supreeth Segu

          Moving to Closed.

          c.c. [~aloraine]

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Changes Look good! Thanks Sai Supreeth Segu Moving to Closed. c.c. [~aloraine]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Post-merge Testing In Progress [ 10003 ] Merged Needs Testing [ 10002 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          sameer Sameer Shanbhag (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Assignee Sai Supreeth Segu [ ssegu ]

            People

            • Assignee:
              ssegu Sai Supreeth Segu (Inactive)
              Reporter:
              sameer Sameer Shanbhag (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: