Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22, Winter 3 Jan 25 - Feb 5

      Description

      If a user visits App Store using the Safari Web browser and then attempts to install an App, nothing happens.

      Safari does not allow javascript code that was loaded via https to connect to other web sites via http unless a new window is opened. In this case, the "other web site" is IGB itself running on the localhost.

      For this task, determine if users can install apps into IGB using app store and safari.

      If this cannot be done, then implement some kind of warning or failsafe to alert the user to the fact that they cannot use the Safari browser to install an App from App Store.

      Before beginning work, please review the linked issue for detailed descriptions of the problem.

      Also, consult with Karthik Raveendran on how BioViz Connect has handled this issue from both a technical and user interface perspective.

        Attachments

          Issue Links

            Activity

            Hide
            ann.loraine Ann Loraine added a comment -

            Confirmed: Safari cannot communicate with IGB's local REST endpoint. So we need to implement some kind of warning or alert to let Safari users know that they cannot install or upgrade Apps using the App Store interface. They should use a different browser or instead use the internal App Manager interface within IGB itself.

            Show
            ann.loraine Ann Loraine added a comment - Confirmed: Safari cannot communicate with IGB's local REST endpoint. So we need to implement some kind of warning or alert to let Safari users know that they cannot install or upgrade Apps using the App Store interface. They should use a different browser or instead use the internal App Manager interface within IGB itself.
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment - - edited

            I just went through some articles regarding mixed content (https and http) for safari, apple blocked it so that there won't be any kind of malicious activity like injection or spoofing. 

            Suggestion:

            • Detect the browser as safari
            • Host a endpoint on Appstore or Genome Browser which would contact the localhost to check for the endpoint
            • Use the https endpoint hosted by appstore or genome dashboard
            • Technically it would be a https - https connection ( Not sure if it will work though )

            c.c. Nowlan Freese [~aloraine] Karthik Raveendran Philip Badzuh

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - - edited I just went through some articles regarding mixed content (https and http) for safari, apple blocked it so that there won't be any kind of malicious activity like injection or spoofing.  Suggestion: Detect the browser as safari Host a endpoint on Appstore or Genome Browser which would contact the localhost to check for the endpoint Use the https endpoint hosted by appstore or genome dashboard Technically it would be a https - https connection ( Not sure if it will work though ) c.c. Nowlan Freese [~aloraine] Karthik Raveendran Philip Badzuh
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Created a popup for users accessing App Store in Safari browser.
            Dr. [~aloraine] and Sameer Shanbhag, Please review my changes.
            Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Created a popup for users accessing App Store in Safari browser. Dr. [~aloraine] and Sameer Shanbhag , Please review my changes. Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674#diff
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Dr. [~aloraine], Please let me know the error message that need to be displayed when user is using Appstore in Safari?

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] , Please let me know the error message that need to be displayed when user is using Appstore in Safari?
            Hide
            ann.loraine Ann Loraine added a comment -

            Deploying the branch onto https://devappstore3.bioviz.org for testing prior to PR using playbook settings:

            branch: IGBF-2674
            appstore_repo: https://bitbucket.org/supreeth27/appstore.git
            

            attn: Sai Supreeth Segu, Chirag Chandrahas Shetty, Sameer Shanbhag

            Please test Safari, Chrome, Firefox to ensure that

            • When visiting with Safari, it is clear that the user cannot use app store to install or update an app into IGB
            • When visiting with Chrome or Firefox, the user can continue to use app store to install an app into IGB
            Show
            ann.loraine Ann Loraine added a comment - Deploying the branch onto https://devappstore3.bioviz.org for testing prior to PR using playbook settings: branch: IGBF-2674 appstore_repo: https: //bitbucket.org/supreeth27/appstore.git attn: Sai Supreeth Segu , Chirag Chandrahas Shetty , Sameer Shanbhag Please test Safari, Chrome, Firefox to ensure that When visiting with Safari, it is clear that the user cannot use app store to install or update an app into IGB When visiting with Chrome or Firefox, the user can continue to use app store to install an app into IGB
            Hide
            ann.loraine Ann Loraine added a comment -

            Please see comment and commence testing of your branch IGBF-2674 deployed on https://devappstore3.bioviz.org

            Show
            ann.loraine Ann Loraine added a comment - Please see comment and commence testing of your branch IGBF-2674 deployed on https://devappstore3.bioviz.org
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Dr. [~aloraine] I haven't disabled the install an app button. I have made changes for that pushed them on my branch.
            Please review my changes.
            Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] I haven't disabled the install an app button. I have made changes for that pushed them on my branch. Please review my changes. Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674#diff
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Thank you for the update!

            I have a git-related request:

            • Can you modify your branch (or make a new branch altogether if you prefer) so that the branched-off-from commit is actually the current tip of the master branch and also there is only one commit in the branch?
            Show
            ann.loraine Ann Loraine added a comment - - edited Thank you for the update! I have a git-related request: Can you modify your branch (or make a new branch altogether if you prefer) so that the branched-off-from commit is actually the current tip of the master branch and also there is only one commit in the branch?
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Dr. [~aloraine], There are 2 commits in IGBF-2674 branch and it's currently on top of the master branch. However, I have created a new branch IGBF-2674-1 by squashing the 2 commits to 1 commit. Both the branches are on top of the master branch.
            Link for the new branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674-1#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] , There are 2 commits in IGBF-2674 branch and it's currently on top of the master branch. However, I have created a new branch IGBF-2674 -1 by squashing the 2 commits to 1 commit. Both the branches are on top of the master branch. Link for the new branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674-1#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Sorry, it looks like the new branch maybe is not actually branching off of the latest commit to the master branch?

            Please take a look at the following workflow. I think it will work.

            # stash anything you are working on so you can apply those changes later if you want
            git stash 
            # switch over the master (main) branch
            git checkout master 
            # get all the changes from the team repo
            # you may need to use "git add remote" command to connect "upstream" to the address of the team repo
            git pull upstream master
            # now make your new branch
            git checkout -b new-branch-name
            # make a copy of the commit you already made and add it to the new branch; it will receive a totally
            # new git hash, btw
            git cherrypick git-hash-for-the-single-commit-you-want-to-apply
            # commit your work
            git commit -m "a nice message"
            # now push the new branch to your fork, aliased by default to the word "origin"
            git push origin new-branch-name
            
            Show
            ann.loraine Ann Loraine added a comment - Sorry, it looks like the new branch maybe is not actually branching off of the latest commit to the master branch? Please take a look at the following workflow. I think it will work. # stash anything you are working on so you can apply those changes later if you want git stash # switch over the master (main) branch git checkout master # get all the changes from the team repo # you may need to use "git add remote" command to connect "upstream" to the address of the team repo git pull upstream master # now make your new branch git checkout -b new -branch-name # make a copy of the commit you already made and add it to the new branch; it will receive a totally # new git hash, btw git cherrypick git-hash- for -the-single-commit-you-want-to-apply # commit your work git commit -m "a nice message" # now push the new branch to your fork, aliased by default to the word "origin" git push origin new -branch-name
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            I have updated my master branch and rebased my current branch onto master branch.
            Link for the new branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674-1#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - I have updated my master branch and rebased my current branch onto master branch. Link for the new branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2674-1#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Apologies – the tip of the master branch is now an entirely new commit - https://bitbucket.org/lorainelab/appstore/commits/92f7ac6b699cfe5b54618bce40f4b2e6d5c36897.

            This will probably stay the tip for another hour. Would you be able to make a new branch off this commit now?

            Show
            ann.loraine Ann Loraine added a comment - Apologies – the tip of the master branch is now an entirely new commit - https://bitbucket.org/lorainelab/appstore/commits/92f7ac6b699cfe5b54618bce40f4b2e6d5c36897 . This will probably stay the tip for another hour. Would you be able to make a new branch off this commit now?
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Merged into master branch and deployed to https://devappstore5.bioviz.org for testing.

            Show
            ann.loraine Ann Loraine added a comment - - edited Merged into master branch and deployed to https://devappstore5.bioviz.org for testing.
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            I have already rebased my branch with Chirag's commit(IGBF-2709) and created a branch.
            To make sure I have created a pull request as well and bitbucket is not showing any message saying that the branch is behind some commits. In general if the branch submitted for PR is behind the master, BitBucket will show the message.

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - I have already rebased my branch with Chirag's commit( IGBF-2709 ) and created a branch. To make sure I have created a pull request as well and bitbucket is not showing any message saying that the branch is behind some commits. In general if the branch submitted for PR is behind the master, BitBucket will show the message.
            Hide
            ann.loraine Ann Loraine added a comment -

            Philip Badzuh - could you review and test the workflow?

            Show
            ann.loraine Ann Loraine added a comment - Philip Badzuh - could you review and test the workflow?
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment - - edited

            When testing, I noticed that appstore styling does not render properly in safari. See the screenshot here. Please confirm. Assigning to Sai Supreeth Segu and moving back to to-do.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - - edited When testing, I noticed that appstore styling does not render properly in safari. See the screenshot here . Please confirm. Assigning to Sai Supreeth Segu and moving back to to-do.
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            This may be an ansible/menu bar issue. I also noticed that the bioviz connect page doesn't load the menu bar properly in safari. See a screenshot . This is what the menu bar looks like on load, there is an error in the console:

            [Error] Failed to load resource: the server responded with a status of 404 (Not Found) (lightbox.min.map, line 0)

            , and after ~5 seconds the menu bar components load.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - This may be an ansible/menu bar issue. I also noticed that the bioviz connect page doesn't load the menu bar properly in safari. See a screenshot . This is what the menu bar looks like on load, there is an error in the console: [Error] Failed to load resource: the server responded with a status of 404 (Not Found) (lightbox.min.map, line 0) , and after ~5 seconds the menu bar components load.
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment - - edited

            Regarding the issue with bioviz menu bar, this issue persists in test.bioviz.org as well. So, I think the issue is due to the change made on IGBF-2729. We need to revert this commit for getting everything back to normal
            Attn: Chirag Chandrahas Shetty, Philip Badzuh and Dr. [~aloraine]

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - - edited Regarding the issue with bioviz menu bar, this issue persists in test.bioviz.org as well. So, I think the issue is due to the change made on IGBF-2729 . We need to revert this commit for getting everything back to normal Attn: Chirag Chandrahas Shetty , Philip Badzuh and Dr. [~aloraine]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Sai Supreeth Segu - Can you please confirm the error is now gone on test.bioviz.org and devappstore3/5 ?

            If yes, please request Philip Badzuh to re-test on Safari browser.

            Show
            ann.loraine Ann Loraine added a comment - - edited Sai Supreeth Segu - Can you please confirm the error is now gone on test.bioviz.org and devappstore3/5 ? If yes, please request Philip Badzuh to re-test on Safari browser.
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            I have tested devappstore3/5 and test.bioviz.org on Safari, the issue is fixed now. Philip Badzuh Please review this ticket (IGBF-2674) on Safari browser

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - I have tested devappstore3/5 and test.bioviz.org on Safari, the issue is fixed now. Philip Badzuh Please review this ticket ( IGBF-2674 ) on Safari browser
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment - - edited

            I am still seeing the issue of the menu bar not loading properly on the bioviz connect page - it is either rendered after a 3+ second delay or not at all...This is also present when using google chrome. I'm not sure what commit is responsible, but this is present on the production site - bioviz.org, so it may have also been the result of a change introduced before those made in this ticket. Maybe a new bug ticket should be made to fix the issue.

            The other styling issue is fixed, however, and the safari warning/notification banner works as expected.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - - edited I am still seeing the issue of the menu bar not loading properly on the bioviz connect page - it is either rendered after a 3+ second delay or not at all...This is also present when using google chrome. I'm not sure what commit is responsible, but this is present on the production site - bioviz.org, so it may have also been the result of a change introduced before those made in this ticket. Maybe a new bug ticket should be made to fix the issue. The other styling issue is fixed, however, and the safari warning/notification banner works as expected.
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Yes that issue still exists and it's in production. So, the issue might be with the code in bioviz.org. Please create a new ticket for that issue and please kindly check whether this issue is fixed or not.
            cc: Philip Badzuh

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Yes that issue still exists and it's in production. So, the issue might be with the code in bioviz.org. Please create a new ticket for that issue and please kindly check whether this issue is fixed or not. cc: Philip Badzuh
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            I'll make that ticket. Moving this to done.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - I'll make that ticket. Moving this to done.
            Hide
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

            Philip Badzuh I'm not sure but the delay might be because the application is not able to load https://www.bioviz.org/js/lightbox.min.map file.

            Show
            chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Philip Badzuh I'm not sure but the delay might be because the application is not able to load https://www.bioviz.org/js/lightbox.min.map file.
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            Yeah, I saw that in the console, but checking out at an earlier commit, that error is logged, but the delay isn't present, so that must be a separate problem.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Yeah, I saw that in the console, but checking out at an earlier commit, that error is logged, but the delay isn't present, so that must be a separate problem.

              People

              • Assignee:
                ssegu Sai Supreeth Segu (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: