Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2684

Fix spacing between elements in Submit App page

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Log in to https://apps.bioviz.org and click "Submit App" button to observe nicely spaced layout of elements in AppStore 1.0.

      Restore the same spacing to the AppStore 2.0 "submit app" page.

        Attachments

          Issue Links

            Activity

            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Dr. [~aloraine] and Sameer Shanbhag, please review my changes.
            Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] and Sameer Shanbhag , please review my changes. Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684#diff
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Hi Professor [~aloraine],

            Is inline CSS necessary on all the pages ? The changes really look ugly, there are classes which are already present in the code, just restoring the css in base.css (Deleted as a part of old css but was required) would do the work. The changes look good to me, but the code looks ugly.

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Hi Professor [~aloraine] , Is inline CSS necessary on all the pages ? The changes really look ugly, there are classes which are already present in the code, just restoring the css in base.css (Deleted as a part of old css but was required) would do the work. The changes look good to me, but the code looks ugly.
            Hide
            ann.loraine Ann Loraine added a comment -

            Thank you for asking. I defer to your judgement in this matter. If in some situations the in-line css makes code harder for others to understand and maintain, or is horribly repetitive, then please do not use it. Use your judgement as you are representing the developer point of view.

            Show
            ann.loraine Ann Loraine added a comment - Thank you for asking. I defer to your judgement in this matter. If in some situations the in-line css makes code harder for others to understand and maintain, or is horribly repetitive, then please do not use it. Use your judgement as you are representing the developer point of view.
            Hide
            ann.loraine Ann Loraine added a comment -

            My apologies for muddying the water of the discussion and for making more work for you. Since Sameer Shanbhag is more experienced with django and css than I am, I defer to his opinion here.

            attn: Sameer Shanbhag and Sai Supreeth Segu

            Show
            ann.loraine Ann Loraine added a comment - My apologies for muddying the water of the discussion and for making more work for you. Since Sameer Shanbhag is more experienced with django and css than I am, I defer to his opinion here. attn: Sameer Shanbhag and Sai Supreeth Segu
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Sai Supreeth Segu : Could you look for changes done to base.css and check which classes were deleted which were required by the Submit app page. I can help you with that if you want.

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Sai Supreeth Segu : Could you look for changes done to base.css and check which classes were deleted which were required by the Submit app page. I can help you with that if you want.
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Restored the Submit App page as in AppStore 1.0.
            Dr. [~aloraine] and Sameer Shanbhag, Please review my changes.
            Link for the branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684-1#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Restored the Submit App page as in AppStore 1.0. Dr. [~aloraine] and Sameer Shanbhag , Please review my changes. Link for the branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684-1#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            I'm sorry, I got confused.

            The latest master branch on https://devappstore5.bioviz.org "submit app" page seems to be already fixed. Was this maybe done in a prior commit?

            attn: Sai Supreeth Segu and Sameer Shanbhag

            Show
            ann.loraine Ann Loraine added a comment - I'm sorry, I got confused. The latest master branch on https://devappstore5.bioviz.org "submit app" page seems to be already fixed. Was this maybe done in a prior commit? attn: Sai Supreeth Segu and Sameer Shanbhag
            Hide
            ann.loraine Ann Loraine added a comment -

            Please ignore the previous comment! I was wrong about that.

            I have a request for Sai Supreeth Segu:

            I'm nervous about adding a lot of style classes to "base.css" that are only ever going to be needed on this one page.
            Can we please remove all the submit-app specific style from "base.css" and instead place those classes into a single .css file named after the django app that actually uses them. In this case, it would be called "submit_app.css".
            Piling loads and loads of stuff into "base.css" makes it super hard to maintain and improve appstore. I feel that the "base.css" file is already too big and complicated. Also, putting submit_app specific stuff into base.css means that other developers working on other pages or django apps will be tempted to use those same classes. If they do that, then it will be much harder to make a change to the submit_app page.

            Show
            ann.loraine Ann Loraine added a comment - Please ignore the previous comment! I was wrong about that. I have a request for Sai Supreeth Segu : I'm nervous about adding a lot of style classes to "base.css" that are only ever going to be needed on this one page. Can we please remove all the submit-app specific style from "base.css" and instead place those classes into a single .css file named after the django app that actually uses them. In this case, it would be called "submit_app.css". Piling loads and loads of stuff into "base.css" makes it super hard to maintain and improve appstore. I feel that the "base.css" file is already too big and complicated. Also, putting submit_app specific stuff into base.css means that other developers working on other pages or django apps will be tempted to use those same classes. If they do that, then it will be much harder to make a change to the submit_app page.
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Makes Sense. @Supreet Could you create a new submit_app folder under static which will have a css folder and inside that css folder there will be aubmit_app.css

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Makes Sense. @Supreet Could you create a new submit_app folder under static which will have a css folder and inside that css folder there will be aubmit_app.css
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Dr. [~aloraine] and Sameer Shanbhag, I have made changes and created a new upload_form.css in /static/submit_app/css folder.
            Link for the changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684-1#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] and Sameer Shanbhag , I have made changes and created a new upload_form.css in /static/submit_app/css folder. Link for the changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684-1#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Please submit PR when convenient.

            Show
            ann.loraine Ann Loraine added a comment - Please submit PR when convenient.
            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/248/igbf-2684-fixed-spacing-issue-between
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Merged. Deployed to https://devappstore5.bioviz.org for testing.

            Show
            ann.loraine Ann Loraine added a comment - - edited Merged. Deployed to https://devappstore5.bioviz.org for testing.
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            These changes are not updated because of error in css file name in html file.
            I have updated the name of css file.
            Please review my changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684-2#diff
            Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/262/igbf-2684-updating-name-of-css-file

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - These changes are not updated because of error in css file name in html file. I have updated the name of css file. Please review my changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2684-2#diff Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/262/igbf-2684-updating-name-of-css-file
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is now merged.

            Show
            ann.loraine Ann Loraine added a comment - PR is now merged.

              People

              • Assignee:
                ssegu Sai Supreeth Segu (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: