Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2687

Remove underscores from categories and test

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Remove underscores from curated categories and test the site functionality.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-2563 [ 18746 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-2676 [ IGBF-2676 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            see: appstore.py

            Show
            ann.loraine Ann Loraine added a comment - see: appstore.py
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Hi Professor,

            We should look for apps.py under curated_categories to remove the _ character

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Hi Professor, We should look for apps.py under curated_categories to remove the _ character
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Everything is working fine after removing _character. Dr. [~aloraine] and Sameer Shanbhag please review my changes
            Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2687#diff

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Everything is working fine after removing _character. Dr. [~aloraine] and Sameer Shanbhag please review my changes Link for my branch: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2687#diff
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Keeping underscores for now. Moving to Done.

            Show
            ann.loraine Ann Loraine added a comment - Keeping underscores for now. Moving to Done.
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Closed [ 6 ] To-Do [ 10305 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Underscores are appearing in too many places. Let's go ahead and merge this PR.

            Show
            ann.loraine Ann Loraine added a comment - Underscores are appearing in too many places. Let's go ahead and merge this PR.
            Hide
            ann.loraine Ann Loraine added a comment -

            Sai Supreeth Segu - please submit PR.

            Show
            ann.loraine Ann Loraine added a comment - Sai Supreeth Segu - please submit PR.
            ann.loraine Ann Loraine made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/241/igbf-2687-remove-underscores-from cc: Dr. [~aloraine] and Sameer Shanbhag
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            As Discussed we will not be merging this PR and will be kept in open state.

            Thanks for getting it done @Supreet

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - As Discussed we will not be merging this PR and will be kept in open state. Thanks for getting it done @Supreet
            Hide
            ann.loraine Ann Loraine added a comment -

            I realized there are likely going to be many places where the "underscores" are exposed and would need to be removed. But we won't be using the categories in any links ... so this should be fine.

            Also there may come a time when we actually need to use an underscore character because the underscore has meaning.

            Is that OK with you Sameer Shanbhag ?

            Show
            ann.loraine Ann Loraine added a comment - I realized there are likely going to be many places where the "underscores" are exposed and would need to be removed. But we won't be using the categories in any links ... so this should be fine. Also there may come a time when we actually need to use an underscore character because the underscore has meaning. Is that OK with you Sameer Shanbhag ?
            Hide
            ann.loraine Ann Loraine added a comment -

            Sai Supreeth Segu - sorry, when I merged in changes made by Chirag Chandrahas Shetty, it created a conflict for your PR. Please take a look!

            Show
            ann.loraine Ann Loraine added a comment - Sai Supreeth Segu - sorry, when I merged in changes made by Chirag Chandrahas Shetty , it created a conflict for your PR. Please take a look!
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            Hide
            ssegu Sai Supreeth Segu (Inactive) added a comment -

            Dr. [~aloraine] and Sameer Shanbhag, I have resolved the conflict and updated the pull request. If everyone is Ok with the change then we can merge the PR.
            Link for pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/241

            Show
            ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] and Sameer Shanbhag , I have resolved the conflict and updated the pull request. If everyone is Ok with the change then we can merge the PR. Link for pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/241
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ssegu Sai Supreeth Segu (Inactive) made changes -
            Assignee Sai Supreeth Segu [ ssegu ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Merged and deployed to https://devappstore5.bioviz.org

            Show
            ann.loraine Ann Loraine added a comment - - edited Merged and deployed to https://devappstore5.bioviz.org
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            The underscores are now removed and the UI looks OK.

            But we do want to make sure we test this well because there could be unforeseen side effects.

            To test, make sure that you can select and add one a category that contains a space. You can do this by logging in as "admin". (DM me if you need the password.) Then, if you visit an app's page, you should see an "edit" button there. If yes, then you can use the interface to assign the app to any category you want. Please try assigning it to a category that contains a space in the name to ensure this will properly work.

            Also, do please log in to the host & check error files for potential problems.

            Do please make this a high priority for testing when you get the chance!

            cc: Chirag Chandrahas Shetty, Sai Supreeth Segu, and Sameer Shanbhag

            Show
            ann.loraine Ann Loraine added a comment - The underscores are now removed and the UI looks OK. But we do want to make sure we test this well because there could be unforeseen side effects. To test, make sure that you can select and add one a category that contains a space. You can do this by logging in as "admin". (DM me if you need the password.) Then, if you visit an app's page, you should see an "edit" button there. If yes, then you can use the interface to assign the app to any category you want. Please try assigning it to a category that contains a space in the name to ensure this will properly work. Also, do please log in to the host & check error files for potential problems. Do please make this a high priority for testing when you get the chance! cc: Chirag Chandrahas Shetty , Sai Supreeth Segu , and Sameer Shanbhag
            Hide
            ann.loraine Ann Loraine added a comment -

            Please note: The devappstore5 has the latest master branch code, but I did not "blow away" the database and S3 bucket when I re-deployed the code. Just letting you know about that because the site is not a completely "fresh" site.

            Show
            ann.loraine Ann Loraine added a comment - Please note: The devappstore5 has the latest master branch code, but I did not "blow away" the database and S3 bucket when I re-deployed the code. Just letting you know about that because the site is not a completely "fresh" site.
            ann.loraine Ann Loraine made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            I re-deployed the appstore to devappstore5 for testing after "blowing away" the old data, since the new underscore-free categories were simply getting added to the existing ones.
            I assigned a bunch of new categories to the apps and noticed they are being displayed correctly and also the left-side search tool radio buttons are working as expected. Moving to closed.

            Show
            ann.loraine Ann Loraine added a comment - I re-deployed the appstore to devappstore5 for testing after "blowing away" the old data, since the new underscore-free categories were simply getting added to the existing ones. I assigned a bunch of new categories to the apps and noticed they are being displayed correctly and also the left-side search tool radio buttons are working as expected. Moving to closed.
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Sai Supreeth Segu [ ssegu ]

              People

              • Assignee:
                ssegu Sai Supreeth Segu (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: