Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22
Description
The "Install App" box on app pages currently is located in the middle-right part of an app's page. There is a lot of white space above it, which makes the page look unbalanced. Also, for many users, the most important functionality of the page is this very same "Install App" box.
Can this box be moved closer to the top of the page?
Please note that if this box can be moved, it would also need to move down a bit to make room for the "Edit" button when an author is logged in. However, this "Edit" button can probably be placed in another location, provided it's clear to an App author that they need to click this button (or link) in order to start editing the page.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2563 [ 18746 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
The branch is coming from a few commits back compared to where the master branch is pointing right now. Could you rebase on the latest commit of the master branch?
A (hopefully) quick request:
- Could you attach 2 images, one showing the app page with the "Edit" button and another without it?
The "Edit" button appears when the user is logged in and has write permission to the app. This could be an author of the app or an admin user.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Rank | Ranked higher |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Attachment | edit-page.png [ 15068 ] |
| Attachment | app-page.png [ 15069 ] |
Dr. [~aloraine], please find the images attached to the ticket. I also synched my branch with the master branch.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] | Ann Loraine [ aloraine ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Thank you! Please submit PR when convenient.
| Assignee | Ann Loraine [ aloraine ] | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Ann Loraine [ aloraine ] |
Merged and deployed to https://devappstore5.bioviz.org. Ready for testing.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Fall 7 Dec 14 - Dec 23 [ 110 ] | Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8 [ 110, 111 ] |
| Rank | Ranked higher |
In app page,
1. Space between "Edit this page" and "Install app" is not consistent with space between "Install app" button and "Resources" button.
2. Space between "Edit this page" and "Install app" is not consistent with space between "Install app" button and "Error" tab.
Also these changes are reflected in https://devappstore5.bioviz.org not in https://devappstore3.bioviz.org
cc: [~aloraine] and Chirag Chandrahas Shetty
Sorry about that - devappstore3 was not showing the correct branch. This will be fixed in the next minute or two when the playbooks finish running.
attn: Sai Supreeth Segu
| Attachment | after-change.png [ 15087 ] |
Adjusted gap between "Edit this page" and "Install app" is not consistent with space between "Install app" button and "Resources" button.
PR: https://bitbucket.org/lorainelab/appstore/pull-requests/259/igbf-2708-adjust-distance-between-edit
Merged and deployed to devappstore3 and devappstore5. Both are now up-to-date with the latest master branch.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Sprint | Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8 [ 110, 111 ] | Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22 [ 110, 111, 112 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
Everything looks good. Closing the ticket
| Assignee | Sai Supreeth Segu [ ssegu ] | Chirag Chandrahas Shetty [ chirag24 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Submitted PR.
Link: https://bitbucket.org/lorainelab/appstore/pull-requests/250