Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8
Description
There is something a bit wonky with the the app store tiles. Sometimes the categories are shown on the tiles themselves, sometimes not.
To repeat, do the following steps (using Chrome or other browser in incognito window to ensure you are using the latest css, or clear cache first):
- Go to https://devappstore5.bioviz.org (latest master branch code)
- Click "Plugin" (under App type)
- Observe that "Plugin" appears on some but not all the tiles (see 1.png)
- Now click "Any" (under App type)
- Observe that now suddenly all the tiles are showing their associated categories (2.png)
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2563 [ 18746 ] |
| Rank | Ranked higher |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Merged and deployed to https://devappstore5.bioviz.org. Ready for testing.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sai Supreeth Segu [ ssegu ] |
| Sprint | Fall 7 Dec 14 - Dec 23 [ 110 ] | Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8 [ 110, 111 ] |
| Rank | Ranked higher |
I have a Question regarding the changes done in this commit:
- Triggering the event for radio buttons in unnecessary:
-
$(function() { $("input[type=radio]").trigger('change'); });
Recommendation:
- Make a function which would segregate all the things inside the current checked event
- call that function when the js loads
- we can use that function when the checked event is invoked as well as in any other event / refresh
Three Reasons to do it this way:
- As we are segregating things in to a function, function name makes it easy for the developer to understand what's going on inside that function
- Can be called from any other place without code repetition
- Adding comment above the function is also a good idea to make it extremely clear on what exactly is happening
P.S. Please refer to the Screenshot of the code attached that does the things I explained.
Attn: Chirag Chandrahas Shetty [~aloraine]
| Attachment | nav_panel.js.jpg [ 15076 ] |
I am not sure I understand the proposed change, but it sounds like it will make the code easier to understand and maintain. Please make the change as you see fit.
attn: Sameer Shanbhag
Pull Request Submitted:
C.C. [~aloraine]
Merged and deployed to https://devappstore3.bioviz.org
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Looks Good. Closing the ticket.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Submitted PR.
Link: https://bitbucket.org/lorainelab/appstore/pull-requests/249