Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.8 Major Release
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Winter 3 Jan 25 - Feb 5, Winter 4 Feb 8 - Feb 19, Winter 5 Feb 22 - Mar 5
Description
Situation: In IGBF-2550 we renamed the Console tab to now be called Log. To be consistent, we should also change the Show Console dropdown under Help.
Task: Change Show Console to Show Log under the Help dropdown.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Rank | Ranked higher |
| Assignee | Irvin Naylor [ inaylor ] |
Great question, so I'd like to weigh in:
I do think we ought to change the back end variable names to improve readability of the code, but we should do that in a separate ticket. We can also label the ticket with "Beginner" as this could be a good task for one of the newer joiners.
| Comment | [ Good question, I would lean towards just the front-end renaming for now as I'm not sure how extensive the changes would need to change all of the back end as well. The front-end changes should be relatively low risk. ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Sounds good!
Here's the link to my branch: https://bitbucket.org/Inaylor01/integrated-genome-browser/src/IGBF-2764/
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Irvin Naylor [ inaylor ] |
| Sprint | Winter 3 Jan 25 - Feb 5 [ 113 ] | Winter 3 Jan 25 - Feb 5, Winter 4 Feb 8 - Feb 19 [ 113, 114 ] |
| Rank | Ranked higher |
| Assignee | Rachel Weidenhammer [ rweidenh ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Functional Review:
Download and Install works.
Help tab has the option "Show Log" and not 'Show Console".
It functions appropriately.
Code Review:
Changes look good: substituted the word "Log" for "Console".
Recommending Pull Request.
| Assignee | Rachel Weidenhammer [ rweidenh ] | Irvin Naylor [ inaylor ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Irvin Naylor [ inaylor ] |
Merged. Installers are ready for testing.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Winter 3 Jan 25 - Feb 5, Winter 4 Feb 8 - Feb 19 [ 113, 114 ] | Winter 3 Jan 25 - Feb 5, Winter 4 Feb 8 - Feb 19, Winter 5 Feb 22 - Mar 5 [ 113, 114, 115 ] |
| Rank | Ranked higher |
| Comment | [ I am able to open and run ProtAnnot without the reported errors. Tested on macOS. ] |
| Fix Version/s | 9.1.8 Major Release [ 10605 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested on Mac 10.14.6 with dmg installer.
Show Console now appears as Show Log.
Closing issue.
| Assignee | Nowlan Freese [ nfreese ] | Irvin Naylor [ inaylor ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Nowlan Freese Question: With the renaming, should we also rename everything in the backend that points to "ShowConsole" to "ShowLog" as well, or is this only a front-end renaming?