Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2786

Do not hit logout endpoint on analysis workflow error

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      See analysisOperations.js around line 163.

      When an error is returned, the user gets logged out. Instead of logging them out, show some kind of error message instead.

      Note that there are some other places in the code where errors happen and the user experience is better.

        Attachments

          Activity

          Show
          nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/236/igbf-2786-handle-err_does_not_exist-error
          Hide
          karthik Karthik Raveendran added a comment - - edited

          For testing this issue, delete the value in Input File test-field, add a value that is not an actual filepath and click on the Run Analysis button. The user should not be logged out from bioviz connect and an error toast should appear at that point.

          Show
          karthik Karthik Raveendran added a comment - - edited For testing this issue, delete the value in Input File test-field, add a value that is not an actual filepath and click on the Run Analysis button. The user should not be logged out from bioviz connect and an error toast should appear at that point.
          Hide
          ann.loraine Ann Loraine added a comment -

          Deployed to https://bvctest7.bioviz.org for testing.

          Show
          ann.loraine Ann Loraine added a comment - Deployed to https://bvctest7.bioviz.org for testing.
          Hide
          nfreese Nowlan Freese added a comment - - edited

          If the bam field does not match any file, an error appears and the analysis not submitted. However, if the input file field is empty then the analysis is submitted (but will fail) so long as the Output File Name has a value (which it does by default). If the Output File Name field is empty then clicking Run Analysis does nothing.

          Can we update the error response so that all fields require a value?

          Show
          nfreese Nowlan Freese added a comment - - edited If the bam field does not match any file, an error appears and the analysis not submitted. However, if the input file field is empty then the analysis is submitted (but will fail) so long as the Output File Name has a value (which it does by default). If the Output File Name field is empty then clicking Run Analysis does nothing. Can we update the error response so that all fields require a value?
          Show
          nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/238/igbf-2786-add-error-toast-to-empty-input
          Hide
          nfreese Nowlan Freese added a comment -

          Input fields for running analyses now throw an error if no input is available.

          Closing issue.

          Show
          nfreese Nowlan Freese added a comment - Input fields for running analyses now throw an error if no input is available. Closing issue.

            People

            • Assignee:
              karthik Karthik Raveendran
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: