Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2786

Do not hit logout endpoint on analysis workflow error

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          See analysisOperations.js around line 163.

          When an error is returned, the user gets logged out. Instead of logging them out, show some kind of error message instead.

          Note that there are some other places in the code where errors happen and the user experience is better.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              ann.loraine Ann Loraine created issue -
              ann.loraine Ann Loraine made changes -
              Field Original Value New Value
              Epic Link IGBF-2376 [ 18533 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Summary Do not hit logout endpoint on error Do not hit logout endpoint on analysis workflow error
              ann.loraine Ann Loraine made changes -
              Sprint Winter 4 Feb 8 - Feb 19 [ 114 ] Winter 4 Feb 8 - Feb 19, Winter 5 Feb 22 - Mar 5 [ 114, 115 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              karthik Karthik Raveendran made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              karthik Karthik Raveendran made changes -
              Assignee Karthik Raveendran [ karthik ]
              karthik Karthik Raveendran made changes -
              Assignee Karthik Raveendran [ karthik ]
              karthik Karthik Raveendran made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/236/igbf-2786-handle-err_does_not_exist-error

              Show
              nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/236/igbf-2786-handle-err_does_not_exist-error
              Hide
              Permalink
              karthik Karthik Raveendran added a comment - - edited

              For testing this issue, delete the value in Input File test-field, add a value that is not an actual filepath and click on the Run Analysis button. The user should not be logged out from bioviz connect and an error toast should appear at that point.

              Show
              karthik Karthik Raveendran added a comment - - edited For testing this issue, delete the value in Input File test-field, add a value that is not an actual filepath and click on the Run Analysis button. The user should not be logged out from bioviz connect and an error toast should appear at that point.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Deployed to https://bvctest7.bioviz.org for testing.

              Show
              ann.loraine Ann Loraine added a comment - Deployed to https://bvctest7.bioviz.org for testing.
              ann.loraine Ann Loraine made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              ann.loraine Ann Loraine made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              ann.loraine Ann Loraine made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              nfreese Nowlan Freese made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              nfreese Nowlan Freese made changes -
              Assignee Nowlan Freese [ nfreese ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment - - edited

              If the bam field does not match any file, an error appears and the analysis not submitted. However, if the input file field is empty then the analysis is submitted (but will fail) so long as the Output File Name has a value (which it does by default). If the Output File Name field is empty then clicking Run Analysis does nothing.

              Can we update the error response so that all fields require a value?

              Show
              nfreese Nowlan Freese added a comment - - edited If the bam field does not match any file, an error appears and the analysis not submitted. However, if the input file field is empty then the analysis is submitted (but will fail) so long as the Output File Name has a value (which it does by default). If the Output File Name field is empty then clicking Run Analysis does nothing. Can we update the error response so that all fields require a value?
              nfreese Nowlan Freese made changes -
              Assignee Nowlan Freese [ nfreese ] Karthik Raveendran [ karthik ]
              nfreese Nowlan Freese made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
              nfreese Nowlan Freese made changes -
              Resolution Done [ 10000 ]
              Status Closed [ 6 ] To-Do [ 10305 ]
              karthik Karthik Raveendran made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/238/igbf-2786-add-error-toast-to-empty-input

              Show
              nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/238/igbf-2786-add-error-toast-to-empty-input
              karthik Karthik Raveendran made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              karthik Karthik Raveendran made changes -
              Assignee Karthik Raveendran [ karthik ]
              nfreese Nowlan Freese made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              nfreese Nowlan Freese made changes -
              Assignee Nowlan Freese [ nfreese ]
              nfreese Nowlan Freese made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              nfreese Nowlan Freese made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              nfreese Nowlan Freese made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              nfreese Nowlan Freese made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Input fields for running analyses now throw an error if no input is available.

              Closing issue.

              Show
              nfreese Nowlan Freese added a comment - Input fields for running analyses now throw an error if no input is available. Closing issue.
              nfreese Nowlan Freese made changes -
              Assignee Nowlan Freese [ nfreese ] Karthik Raveendran [ karthik ]
              nfreese Nowlan Freese made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              nfreese Nowlan Freese made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                People

                • Assignee:
                  karthik Karthik Raveendran
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: