Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2804

Output species.txt in the Quickload Saver app

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      Winter 6 Mar 8 - Mar 19, Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16, Spring 3 2021 Apr 19 - Apr 30

      Description

      Situation: The Quickload Saver app outputs an IGB Quickload. It does not currently include the optional species.txt file.

      Task: Output the species.txt file when using the Quickload Saver app.

        Attachments

          Issue Links

            Activity

            nfreese Nowlan Freese created issue -
            nfreese Nowlan Freese made changes -
            Field Original Value New Value
            Epic Link IGBF-1765 [ 17855 ]
            ann.loraine Ann Loraine made changes -
            Sprint Winter 6 Mar 8 - Mar 19 [ 116 ] Winter 6 Mar 8 - Mar 19, Spring 1 Mar 22 - Apr 2 [ 116, 117 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            omarne Omkar Marne (Inactive) made changes -
            Assignee Omkar Marne [ omarne ]
            omarne Omkar Marne (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Show
            nfreese Nowlan Freese added a comment - Quickload Saver: https://bitbucket.org/lorainelab/quickload-saver/src/master/ Species.txt documentation: https://wiki.transvar.org/display/igbman/Sharing+data+for+a+custom+genome+not+already+part+of+IGB+QuickLoad#SharingdataforacustomgenomenotalreadypartofIGBQuickLoad-Createspecies.txtfile
            nfreese Nowlan Freese made changes -
            Link This issue relates to IGBF-510 [ IGBF-510 ]
            Hide
            nfreese Nowlan Freese added a comment -

            Look at how Noor outputs the contents.txt. You can use similar code to output the species.txt.

            Show
            nfreese Nowlan Freese added a comment - Look at how Noor outputs the contents.txt. You can use similar code to output the species.txt.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            nfreese Nowlan Freese made changes -
            Assignee Omkar Marne [ omarne ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Assignee Rachel Weidenhammer [ rweidenh ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Working on adding species.txt section to the QuickloadSaver App code.

            On bitbucket, I see my topic branch on my remote fork and it does build in pipelines.
            But it doesn't produce any files in my downloads section.
            I can't see this branch in my branches section on Bitbucket.
            I created a new branch from the master locally, then pushed the changes to my remote repo.
            I need to see if this is what's causing the files to not appear in my downloads.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Working on adding species.txt section to the QuickloadSaver App code. On bitbucket, I see my topic branch on my remote fork and it does build in pipelines. But it doesn't produce any files in my downloads section. I can't see this branch in my branches section on Bitbucket. I created a new branch from the master locally, then pushed the changes to my remote repo. I need to see if this is what's causing the files to not appear in my downloads.
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Thank you to Chester.
            The App Password and Repository Variables were not set up before.
            The Pipelines are now properly building the jar and xml files in the Downloads section.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Thank you to Chester. The App Password and Repository Variables were not set up before. The Pipelines are now properly building the jar and xml files in the Downloads section.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Fork link for reference: https://bitbucket.org/Rweidenh/quickload-saver/downloads/
            I haven't pushed anything remotely at this time.

            I am still working on implementing the species.txt file creation ability in the app's code.
            What's slowing me down right now is trying to understand the object classes and their function.
            I am looking for a javadoc type documentation.

            For example:
            genomeVersion, getSpeciesName() getDescription()

            What information is stored here exactly, where is it taken from, and what class do these come from?

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Fork link for reference: https://bitbucket.org/Rweidenh/quickload-saver/downloads/ I haven't pushed anything remotely at this time. I am still working on implementing the species.txt file creation ability in the app's code. What's slowing me down right now is trying to understand the object classes and their function. I am looking for a javadoc type documentation. For example: genomeVersion, getSpeciesName() getDescription() What information is stored here exactly, where is it taken from, and what class do these come from?
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

            Working on getting a plain species.txt file to be created.
            I am starting to understand the existing code.
            Altered some hard coding to accommodate an additional file.
            I am trying to understand now why the annots file code looks to have a different way of creating a file than the contents file does.

            Edit: The code for creating files appeared to be labeled as code for just the contents.txt file, but it was actually a new section of its own, responsible for creating all files previous to it.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited Working on getting a plain species.txt file to be created. I am starting to understand the existing code. Altered some hard coding to accommodate an additional file. I am trying to understand now why the annots file code looks to have a different way of creating a file than the contents file does. Edit: The code for creating files appeared to be labeled as code for just the contents.txt file, but it was actually a new section of its own, responsible for creating all files previous to it.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

            All files are now being created, and in the right place too.

            The information needed for species.txt is in the file.
            Now I need to clean up the formatting and separate out the exact information we need.

            I have pushed my local changes to my remote branch for reference.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited All files are now being created, and in the right place too. The information needed for species.txt is in the file. Now I need to clean up the formatting and separate out the exact information we need. I have pushed my local changes to my remote branch for reference.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            The file is being created and the main content: the latin name, common name, and version prefix, are being created in the file.
            The "Galaxy/UCSC genome version prefix" is not created but I'm not sure if we wanted to have that function here.

            Looking at it now, my current logic for getting the information for the common name and the version prefix from the genome version description and name will not be able to handle common names with more than one word or version prefixes with more than two parts.

            I will have to rethink my solution to this.
            Maybe I can get to where the genome version description and genome version name are being created, but that location is not the GenomeVersion.java file.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - The file is being created and the main content: the latin name, common name, and version prefix, are being created in the file. The "Galaxy/UCSC genome version prefix" is not created but I'm not sure if we wanted to have that function here. Looking at it now, my current logic for getting the information for the common name and the version prefix from the genome version description and name will not be able to handle common names with more than one word or version prefixes with more than two parts. I will have to rethink my solution to this. Maybe I can get to where the genome version description and genome version name are being created, but that location is not the GenomeVersion.java file.
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Story Points 2 4
            ann.loraine Ann Loraine made changes -
            Sprint Winter 6 Mar 8 - Mar 19, Spring 1 2021 Mar 22 - Apr 2 [ 116, 117 ] Winter 6 Mar 8 - Mar 19, Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16 [ 116, 117, 118 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

            Link to fork downloads page: https://bitbucket.org/Rweidenh/quickload-saver/downloads/
            Link to branch: https://bitbucket.org/Rweidenh/quickload-saver/branch/IGBF-2804

            There are four columns to a Species.txt file:
            Latin Name, Common Name, Genome Prefix, and Genome Prefixes used by other data providers (UCSC/Galaxy).

            For the purposes of the Quickload Saver app, Dr. Freese and I have decided to have the app only populate the first and third (Latin Name and Genome Prefix) columns, with the Common Name column being replaced by a TAB character. The idea is that this covers the basics of what IGB needs to populate the "Species" and "Genome Version" dropdown menus.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited Link to fork downloads page: https://bitbucket.org/Rweidenh/quickload-saver/downloads/ Link to branch: https://bitbucket.org/Rweidenh/quickload-saver/branch/IGBF-2804 There are four columns to a Species.txt file: Latin Name, Common Name, Genome Prefix, and Genome Prefixes used by other data providers (UCSC/Galaxy). For the purposes of the Quickload Saver app, Dr. Freese and I have decided to have the app only populate the first and third (Latin Name and Genome Prefix) columns, with the Common Name column being replaced by a TAB character. The idea is that this covers the basics of what IGB needs to populate the "Species" and "Genome Version" dropdown menus.
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Assignee Rachel Weidenhammer [ rweidenh ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Rachel Weidenhammer [ rweidenh ]
            Hide
            ann.loraine Ann Loraine added a comment -

            More detail - test using a species and genome that do not already exist in the species and genome version menus.

            Show
            ann.loraine Ann Loraine added a comment - More detail - test using a species and genome that do not already exist in the species and genome version menus.
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited

            To Test:
            Follow the instructions here: https://wiki.transvar.org/display/ITD/Quickload+Saver
            Don't use the LoraineLab link in the instructions (https://bitbucket.org/lorainelab/quickload-saver/downloads/)
            Instead use the topic branch link: https://bitbucket.org/Rweidenh/quickload-saver/downloads/

            After completing the wiki instructions, find the quickload files you created and saved to your local machine.
            Open the files and find the species.txt file created.
            In the species.txt file you should see the Latin Name (e.g. equus unicornis), followed by three TAB spaces, followed by the Genome Prefix (e.g. E_unicornis).

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - - edited To Test: Follow the instructions here: https://wiki.transvar.org/display/ITD/Quickload+Saver Don't use the LoraineLab link in the instructions ( https://bitbucket.org/lorainelab/quickload-saver/downloads/ ) Instead use the topic branch link: https://bitbucket.org/Rweidenh/quickload-saver/downloads/ After completing the wiki instructions, find the quickload files you created and saved to your local machine. Open the files and find the species.txt file created. In the species.txt file you should see the Latin Name (e.g. equus unicornis), followed by three TAB spaces, followed by the Genome Prefix (e.g. E_unicornis).
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Assignee Rachel Weidenhammer [ rweidenh ]
            inaylor Irvin Naylor (Inactive) made changes -
            Assignee Irvin Naylor [ inaylor ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            inaylor Irvin Naylor (Inactive) added a comment -

            Can confirm, followed these steps on the latest 9.1.8 installer and in the species.txt file, I am indeed seeing the latin name, the three tab spaces and the genome prefix. Everything looks good! Recommending pull request

            Show
            inaylor Irvin Naylor (Inactive) added a comment - Can confirm, followed these steps on the latest 9.1.8 installer and in the species.txt file, I am indeed seeing the latin name, the three tab spaces and the genome prefix. Everything looks good! Recommending pull request
            inaylor Irvin Naylor (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Assignee Irvin Naylor [ inaylor ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Link to PR https://bitbucket.org/lorainelab/quickload-saver/pull-requests/3/igbf-2804-output-speciestxt-file
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Sprint Winter 6 Mar 8 - Mar 19, Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16 [ 116, 117, 118 ] Winter 6 Mar 8 - Mar 19, Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16, Spring 3 2021 Apr 19 - Apr 30 [ 116, 117, 118, 119 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Assignee Irvin Naylor [ inaylor ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            inaylor Irvin Naylor (Inactive) made changes -
            Attachment NewOpenGenome.PNG [ 15753 ]
            Hide
            inaylor Irvin Naylor (Inactive) added a comment -

            Moved back to needs post-merge testing. Quickload saver does indeed output correct species.txt file contents when a quickload is saved. However, it only does so whenever optional genome details (i.e. Genus, Species, Variety, Genome release date) from Karthik's recent UI change (see screenshot) are filled in.

            Otherwise, if those fields are blank, there have been two different types of observed results taking place: either the quickload won't save anything to the user-specified folder or the quickload will save but will only include the annots.xml file.

            Show
            inaylor Irvin Naylor (Inactive) added a comment - Moved back to needs post-merge testing. Quickload saver does indeed output correct species.txt file contents when a quickload is saved. However, it only does so whenever optional genome details (i.e. Genus, Species, Variety, Genome release date) from Karthik's recent UI change (see screenshot) are filled in. Otherwise, if those fields are blank, there have been two different types of observed results taking place: either the quickload won't save anything to the user-specified folder or the quickload will save but will only include the annots.xml file.
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Plan is to test again once all various code changes are merged to master, just before release testing.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Plan is to test again once all various code changes are merged to master, just before release testing.
            inaylor Irvin Naylor (Inactive) made changes -
            Assignee Irvin Naylor [ inaylor ]
            Hide
            inaylor Irvin Naylor (Inactive) added a comment -

            Pasted from log after no files were saved to new quickload folder from blank optional fields:

            10:57:56.542 INFO c.a.igb.view.load.GeneralLoadUtils - Loaded E_unicornis_Jul_2043.bed.gz in 37.22 ms
            Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 1
            at org.lorainelab.igb.menuoption.CreateQuickloadAction.createQuickload(CreateQuickloadAction.java:133)
            at org.lorainelab.igb.menuoption.CreateQuickloadAction.showFileChooser(CreateQuickloadAction.java:104)
            at org.lorainelab.igb.menuoption.CreateQuickloadAction.actionPerformed(CreateQuickloadAction.java:75)
            at org.lorainelab.igb.menuoption.CreateQuickloadAction.lambda$getMenuItems$0(CreateQuickloadAction.java:301)
            at org.lorainelab.igb.menu.api.util.MenuUtils$1.actionPerformed(MenuUtils.java:26)
            at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
            at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
            at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
            at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
            at javax.swing.AbstractButton.doClick(Unknown Source)
            at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
            at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
            at java.awt.Component.processMouseEvent(Unknown Source)
            at javax.swing.JComponent.processMouseEvent(Unknown Source)
            at java.awt.Component.processEvent(Unknown Source)
            at java.awt.Container.processEvent(Unknown Source)
            at java.awt.Component.dispatchEventImpl(Unknown Source)
            at java.awt.Container.dispatchEventImpl(Unknown Source)
            at java.awt.Component.dispatchEvent(Unknown Source)
            at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
            at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
            at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
            at java.awt.Container.dispatchEventImpl(Unknown Source)
            at java.awt.Window.dispatchEventImpl(Unknown Source)
            at java.awt.Component.dispatchEvent(Unknown Source)
            at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
            at java.awt.EventQueue.access$500(Unknown Source)
            at java.awt.EventQueue$3.run(Unknown Source)
            at java.awt.EventQueue$3.run(Unknown Source)
            at java.security.AccessController.doPrivileged(Native Method)
            at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
            at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
            at java.awt.EventQueue$4.run(Unknown Source)
            at java.awt.EventQueue$4.run(Unknown Source)
            at java.security.AccessController.doPrivileged(Native Method)
            at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
            at java.awt.EventQueue.dispatchEvent(Unknown Source)
            at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
            at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
            at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
            at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
            at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
            at java.awt.EventDispatchThread.run(Unknown Source)

            Show
            inaylor Irvin Naylor (Inactive) added a comment - Pasted from log after no files were saved to new quickload folder from blank optional fields: 10:57:56.542 INFO c.a.igb.view.load.GeneralLoadUtils - Loaded E_unicornis_Jul_2043.bed.gz in 37.22 ms Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 1 at org.lorainelab.igb.menuoption.CreateQuickloadAction.createQuickload(CreateQuickloadAction.java:133) at org.lorainelab.igb.menuoption.CreateQuickloadAction.showFileChooser(CreateQuickloadAction.java:104) at org.lorainelab.igb.menuoption.CreateQuickloadAction.actionPerformed(CreateQuickloadAction.java:75) at org.lorainelab.igb.menuoption.CreateQuickloadAction.lambda$getMenuItems$0(CreateQuickloadAction.java:301) at org.lorainelab.igb.menu.api.util.MenuUtils$1.actionPerformed(MenuUtils.java:26) at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source) at javax.swing.DefaultButtonModel.setPressed(Unknown Source) at javax.swing.AbstractButton.doClick(Unknown Source) at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source) at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source) at java.awt.Component.processMouseEvent(Unknown Source) at javax.swing.JComponent.processMouseEvent(Unknown Source) at java.awt.Component.processEvent(Unknown Source) at java.awt.Container.processEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$500(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source)
            Hide
            nfreese Nowlan Freese added a comment -

            Three issues:
            Quickload Saver index out of bounds
            Quickload Saver not saving foreground color
            Quickload Saver extra tab in species.txt

            Show
            nfreese Nowlan Freese added a comment - Three issues: Quickload Saver index out of bounds Quickload Saver not saving foreground color Quickload Saver extra tab in species.txt
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            rweidenh Logan Weidenhammer (Inactive) made changes -
            Assignee Rachel Weidenhammer [ rweidenh ]
            Hide
            rweidenh Logan Weidenhammer (Inactive) added a comment -

            Extra tab is removed from species.txt
            Index out of bounds exception no longer present and files are created appropriately.

            If the user opens a new genome from file and enters no data, the species.txt file will show:
            Custom Species 1 (TAB) (TAB) Custom Genome 1

            Working on foreground color saving now.

            Show
            rweidenh Logan Weidenhammer (Inactive) added a comment - Extra tab is removed from species.txt Index out of bounds exception no longer present and files are created appropriately. If the user opens a new genome from file and enters no data, the species.txt file will show: Custom Species 1 (TAB) (TAB) Custom Genome 1 Working on foreground color saving now.
            Hide
            nfreese Nowlan Freese added a comment -

            Logan Weidenhammer - I fixed the foreground color, it was related to the change I made to the URI encoding.

            Show
            nfreese Nowlan Freese added a comment - Logan Weidenhammer - I fixed the foreground color, it was related to the change I made to the URI encoding.
            nfreese Nowlan Freese made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            nfreese Nowlan Freese made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            nfreese Nowlan Freese made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            nfreese Nowlan Freese made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            nfreese Nowlan Freese made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            nfreese Nowlan Freese made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            Hide
            nfreese Nowlan Freese added a comment -

            Rachel and I tested on Windows and Mac. Working correctly.

            Closing issue.

            Show
            nfreese Nowlan Freese added a comment - Rachel and I tested on Windows and Mac. Working correctly. Closing issue.
            nfreese Nowlan Freese made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            nfreese Nowlan Freese made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                rweidenh Logan Weidenhammer (Inactive)
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: