Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16, Spring 3 2021 Apr 19 - Apr 30
Description
In App Store 1.0 we were using the help sub-app in the footer but App Store 2.0 has no footer. Remove the code that are not used anywhere.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2563 [ 18746 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
OK.
I think you should leave the "help" app in place but delete all functions not being used.
Question: How are you making sure that a function is not being used?
[~aloraine] I am searching the function name in the code base.
Are you sure you are finding everything?
Yes, Dr. [~aloraine]. I will double check before removing anything and will test app-store on my local system before pushing the changes.
Here's what I do when I need to global search:
- move to Unix system
- execute:
query_string="a_method"
find . -type f -exec grep -Iq . {} \; -print | xargs grep $query_string
Atom IDE as an inbuilt feature which searches the whole project for string.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Diff: https://bitbucket.org/chirag06/appstore/commits/7216eb1c24e59873b92fc7689a95b2a18761277d
Testing:
1) Please test the whole app-store by following steps mentioned in ticket https://jira.transvar.org/browse/IGBF-2717.
2) Also test search functionality.
Request for Chirag Chandrahas Shetty:
Kindly deploy the branch on one of the devappstore sites for testing and make a note of it here.
To confirm the App store is still working properly prior to merging the PR, please go through the steps mentioned in the Jira ticket on that site, making a note of what you have done.
In addition, click on all the "help" links (icons that look like an "i").
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Changes deployed on Devappstore5. Tested the application on devappstore 5 and everything looks good. Moving the ticket to testing.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Please submit PR when convenient.
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Ann Loraine [ aloraine ] | Chirag Chandrahas Shetty [ chirag24 ] |
| Sprint | Spring 1 2021 Mar 22 - Apr 2 [ 117 ] | Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16 [ 117, 118 ] |
| Rank | Ranked higher |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Test on https://devappstore5.bioviz.org
| Assignee | Omkar Marne [ omarne ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16 [ 117, 118 ] | Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16, Spring 3 2021 Apr 19 - Apr 30 [ 117, 118, 119 ] |
| Rank | Ranked higher |
Tested on https://devappstore5.bioviz.org
- App is working fine.
- Search functionality is working good.
- Curated categories can be added and deleted
- Showing the latest version when selected.
- Asking for version number while deletion.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Omkar Marne [ omarne ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
[~aloraine] We cannot completely remove the help sub app because we are using one function compile-app-with-pipeline in submit-app sub app. The function simply redirects to https://docs.google.com/document/d/1JdS9vnaXHkSJb0XdR7JgExCI2Y1MhpXhN8X8okO00-0. What we can do is move this one function from help sub app to submit_app sub app or we can remove other codes from help sub-app.