Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2824

Try to remove the redundant code from the Help sub-app.

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16, Spring 3 2021 Apr 19 - Apr 30

      Description

      In App Store 1.0 we were using the help sub-app in the footer but App Store 2.0 has no footer. Remove the code that are not used anywhere.

        Attachments

          Issue Links

            Activity

            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Ann Loraine We cannot completely remove the help sub app because we are using one function compile-app-with-pipeline in submit-app sub app. The function simply redirects to https://docs.google.com/document/d/1JdS9vnaXHkSJb0XdR7JgExCI2Y1MhpXhN8X8okO00-0. What we can do is move this one function from help sub app to submit_app sub app or we can remove other codes from help sub-app.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Ann Loraine We cannot completely remove the help sub app because we are using one function compile-app-with-pipeline in submit-app sub app. The function simply redirects to https://docs.google.com/document/d/1JdS9vnaXHkSJb0XdR7JgExCI2Y1MhpXhN8X8okO00-0 . What we can do is move this one function from help sub app to submit_app sub app or we can remove other codes from help sub-app.
            Hide
            aloraine Ann Loraine added a comment -

            OK.

            I think you should leave the "help" app in place but delete all functions not being used.

            Question: How are you making sure that a function is not being used?

            Show
            aloraine Ann Loraine added a comment - OK. I think you should leave the "help" app in place but delete all functions not being used. Question: How are you making sure that a function is not being used?
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Ann Loraine I am searching the function name in the code base.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Ann Loraine I am searching the function name in the code base.
            Hide
            aloraine Ann Loraine added a comment -

            Are you sure you are finding everything?

            Show
            aloraine Ann Loraine added a comment - Are you sure you are finding everything?
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Yes, Dr. Ann Loraine. I will double check before removing anything and will test app-store on my local system before pushing the changes.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Yes, Dr. Ann Loraine . I will double check before removing anything and will test app-store on my local system before pushing the changes.
            Hide
            aloraine Ann Loraine added a comment -

            Here's what I do when I need to global search:

            • move to Unix system
            • execute:
            query_string="a_method"
            find . -type f -exec grep -Iq . {} \; -print | xargs grep $query_string
            
            Show
            aloraine Ann Loraine added a comment - Here's what I do when I need to global search: move to Unix system execute: query_string= "a_method" find . -type f -exec grep -Iq . {} \; -print | xargs grep $query_string
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Atom IDE as an inbuilt feature which searches the whole project for string.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Atom IDE as an inbuilt feature which searches the whole project for string.
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment - - edited

            Diff: https://bitbucket.org/chirag06/appstore/commits/7216eb1c24e59873b92fc7689a95b2a18761277d

            Testing:
            1) Please test the whole app-store by following steps mentioned in ticket https://jira.transvar.org/browse/IGBF-2717.
            2) Also test search functionality.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - - edited Diff: https://bitbucket.org/chirag06/appstore/commits/7216eb1c24e59873b92fc7689a95b2a18761277d Testing: 1) Please test the whole app-store by following steps mentioned in ticket https://jira.transvar.org/browse/IGBF-2717 . 2) Also test search functionality.
            Hide
            aloraine Ann Loraine added a comment -

            Request for Chirag Chandrahas Shetty:
            Kindly deploy the branch on one of the devappstore sites for testing and make a note of it here.
            To confirm the App store is still working properly prior to merging the PR, please go through the steps mentioned in the Jira ticket on that site, making a note of what you have done.
            In addition, click on all the "help" links (icons that look like an "i").

            Show
            aloraine Ann Loraine added a comment - Request for Chirag Chandrahas Shetty : Kindly deploy the branch on one of the devappstore sites for testing and make a note of it here. To confirm the App store is still working properly prior to merging the PR, please go through the steps mentioned in the Jira ticket on that site, making a note of what you have done. In addition, click on all the "help" links (icons that look like an "i").
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Changes deployed on Devappstore5. Tested the application on devappstore 5 and everything looks good. Moving the ticket to testing.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Changes deployed on Devappstore5. Tested the application on devappstore 5 and everything looks good. Moving the ticket to testing.
            Hide
            aloraine Ann Loraine added a comment -

            Please submit PR when convenient.

            Show
            aloraine Ann Loraine added a comment - Please submit PR when convenient.
            Show
            chirag24 Chirag Chandrahas Shetty added a comment - PR: https://bitbucket.org/lorainelab/appstore/pull-requests/276/igbf-2824-remove-code-not-used-from-help
            Hide
            aloraine Ann Loraine added a comment -
            Show
            aloraine Ann Loraine added a comment - Test on https://devappstore5.bioviz.org
            Hide
            omarne Omkar Marne added a comment - - edited

            Tested on https://devappstore5.bioviz.org

            • App is working fine.
            • Search functionality is working good.
            • Curated categories can be added and deleted
            • Showing the latest version when selected.
            • Asking for version number while deletion.
            Show
            omarne Omkar Marne added a comment - - edited Tested on https://devappstore5.bioviz.org App is working fine. Search functionality is working good. Curated categories can be added and deleted Showing the latest version when selected. Asking for version number while deletion.

              People

              • Assignee:
                chirag24 Chirag Chandrahas Shetty
                Reporter:
                chirag24 Chirag Chandrahas Shetty
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: