Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7, Fall 8, Fall 9
Description
When a user clicks on the "Install IGB" button on the App Store header, the button changes to an orange color.
Instead, the color behavior should match clicking the same button on the main page bioviz.org.
Note that the same thing happens on the "IGB Genomes" page. Furthermore, the "Install IGB" button that is accessed on this page by clicking "Genome Versions" > "View in IGB" does not route anywhere when clicked.
There may be an issue with bootstrap versions? Please investigate.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2563 [ 18746 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Sprint | Spring 4 2021 May 3 - May 14 [ 120 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28 [ 120, 121 ] |
| Rank | Ranked higher |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28 [ 120, 121 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11 [ 120, 121, 122 ] |
| Rank | Ranked higher |
Need to check in testing environment(s) before merging.
| Assignee | Ann Loraine [ aloraine ] |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11 [ 120, 121, 122 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25 [ 120, 121, 122, 123 ] |
| Rank | Ranked higher |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25 [ 120, 121, 122, 123 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9 [ 120, 121, 122, 123, 124 ] |
| Rank | Ranked higher |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9 [ 120, 121, 122, 123, 124 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Summer 3 2021 Jul 12 - Jul 23 [ 120, 121, 122, 123, 124, 125 ] |
| Rank | Ranked higher |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Summer 3 2021 Jul 12 - Jul 23 [ 120, 121, 122, 123, 124, 125 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9 [ 120, 121, 122, 123, 124 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9 [ 120, 121, 122, 123, 124 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6 [ 120, 121, 122, 123, 124, 229 ] |
| Assignee | Paige Kulzer [ pkulzer ] |
I've picked up this ticket to continue Chirag's work. His old commit to the BioViz code base can be found here: https://bitbucket.org/chirag06/bioviz/commits/d6c24d7c1b89fa58e534ce55dd0dbbcec6773e59
I have made these same changes in a new commit to fix the app store issue. Both Nowlan and I have tested locally using the documentation created from IGBF-4275 and confirmed that this works.
PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/185
Once this is merged, let's test if that fixed the Genome Dashboard button issue. If not, I will make a PR for the necessary changes in that repo.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
PR is merged and code is deployed to bioviz.org.
Ready for testing.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Attachment | genomeDashboard.png [ 18955 ] |
Noticed an issue with the Genome Dashboard when the user does not have IGB running and clicks View in IGB the Install IGB button appears oddly (see above image).
Ann Loraine Here's the PR to revert that commit so I can make further changes: https://bitbucket.org/lorainelab/bioviz/pull-requests/186
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
The new PR is merged and the code deployed to bioviz.org. Ready for the next steps!
attn: Paige Kulzer
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Paige Kulzer [ pkulzer ] |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6 [ 120, 121, 122, 123, 124, 229 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7 [ 120, 121, 122, 123, 124, 229, 230 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I have fixed that (Genome Versions > View in IGB >) Install IGB button on the Genome Dashboard page such that it now opens a new tab to bioviz.org/download.html as expected.
I have also created a branch in the BioViz repo for fixing the button coloring issue since the appstore repo and the genome dashboard repo both pull menu.css from there.
Genome Dashboard Branch: https://bitbucket.org/pkulzer-lorainelab/genome-dashboard/branch/IGBF-2850
BioViz Branch: https://bitbucket.org/pkulzer-lorainelab/bioviz/branch/IGBF-2850
Ready for review!
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Summary | Fix color for Install IGB button | Fix Install IGB button |
| Description |
When a user clicks on the "Install IGB" button on the App Store header, the button changes to an orange color.
Instead, the color behavior should match clicking the same button on the main page bioviz.org. Note that the same thing happens on the "IGB Genomes" page. There may be an issue with bootstrap versions? Please investigate. |
When a user clicks on the "Install IGB" button on the App Store header, the button changes to an orange color.
Instead, the color behavior should match clicking the same button on the main page bioviz.org. Note that the same thing happens on the "IGB Genomes" page. Furthermore, the "Install IGB" button that is accessed on this page by clicking "Genome Versions" > "View in IGB" does not route anywhere when clicked. There may be an issue with bootstrap versions? Please investigate. |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7 [ 120, 121, 122, 123, 124, 229, 230 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7, Fall 8 [ 120, 121, 122, 123, 124, 229, 230, 231 ] |
| Rank | Ranked higher |
Tested on Mac
Tested Genome Dashboard and App Store. Download IGB button appears correctly and on hover is the correct color of red.
Within the Genome Dashboard View in IGB Download IGB button correctly redirects to the Download.html location.
Ready for PR
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Story Points | 0.25 | 1 |
Genome Dashboard PR: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/30
BioViz PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/188
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Sprint | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7, Fall 8 [ 120, 121, 122, 123, 124, 229, 230, 231 ] | Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7, Fall 8, Fall 9 [ 120, 121, 122, 123, 124, 229, 230, 231, 232 ] |
| Rank | Ranked higher |
Update:
- I merged the Genome Dashboard PR.
- Atlassian showed an warning message on the target repository about how cross-workspace forks were going to be disabled.
- Since our Genome Dashboard repository is a fork of Sameer Shanbhag's repository, I decided to create an entirely new repository that is not a fork by pushing the repository's master branch to an all new repository inside the lorainelab space so that our code would not be a fork of anything.
- I updated the corresponding lines in the bioviz-playbooks ansible playbooks.
- I also made a new branch "main" and made that the default branch.
- I merged the change and deployed it to bioviz.org. The behavior looks OK.
Update:
- I merged the bioviz PR.
- I deployed the new code onto bioviz.org as usual.
Ready for testing.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested on Mac on the Firefox browser.
Genome Dashboard: Download IGB button appears correctly and on hover is the correct color of red. Clicking the button takes the user to the downloads page. When I clicked on View in IGB View in IGB the Install IGB button appears correctly and upon clicking opens a tab to the download page.
Note: The app store and Track Hub converter have not been redeployed so I was unable to test the Install IGB button color change for those pages.
| Assignee | Nowlan Freese [ nfreese ] | Ann Loraine [ aloraine ] |
I will re-deploy the Track Hub converter.
Update:
- I just now ran the ansible playbooks to re-deploy the track hub converter code on translate.bioviz.org
- Ready for testing
attn: Nowlan Freese
| Assignee | Ann Loraine [ aloraine ] |
Ann Loraine - I'm not seeing the change in translate.bioviz.org. It looks like it is still pulling an older menu.css file. I'm wondering if it is pulling it from a different branch/repo then the main branch of bioviz? What are the variables BIOVIZ_REPOSITORY and BIOVIZ_BRANCH set in the settings.ini?
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Paige Kulzer [ pkulzer ] |
App-Store is only importing menu.CSS file. Some of the CSS code is written in https://www.bioviz.org/css/style.css.