Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Spring 6 2021 May 31 - June 11, Summer 1 2021 Jun 14 - Jun 25, Summer 2 2021 Jun 28 - Jul 9, Fall 6, Fall 7, Fall 8, Fall 9

      Description

      When a user clicks on the "Install IGB" button on the App Store header, the button changes to an orange color.

      Instead, the color behavior should match clicking the same button on the main page bioviz.org.

      Note that the same thing happens on the "IGB Genomes" page. Furthermore, the "Install IGB" button that is accessed on this page by clicking "Genome Versions" > "View in IGB" does not route anywhere when clicked.

      There may be an issue with bootstrap versions? Please investigate.

        Attachments

          Activity

          Hide
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

          App-Store is only importing menu.CSS file. Some of the CSS code is written in https://www.bioviz.org/css/style.css.

          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - App-Store is only importing menu.CSS file. Some of the CSS code is written in https://www.bioviz.org/css/style.css .
          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - - edited PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/59/igbf-2850-move-button-related-style-to
          Hide
          ann.loraine Ann Loraine added a comment -

          Need to check in testing environment(s) before merging.

          Show
          ann.loraine Ann Loraine added a comment - Need to check in testing environment(s) before merging.
          Hide
          pkulzer Paige Kulzer (Inactive) added a comment - - edited

          I've picked up this ticket to continue Chirag's work. His old commit to the BioViz code base can be found here: https://bitbucket.org/chirag06/bioviz/commits/d6c24d7c1b89fa58e534ce55dd0dbbcec6773e59

          I have made these same changes in a new commit to fix the app store issue. Both Nowlan and I have tested locally using the documentation created from IGBF-4275 and confirmed that this works.

          PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/185

          Once this is merged, let's test if that fixed the Genome Dashboard button issue. If not, I will make a PR for the necessary changes in that repo.

          Show
          pkulzer Paige Kulzer (Inactive) added a comment - - edited I've picked up this ticket to continue Chirag's work. His old commit to the BioViz code base can be found here: https://bitbucket.org/chirag06/bioviz/commits/d6c24d7c1b89fa58e534ce55dd0dbbcec6773e59 I have made these same changes in a new commit to fix the app store issue. Both Nowlan and I have tested locally using the documentation created from IGBF-4275 and confirmed that this works. PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/185 Once this is merged, let's test if that fixed the Genome Dashboard button issue. If not, I will make a PR for the necessary changes in that repo.
          Hide
          ann.loraine Ann Loraine added a comment -

          PR is merged and code is deployed to bioviz.org.

          Ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - PR is merged and code is deployed to bioviz.org. Ready for testing.
          Hide
          nfreese Nowlan Freese added a comment -

          Noticed an issue with the Genome Dashboard when the user does not have IGB running and clicks View in IGB the Install IGB button appears oddly (see above image).

          Show
          nfreese Nowlan Freese added a comment - Noticed an issue with the Genome Dashboard when the user does not have IGB running and clicks View in IGB the Install IGB button appears oddly (see above image).
          Hide
          pkulzer Paige Kulzer (Inactive) added a comment - - edited

          Ann Loraine Here's the PR to revert that commit so I can make further changes: https://bitbucket.org/lorainelab/bioviz/pull-requests/186

          Show
          pkulzer Paige Kulzer (Inactive) added a comment - - edited Ann Loraine Here's the PR to revert that commit so I can make further changes: https://bitbucket.org/lorainelab/bioviz/pull-requests/186
          Hide
          ann.loraine Ann Loraine added a comment -

          The new PR is merged and the code deployed to bioviz.org. Ready for the next steps!

          attn: Paige Kulzer

          Show
          ann.loraine Ann Loraine added a comment - The new PR is merged and the code deployed to bioviz.org. Ready for the next steps! attn: Paige Kulzer
          Hide
          pkulzer Paige Kulzer (Inactive) added a comment - - edited

          I have fixed that (Genome Versions > View in IGB >) Install IGB button on the Genome Dashboard page such that it now opens a new tab to bioviz.org/download.html as expected.

          I have also created a branch in the BioViz repo for fixing the button coloring issue since the appstore repo and the genome dashboard repo both pull menu.css from there.

          Genome Dashboard Branch: https://bitbucket.org/pkulzer-lorainelab/genome-dashboard/branch/IGBF-2850
          BioViz Branch: https://bitbucket.org/pkulzer-lorainelab/bioviz/branch/IGBF-2850

          Ready for review!

          Show
          pkulzer Paige Kulzer (Inactive) added a comment - - edited I have fixed that (Genome Versions > View in IGB >) Install IGB button on the Genome Dashboard page such that it now opens a new tab to bioviz.org/download.html as expected. I have also created a branch in the BioViz repo for fixing the button coloring issue since the appstore repo and the genome dashboard repo both pull menu.css from there. Genome Dashboard Branch: https://bitbucket.org/pkulzer-lorainelab/genome-dashboard/branch/IGBF-2850 BioViz Branch: https://bitbucket.org/pkulzer-lorainelab/bioviz/branch/IGBF-2850 Ready for review!
          Hide
          nfreese Nowlan Freese added a comment -

          Tested on Mac
          Tested Genome Dashboard and App Store. Download IGB button appears correctly and on hover is the correct color of red.
          Within the Genome Dashboard View in IGB Download IGB button correctly redirects to the Download.html location.

          Ready for PR

          Show
          nfreese Nowlan Freese added a comment - Tested on Mac Tested Genome Dashboard and App Store. Download IGB button appears correctly and on hover is the correct color of red. Within the Genome Dashboard View in IGB Download IGB button correctly redirects to the Download.html location. Ready for PR
          Show
          pkulzer Paige Kulzer (Inactive) added a comment - Genome Dashboard PR: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/30 BioViz PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/188
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          Update:

          • I merged the Genome Dashboard PR.
          • Atlassian showed an warning message on the target repository about how cross-workspace forks were going to be disabled.
          • Since our Genome Dashboard repository is a fork of Sameer Shanbhag's repository, I decided to create an entirely new repository that is not a fork by pushing the repository's master branch to an all new repository inside the lorainelab space so that our code would not be a fork of anything.
          • I updated the corresponding lines in the bioviz-playbooks ansible playbooks.
          • I also made a new branch "main" and made that the default branch.
          • I merged the change and deployed it to bioviz.org. The behavior looks OK.
          Show
          ann.loraine Ann Loraine added a comment - - edited Update: I merged the Genome Dashboard PR. Atlassian showed an warning message on the target repository about how cross-workspace forks were going to be disabled. Since our Genome Dashboard repository is a fork of Sameer Shanbhag's repository, I decided to create an entirely new repository that is not a fork by pushing the repository's master branch to an all new repository inside the lorainelab space so that our code would not be a fork of anything. I updated the corresponding lines in the bioviz-playbooks ansible playbooks. I also made a new branch "main" and made that the default branch. I merged the change and deployed it to bioviz.org. The behavior looks OK.
          Hide
          ann.loraine Ann Loraine added a comment -

          Update:

          • I merged the bioviz PR.
          • I deployed the new code onto bioviz.org as usual.
          Show
          ann.loraine Ann Loraine added a comment - Update: I merged the bioviz PR. I deployed the new code onto bioviz.org as usual.
          Hide
          ann.loraine Ann Loraine added a comment -

          Ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - Ready for testing.
          Hide
          nfreese Nowlan Freese added a comment -

          Tested on Mac on the Firefox browser.

          Genome Dashboard: Download IGB button appears correctly and on hover is the correct color of red. Clicking the button takes the user to the downloads page. When I clicked on View in IGB View in IGB the Install IGB button appears correctly and upon clicking opens a tab to the download page.

          Note: The app store and Track Hub converter have not been redeployed so I was unable to test the Install IGB button color change for those pages.

          Show
          nfreese Nowlan Freese added a comment - Tested on Mac on the Firefox browser. Genome Dashboard: Download IGB button appears correctly and on hover is the correct color of red. Clicking the button takes the user to the downloads page. When I clicked on View in IGB View in IGB the Install IGB button appears correctly and upon clicking opens a tab to the download page. Note: The app store and Track Hub converter have not been redeployed so I was unable to test the Install IGB button color change for those pages.
          Hide
          ann.loraine Ann Loraine added a comment -

          I will re-deploy the Track Hub converter.

          Show
          ann.loraine Ann Loraine added a comment - I will re-deploy the Track Hub converter.
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          Update:

          • I just now ran the ansible playbooks to re-deploy the track hub converter code on translate.bioviz.org
          • Ready for testing

          attn: Nowlan Freese

          Show
          ann.loraine Ann Loraine added a comment - - edited Update: I just now ran the ansible playbooks to re-deploy the track hub converter code on translate.bioviz.org Ready for testing attn: Nowlan Freese
          Hide
          nfreese Nowlan Freese added a comment - - edited

          Ann Loraine - I'm not seeing the change in translate.bioviz.org. It looks like it is still pulling an older menu.css file. I'm wondering if it is pulling it from a different branch/repo then the main branch of bioviz? What are the variables BIOVIZ_REPOSITORY and BIOVIZ_BRANCH set in the settings.ini?

          https://bitbucket.org/lorainelab/hub-facade/src/9935e8ab1d616d44f7a42a96260421cc222f1a3b/igb_trackhub/api/apps.py?at=main#apps.py-10,13

          Show
          nfreese Nowlan Freese added a comment - - edited Ann Loraine - I'm not seeing the change in translate.bioviz.org. It looks like it is still pulling an older menu.css file. I'm wondering if it is pulling it from a different branch/repo then the main branch of bioviz? What are the variables BIOVIZ_REPOSITORY and BIOVIZ_BRANCH set in the settings.ini? https://bitbucket.org/lorainelab/hub-facade/src/9935e8ab1d616d44f7a42a96260421cc222f1a3b/igb_trackhub/api/apps.py?at=main#apps.py-10,13

            People

            • Assignee:
              pkulzer Paige Kulzer (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: