Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Sep10
Description
Please modify the interface to match these slides: https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Or, propose an even better design.
Why the changes are needed:
Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Also, the text box component is normally used for data entry, but users cannot edit the link. It is created for them, not edited.
Change this so that a text box is not used. See slides.
There are some other issues, as well:
- The heading text "Public Link:" is blue, making it look like it is also a hyperlink, but it is not.
- The file name and instructions to user are shown in italics. What is the meaning of italics?
- When addressing the user or explaining the interface instructions, use plain text font. It's fine to use italics for file names, I guess, but it seems weird.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2376 [ 18533 ] |
| Description |
Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more.
Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application. Please modify the interface so that: * The entire text of the link is visible to the user, splitting on "/" characters when the link is too long to fit on a single line. * Do not display the link using a text entry box, since the user can never edit this text. See attached example from a similar interface (from AWS) for an example of what should be done instead to display the link. |
Please modify the interface to match the attached slides, or propose an even better design.
Some issues: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application. There are some other issues, as well: * The text "Public Link:" is blue, making it look like it is itself a hyperlink, but it is not. * The file name and instructions to user are shown in italics, making the use of italics nonsensical. When addressing the user or giving instructions, use plain text font. * The entire text of the link should be visible to the user, splitting on "/" characters when the link is too long to fit on a single line. * Do not display the link using a text entry box, since the user can never edit this text. |
| Description |
Please modify the interface to match the attached slides, or propose an even better design.
Some issues: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application. There are some other issues, as well: * The text "Public Link:" is blue, making it look like it is itself a hyperlink, but it is not. * The file name and instructions to user are shown in italics, making the use of italics nonsensical. When addressing the user or giving instructions, use plain text font. * The entire text of the link should be visible to the user, splitting on "/" characters when the link is too long to fit on a single line. * Do not display the link using a text entry box, since the user can never edit this text. |
Please modify the interface to match these slides: https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Or, propose an even better design. Some issues: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application. There are some other issues, as well: * The text "Public Link:" is blue, making it look like it is itself a hyperlink, but it is not. * The file name and instructions to user are shown in italics, making the use of italics nonsensical. When addressing the user or giving instructions, use plain text font. * The entire text of the link should be visible to the user, splitting on "/" characters when the link is too long to fit on a single line. * Do not display the link using a text entry box, since the user can never edit this text. |
| Description |
Please modify the interface to match these slides: https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Or, propose an even better design. Some issues: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application. There are some other issues, as well: * The text "Public Link:" is blue, making it look like it is itself a hyperlink, but it is not. * The file name and instructions to user are shown in italics, making the use of italics nonsensical. When addressing the user or giving instructions, use plain text font. * The entire text of the link should be visible to the user, splitting on "/" characters when the link is too long to fit on a single line. * Do not display the link using a text entry box, since the user can never edit this text. |
Please modify the interface to match these slides: https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Or, propose an even better design. Some issues: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application, which is inconvenient. It also makes it hard for us to check the link behavior. For example, it's currently difficult to see what happens if a link is created, deleted, and then created again for the same file. Does the link text get re-used? Change how this looks so that the entire text is visible, shown on multiple lines if required, splitting at "/" characters. There are some other issues, as well: * The text "Public Link:" is blue, making it look like it is also a hyperlink, but it is not. * The file name and instructions to user are shown in italics, making the use of italics nonsensical. When addressing the user or giving instructions, use plain text font. * Do not display the link using a text entry box, since the user can never edit this text. |
| Summary | Fix display of public link | Fix some minor issues with Manage Link interface |
| Description |
Please modify the interface to match these slides: https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Or, propose an even better design. Some issues: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Normally with this type of display, you can expand the text are to see more or click on the text area and move the cursor to the end of the line of text. However, with this interface, the only way to actually see the text of the link is to click the "copy" button and then paste it into a different application, which is inconvenient. It also makes it hard for us to check the link behavior. For example, it's currently difficult to see what happens if a link is created, deleted, and then created again for the same file. Does the link text get re-used? Change how this looks so that the entire text is visible, shown on multiple lines if required, splitting at "/" characters. There are some other issues, as well: * The text "Public Link:" is blue, making it look like it is also a hyperlink, but it is not. * The file name and instructions to user are shown in italics, making the use of italics nonsensical. When addressing the user or giving instructions, use plain text font. * Do not display the link using a text entry box, since the user can never edit this text. |
Please modify the interface to match these slides: https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Or, propose an even better design. Why the changes are needed: Currently in BioViz Connect, the "manage link" right panel display shows a text box that reports the public link, but it only shows the first 20 characters or so, and there is no way to expand the text area to see more. Also, the text box component is normally used for data entry, but users cannot edit the link. It is created for them, not edited. Change this so that a text box is not used. See slides. There are some other issues, as well: * The heading text "Public Link:" is blue, making it look like it is also a hyperlink, but it is not. * The file name and instructions to user are shown in italics. What is the meaning of italics? * When addressing the user or explaining the interface instructions, use plain text font. It's fine to use italics for file names, I guess, but it seems weird. |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Ann Loraine [ aloraine ] |
Deployed to bvctest3.bioviz.org
Change requests:
Change request 1:
Modify how the URL is displayed so that wrapping is done on "/" characters and so that the link fits into the available space. This means you have to over-rule the browser's native handling of text. We faced an identical problem with the Genome Dashboard, in which we needed to wrap on "_" (underscore) characters. See this commit for one way to do it: https://bitbucket.org/lorainelab/genome-dashboard/commits/2ef4c37b68fc042b2b7645c20e410fbe202c624c
Change request 2:
Replace the green and orange circles with a question mark icon. Make it look and behave like the questions marks on this page: https://apps.bioviz.org/.
When users hover the mouse over the question mark, they should see:
"Anyone with the public link can view or download this file." - when the link is public
"No-one can download this file. Previous public links no longer work." - when the link is destroyed or never was made.
Change request 3:
Modify the text shown below the buttons to read:
"Note: If you remove the link, no-one will be able to use it to download or view your file in IGB. " when button is red and reads "Remove Link".
"Note: If you create a link, anyone can use it to download or view your file in IGB." when button is blue and reads "Create Public Link"
Change request 4:
Change button text "Create Public Link" to "Create Link"
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Re: Change request 2: Decided it would be better to move the tooltip explaining why the link is needed next to the title "Manage Link". Displayed "public" and "private" in bold font to make these words more prominent.
Re: Change request 3: Done, with slight re-wording. Key idea here is that we address the user directly, telling them exactly what will happen if they click the button.
Re: Change request 4: Not doing this one. Leaving the interface as-is for now as changing the wording seems to mess up the functionality.
Re: Change request 1: This one is hard! Leaving this for the next attempt. But it needs to be done because the text is not yet rendered properly, as it is spilling out of the box and out of the browser window.
Branch: https://bitbucket.org/aloraine/bioviz-connect/branch/IGBF-2921
See slide 3 for above new version:
https://www.dropbox.com/s/2i45ivwfzfduh4l/ManageLink.pptx?dl=0
Submitting PR.
| Assignee | Ann Loraine [ aloraine ] | Nowlan Freese [ nfreese ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Deployed to https://bvctest3.bioviz.org.
Moving back to "To-Do" to address Change Request 1 (see previous comment).
Inventory:
[bvc_hosts]
bvctest3 ansible_host=3.216.236.83 domain=bvctest3.bioviz.org secret_key=[redacted]
[bvc_hosts:vars]
ansible_ssh_common_args="-o StrictHostKeyChecking=no"
ansible_python_interpreter=/usr/bin/python3
ansible_ssh_user=ubuntu
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
Deployed to bvctest3.bioviz.org
Please add a comment to this ticket that tells me what has changed so that I will know what to test in the new version.
attn: Karthik Raveendran and Nowlan Freese
Moving to "To-Do" pending further information.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] | Karthik Raveendran [ karthik ] |
I have reviewed the new interface. Change Request 1 is done. Moving to closed.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Changes made in this commit are:
1) URL word-wrap was implemented. In Firefox, a URL is wrapped at the forward-slashes but in Chrome, a URL is wrapped at the hyphens as well.
2) Copy button was moved to the end of the URL from the "Public Link: " title area.
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
Issues noted:
- During testing, we noticed that if a user removes a public link, the Manage Link interface displays the message "Not Available" as a hyperlinked text.
Request: Do not show the "Not Available" text as this will likely make the interface more usable and also simplify the code.
- Sometimes the Note does not appear in the Manage Link interface.
Note: Sometimes it takes time for a public link to become private after the user clicks the "Remove Public Link" button. We discussed adding some kind of notice to the user letting them know that there might be a slight delay after removing a link before a file becomes inaccessible to the public. Suggestion: Develop some testing code that will test the accessibility of the file following removal of public access to better understand this issue.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Submitted pull request Commit
This commit addresses:
a) Removal of 'Not Available' text from public link.
b) The Note not appearing in the Manage link interface.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Sprint | Fall 1 2021 Aug 16 - Aug 27 [ 127 ] | Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Aug 10 [ 127, 128 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
The code looks fine, but I had some concerns. Please see comment in the code.
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Submitted pull request commit
This commit addresses:
a) Remove and add the entire public link div during toggle
b) Remove onclick function on the copy button when it is not displayed
Deployed to https://bvctest3.bioviz.org and ready for testing.
Styling change request:
Please add vertical whitespace between the button and the Note below it. It should be the same vertical distance as the space separating the top of the button and the "is currently public" line above it.
attn: Karthik Raveendran
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Submitted pull request commit
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed and checked for styling change. It is complete. Moving to Done.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Karthik Raveendran [ karthik ] |
Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/247/igbf-2921-fix-minor-issues-with-manage?link_source=email