Test results:

I am getting expected output as per the test protocol after running below URL's

https://bvctest6.bioviz.org/ - IGB buttons are showing. Please see "View in IGB green button" screenshot.
https://bvctest6.bioviz.org/SyncAppDataToBioViz/ - Please see "TypeError" screenshot.
https://bvctest6.bioviz.org/ - IGB buttons are still showing. Please see "View in IGB green button" screenshot.
https://bvctest6.bioviz.org/SyncAppDataToBioViz/?accesstoken=totalgarbage - Please see 'Auth error' screenshot.
https://bvctest6.bioviz.org/ - IGB buttons are still showing. Please see "View in IGB green button" screenshot.

Closing the ticket.

The test server needed to be "turned on." All our test servers and other development servers are shut down at night and need to be turned on manually using the AWS interface.

Test Observations:

I tried running below bcxtest6 URL'S but all are unreachable.

• https://bvctest6.bioviz.org/ - to check if the View in IGB buttons are showing)
• https://bvctest6.bioviz.org/SyncAppDataToBioViz/ - should return a TypeError
• https://bvctest6.bioviz.org/ - to check if the View in IGB buttons are still showing
• https://bvctest6.bioviz.org/SyncAppDataToBioViz/?accesstoken=totalgarbage - should return a Auth error
• https://bvctest6.bioviz.org/ - to check if the View in IGB buttons are still showing

I am thinking its a server issue.
Karthik Raveendran Please check.

Can test new functionality using testing host: https://bvctest6.bioviz.org
For background, testers can read latest draft of the bioviz-connect paper: https://www.biorxiv.org/content/10.1101/2020.05.15.098533v4

Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/260/igbf-2951-handle-and-fix?link_source=email

PR Submitted

Thank you for making the changes. Please submit PR.

Testing protocol:
If the branch is deployed in, let's say, bvctest6 (git pull origin IGBF-2951), then in a browser try running urls:
a) https://bvctest6.bioviz.org/ - to check if the View in IGB buttons are showing)
b) https://bvctest6.bioviz.org/SyncAppDataToBioViz/ - should return a TypeError
c) https://bvctest6.bioviz.org/ - to check if the View in IGB buttons are still showing
d) https://bvctest6.bioviz.org/SyncAppDataToBioViz/?accesstoken=totalgarbage - should return a Auth error
e) https://bvctest6.bioviz.org/ - to check if the View in IGB buttons are still showing

Pushed changes to repo. Commit in branch IGBF-2951

Changes in commit:
1) TypeError is handled in case no accesstoken is passed separately from other exceptions.
2) Authorization error is handled if the accesstoken is expired.
3) All other exceptions will be returned.

Moving to First Level Review

KR & AL looked at code together and KR will make some modifications, focusing on improving exception handling and reporting more useful information in the logs and to the user via the web browser. Please see comment on the PR.

Submitted PR

Added a try-except to catch NoneType errors that occur when accesstoken parameter is not present or if accesstoken is not active

The challenge is that when no data is returned the response is still 200 OK. It seems like we can only go by the length of the json returned or if any json is returned at all which may not be ideal.

I was able to recreate the "View in IGB button disappears" issue by calling the SyncAppDataToBioviz endpoint without the accesstoken parameter (https://bvctest6.bioviz.org/SyncAppDataToBioViz/).
Despite getting no data from this call, the database gets updated and all tables are set to empty which is causing this issue.

Function DeleteAppData is called even before the API to get the app data is requested.
Code track:

• SyncAppDataToBioViz(views.py) -> getLatestApps(ManageAppDetails.py) -> DeleteAppData(ManageAppDetails.py)

Solution: Need to add a check before the deleting all tables and add an empty set