Details
-
Type:
New Feature
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:Fall 4 2022 Oct 10, Fall 5 2022 Oct 24
Description
Situation: When a user searches for a file or folder in BioViz Connect the results are displayed in the main view. However, there is currently no way for the user to select a file or folder and then immediately navigate to the location of that file or folder.
Task: Implement a way for a user to quickly navigate to the location of a file or folder from the search results. This could include a right-click menu option "Show in Enclosing Folder" when searching that would allow the user to then quickly navigate to the location of that file or folder.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2376 [ 18533 ] |
| Sprint | Fall 3 2022 Sep 26 [ 155 ] | Fall 4 2022 Oct 10 [ 156 ] |
| Rank | Ranked higher |
| Assignee | Karthik Raveendran [ karthik ] |
| Issue Type | Task [ 3 ] | New Feature [ 2 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested on bvctest3.bioviz.org using the nowlanf account on macOS 12.6 with FireFox browser 105.0.3.
Works correctly for Home, Shared, and Community folders.
Issue with special characters:
Searching for normalName.bedGraph and then clicking the arrow/button attempts to take me to:
https://bvctest3.bioviz.org/base/#/iplant/home/nowlanf/stuff_!@#$%^&*%20space%20_stuff.bedGraph/silly%20name%20!@#$%^&*%20this%20name%20is%20silly%20_stuff.bedGraph/
but the actual address should be:
https://bvctest3.bioviz.org/base/#/iplant/home/nowlanf/stuff_!%40%23%24%25%5E%26*%20space%20_stuff.bedGraph/silly%20name%20!%40%23%24%25%5E%26*%20this%20name%20is%20silly%20_stuff.bedGraph
So it looks like some part of the special characters are not being encoded correctly.
Also, if I try to do a search using special characters such as
the search bar breaks and I am logged out. I'm pretty sure we had addressed special characters in the search bar before, so maybe there is a regression?stuff_!@#$%^&_ space _stuff
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
1) Add tooltip to the button
2) Add indication that the icon is clickable
3) Encode path
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
Changes above is done. See commit
| Sprint | Fall 4 2022 Oct 10 [ 156 ] | Fall 4 2022 Oct 10, Fall 5 2022 Oct 24 [ 156, 157 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Changes look good.
Ready for pull request.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Merged
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Next step is to run the playbooks for bvctest3/7 and test the changes.
Playbooks have updated the code on bvctest3/7 as requested. Ready for testing.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
There's a slight difference in how the encoding of the URI is occurring. We are investigating.
| Description |
Situation: When a user searches for a file or folder in BioViz Connect the results are displayed in the main view. However, there is currently no way for the user to select a file or folder and then immediately navigate to the location of that file or folder.
Task: Implement a way for a user to quickly navigate to the location of a file or folder from the search results. This could include a right-click menu option "Show in Enclosing Folder" when searching that would allow the user to then quickly navigate to the location of that file or folder. |
Situation: When a user searches for a file or folder in BioViz Connect the results are displayed in the main view. However, there is currently no way for the user to select a file or folder and then immediately navigate to the location of that file or folder.
Task: Implement a way for a user to quickly navigate to the location of a file or folder from the search results. This could include a right-click menu option "Show in Enclosing Folder" when searching that would allow the user to then quickly navigate to the location of that file or folder. Note: Icon for redirecting to the location of the searched item is replaced by the folder path itself in this task |
| Description |
Situation: When a user searches for a file or folder in BioViz Connect the results are displayed in the main view. However, there is currently no way for the user to select a file or folder and then immediately navigate to the location of that file or folder.
Task: Implement a way for a user to quickly navigate to the location of a file or folder from the search results. This could include a right-click menu option "Show in Enclosing Folder" when searching that would allow the user to then quickly navigate to the location of that file or folder. Note: Icon for redirecting to the location of the searched item is replaced by the folder path itself in this task |
Situation: When a user searches for a file or folder in BioViz Connect the results are displayed in the main view. However, there is currently no way for the user to select a file or folder and then immediately navigate to the location of that file or folder.
Task: Implement a way for a user to quickly navigate to the location of a file or folder from the search results. This could include a right-click menu option "Show in Enclosing Folder" when searching that would allow the user to then quickly navigate to the location of that file or folder. |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Pull request for this ticket was included as part of IGBF-3205: https://bitbucket.org/nfreese/bioviz-connect/pull-requests/280/igbf-3205
This works great, I really like the design that Karthik Raveendran came up with.
Closing ticket.
| Assignee | Karthik Raveendran [ karthik ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
I added a button next to the file/folder names in the search results to redirect. Nowlan Freese, could you check if this works?. See commit