Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3178

Go to file/folder location from search in BioViz Connect

    Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Situation: When a user searches for a file or folder in BioViz Connect the results are displayed in the main view. However, there is currently no way for the user to select a file or folder and then immediately navigate to the location of that file or folder.

      Task: Implement a way for a user to quickly navigate to the location of a file or folder from the search results. This could include a right-click menu option "Show in Enclosing Folder" when searching that would allow the user to then quickly navigate to the location of that file or folder.

        Attachments

          Activity

          Hide
          karthik Karthik Raveendran added a comment -

          I added a button next to the file/folder names in the search results to redirect. Nowlan Freese, could you check if this works?. See commit

          Show
          karthik Karthik Raveendran added a comment - I added a button next to the file/folder names in the search results to redirect. Nowlan Freese , could you check if this works?. See commit
          Show
          karthik Karthik Raveendran added a comment - PR submitted. https://bitbucket.org/nfreese/bioviz-connect/pull-requests/274/igbf-3178-add-redirect-button-to-search
          Hide
          nfreese Nowlan Freese added a comment -

          Merged

          Show
          nfreese Nowlan Freese added a comment - Merged
          Hide
          nfreese Nowlan Freese added a comment -

          Tested on bvctest3.bioviz.org using the nowlanf account on macOS 12.6 with FireFox browser 105.0.3.

          Works correctly for Home, Shared, and Community folders.

          Issue with special characters:
          Searching for normalName.bedGraph and then clicking the arrow/button attempts to take me to:

          https://bvctest3.bioviz.org/base/#/iplant/home/nowlanf/stuff_!@#$%^&*%20space%20_stuff.bedGraph/silly%20name%20!@#$%^&*%20this%20name%20is%20silly%20_stuff.bedGraph/

          but the actual address should be:

          https://bvctest3.bioviz.org/base/#/iplant/home/nowlanf/stuff_!%40%23%24%25%5E%26*%20space%20_stuff.bedGraph/silly%20name%20!%40%23%24%25%5E%26*%20this%20name%20is%20silly%20_stuff.bedGraph

          So it looks like some part of the special characters are not being encoded correctly.

          Also, if I try to do a search using special characters such as

          stuff_!@#$%^&_ space _stuff

          the search bar breaks and I am logged out. I'm pretty sure we had addressed special characters in the search bar before, so maybe there is a regression?

          Show
          nfreese Nowlan Freese added a comment - Tested on bvctest3.bioviz.org using the nowlanf account on macOS 12.6 with FireFox browser 105.0.3. Works correctly for Home, Shared, and Community folders. Issue with special characters: Searching for normalName.bedGraph and then clicking the arrow/button attempts to take me to: https: //bvctest3.bioviz.org/base/#/iplant/home/nowlanf/stuff_!@#$%^&*%20space%20_stuff.bedGraph/silly%20name%20!@#$%^&*%20this%20name%20is%20silly%20_stuff.bedGraph/ but the actual address should be: https: //bvctest3.bioviz.org/base/#/iplant/home/nowlanf/stuff_!%40%23%24%25%5E%26*%20space%20_stuff.bedGraph/silly%20name%20!%40%23%24%25%5E%26*%20this%20name%20is%20silly%20_stuff.bedGraph So it looks like some part of the special characters are not being encoded correctly. Also, if I try to do a search using special characters such as stuff_!@#$%^&_ space _stuff the search bar breaks and I am logged out. I'm pretty sure we had addressed special characters in the search bar before, so maybe there is a regression?
          Hide
          karthik Karthik Raveendran added a comment - - edited

          1) Add tooltip to the button
          2) Add indication that the icon is clickable
          3) Encode path

          Show
          karthik Karthik Raveendran added a comment - - edited 1) Add tooltip to the button 2) Add indication that the icon is clickable 3) Encode path
          Hide
          karthik Karthik Raveendran added a comment -

          Changes above is done. See commit

          Show
          karthik Karthik Raveendran added a comment - Changes above is done. See commit
          Hide
          nfreese Nowlan Freese added a comment -

          Changes look good.

          Ready for pull request.

          Show
          nfreese Nowlan Freese added a comment - Changes look good. Ready for pull request.
          Show
          karthik Karthik Raveendran added a comment - PR Submitted. https://bitbucket.org/nfreese/bioviz-connect/pull-requests/277/igbf-3178-add-tooltip-and-encode-url-for
          Hide
          nfreese Nowlan Freese added a comment -

          Merged

          Show
          nfreese Nowlan Freese added a comment - Merged
          Hide
          nfreese Nowlan Freese added a comment -

          Next step is to run the playbooks for bvctest3/7 and test the changes.

          Show
          nfreese Nowlan Freese added a comment - Next step is to run the playbooks for bvctest3/7 and test the changes.
          Hide
          ann.loraine Ann Loraine added a comment -

          Playbooks have updated the code on bvctest3/7 as requested. Ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - Playbooks have updated the code on bvctest3/7 as requested. Ready for testing.
          Hide
          nfreese Nowlan Freese added a comment -

          There's a slight difference in how the encoding of the URI is occurring. We are investigating.

          Show
          nfreese Nowlan Freese added a comment - There's a slight difference in how the encoding of the URI is occurring. We are investigating.
          Hide
          nfreese Nowlan Freese added a comment -

          Pull request for this ticket was included as part of IGBF-3205: https://bitbucket.org/nfreese/bioviz-connect/pull-requests/280/igbf-3205

          Show
          nfreese Nowlan Freese added a comment - Pull request for this ticket was included as part of IGBF-3205 : https://bitbucket.org/nfreese/bioviz-connect/pull-requests/280/igbf-3205
          Hide
          nfreese Nowlan Freese added a comment -

          This works great, I really like the design that Karthik Raveendran came up with.

          Closing ticket.

          Show
          nfreese Nowlan Freese added a comment - This works great, I really like the design that Karthik Raveendran came up with. Closing ticket.

            People

            • Assignee:
              karthik Karthik Raveendran
              Reporter:
              nfreese Nowlan Freese
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: