Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 6 2022 Nov 7
Description
Situation: When using the right-click menu option in Community or Shared folders the Delete and Cut menu options are available even if the user does not have own/write permissions.
Task: Gray out the Delete and Cut right-menu options when the user does not have own/write permissions for files and folders in the Community or Shared folders. Note that this behavior seems to have already been implemented for Rename.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2376 [ 18533 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Merged
| Story Points | 1 | 0.25 |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Story Points | 0.25 | 0.5 |
New code is deployed. https://bvctest3.bioviz.org is up to date.
The cut/delete options are present in home folder, I go to community and they are grayed out, i go to shared and they are grayed out, and then if I go back to Home they are still grayed out (they should not be grayed out in Home).
If I refresh the page they come back as an option.
Rename seems to work correctly.
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
Changes made. PR submitted https://bitbucket.org/nfreese/bioviz-connect/pull-requests/284/igbf-3220-reset-pop-up-menu-options-for
I logged into bvctest3 and right-clicked on: gt30w140n90_oregon.tif, located in https://bvctest3.bioviz.org/base/#/iplant/home/shared/aegis/Spatial-bootcamp/basics/raster (a Community folder).
All options were grayed out, indicating my user lacks permission to execute those functions as I am not the owner of that file.
The only option that seems like it ought to also be grayed out but wasn't was "Manage Link," which may be the expected behavior at this time due to the fact that the "manage link" CyVerse endpoint is not properly working right now?
Merged
For the above comment by Dr. [~aloraine], all though the user cannot change anything in the Manage Link, the user may want to see what the status of the link is i.e. whether it is public or not. Which is why, I think, we do not gray out the option in the pop-up menu but the create public link button is disabled so the user cannot change anything.
Ok - that sounds good to me!
| Status | To-Do [ 10305 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Karthik Raveendran [ karthik ] | Nowlan Freese [ nfreese ] |
New code deployed to https://bvctest3.bioviz.org.
Working correctly.
Closing ticket.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
PR Submitted. https://bitbucket.org/nfreese/bioviz-connect/pull-requests/283/igbf-3220-gray-out-right-click-menu