Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 6 2022 Nov 7
Description
Situation: Deleting a folder in BioViz Connect caused the main panel to get caught in an infinite ouroboros.
Task: Fix the issue so that deleting a folder does not cause an infinite ouroboros.
Attachments
Activity
I'm not sure of the exact steps to reproduce, but I had just done the following in the specified order as part of creating the release testing:
- Create the folder.
- Cut/paste a file into the folder.
- Cut/paste the file out of the folder.
- Rename the folder.
- Delete the folder.
I had to log out and log back in to clear the issue.
I'm wondering if something is going on with the renaming of the folder followed by trying to delete it?
The issue occurs when the folder is renamed and then tried to be deleted because the rename list (that holds the list of filenames scheduled to be renamed) is compared against the all filenames with rename badges. Once deleted these rows does not exist and that returns an undefined value. Attempting convert undefined to string leads to the error that is thrown. While fixing the error, another issue was observed. During deletion, if the query response is a 403 Forbidden, that error is not handled. It was not a blocker for the user but UI acted slightly weird. The following commit handles that error as well.
The issue has been resolved and pushed. See commit
Updated on bvctest3.bioviz.org.
Testing on bvctest3.bioviz.org
Steps:
- Create folder.
- Rename folder.
- Refresh web browser after waiting for ~10 seconds so that the new folder name appears.
- Delete the folder.
- Refresh web browser after waiting for ~10 seconds, the folder has been deleted, no errors in the console.
Working correctly, closing ticket.
Error in console:
Uncaught TypeError: $(...).attr(...) is undefined imposeRenameUI https://connect.bioviz.org/static/bioviz_connect/js/dropdownMenu.js:359 interpretData https://connect.bioviz.org/static/bioviz_connect/js/tableOperations.js:245 success https://connect.bioviz.org/static/bioviz_connect/js/cyverse.js:412 jQuery 4 c fireWith l o