Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3222

Error when deleting folders in BioViz Connect

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Situation: Deleting a folder in BioViz Connect caused the main panel to get caught in an infinite ouroboros.

      Task: Fix the issue so that deleting a folder does not cause an infinite ouroboros.

        Attachments

          Activity

          nfreese Nowlan Freese created issue -
          nfreese Nowlan Freese made changes -
          Field Original Value New Value
          Epic Link IGBF-2376 [ 18533 ]
          Hide
          nfreese Nowlan Freese added a comment -

          Error in console:

          Uncaught TypeError: $(...).attr(...) is undefined
              imposeRenameUI https://connect.bioviz.org/static/bioviz_connect/js/dropdownMenu.js:359
              interpretData https://connect.bioviz.org/static/bioviz_connect/js/tableOperations.js:245
              success https://connect.bioviz.org/static/bioviz_connect/js/cyverse.js:412
              jQuery 4
                  c
                  fireWith
                  l
                  o
          
          Show
          nfreese Nowlan Freese added a comment - Error in console: Uncaught TypeError: $(...).attr(...) is undefined imposeRenameUI https: //connect.bioviz.org/ static /bioviz_connect/js/dropdownMenu.js:359 interpretData https: //connect.bioviz.org/ static /bioviz_connect/js/tableOperations.js:245 success https: //connect.bioviz.org/ static /bioviz_connect/js/cyverse.js:412 jQuery 4 c fireWith l o
          Hide
          nfreese Nowlan Freese added a comment - - edited

          I'm not sure of the exact steps to reproduce, but I had just done the following in the specified order as part of creating the release testing:

          1. Create the folder.
          2. Cut/paste a file into the folder.
          3. Cut/paste the file out of the folder.
          4. Rename the folder.
          5. Delete the folder.

          I had to log out and log back in to clear the issue.

          I'm wondering if something is going on with the renaming of the folder followed by trying to delete it?

          Show
          nfreese Nowlan Freese added a comment - - edited I'm not sure of the exact steps to reproduce, but I had just done the following in the specified order as part of creating the release testing: Create the folder. Cut/paste a file into the folder. Cut/paste the file out of the folder. Rename the folder. Delete the folder. I had to log out and log back in to clear the issue. I'm wondering if something is going on with the renaming of the folder followed by trying to delete it?
          karthik Karthik Raveendran made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Hide
          karthik Karthik Raveendran added a comment -

          The issue occurs when the folder is renamed and then tried to be deleted because the rename list (that holds the list of filenames scheduled to be renamed) is compared against the all filenames with rename badges. Once deleted these rows does not exist and that returns an undefined value. Attempting convert undefined to string leads to the error that is thrown. While fixing the error, another issue was observed. During deletion, if the query response is a 403 Forbidden, that error is not handled. It was not a blocker for the user but UI acted slightly weird. The following commit handles that error as well.
          The issue has been resolved and pushed. See commit

          Show
          karthik Karthik Raveendran added a comment - The issue occurs when the folder is renamed and then tried to be deleted because the rename list (that holds the list of filenames scheduled to be renamed) is compared against the all filenames with rename badges. Once deleted these rows does not exist and that returns an undefined value. Attempting convert undefined to string leads to the error that is thrown. While fixing the error, another issue was observed. During deletion, if the query response is a 403 Forbidden, that error is not handled. It was not a blocker for the user but UI acted slightly weird. The following commit handles that error as well. The issue has been resolved and pushed. See commit
          karthik Karthik Raveendran made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          karthik Karthik Raveendran made changes -
          Assignee Karthik Raveendran [ karthik ]
          Show
          nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/287/igbf-3222-fix-error-when-deleting-folders
          nfreese Nowlan Freese made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          nfreese Nowlan Freese made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          nfreese Nowlan Freese made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          nfreese Nowlan Freese made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          nfreese Nowlan Freese made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Updated on bvctest3.bioviz.org.

          Show
          ann.loraine Ann Loraine added a comment - Updated on bvctest3.bioviz.org.
          nfreese Nowlan Freese made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          nfreese Nowlan Freese made changes -
          Assignee Nowlan Freese [ nfreese ]
          Hide
          nfreese Nowlan Freese added a comment -

          Testing on bvctest3.bioviz.org
          Steps:

          1. Create folder.
          2. Rename folder.
          3. Refresh web browser after waiting for ~10 seconds so that the new folder name appears.
          4. Delete the folder.
          5. Refresh web browser after waiting for ~10 seconds, the folder has been deleted, no errors in the console.

          Working correctly, closing ticket.

          Show
          nfreese Nowlan Freese added a comment - Testing on bvctest3.bioviz.org Steps: Create folder. Rename folder. Refresh web browser after waiting for ~10 seconds so that the new folder name appears. Delete the folder. Refresh web browser after waiting for ~10 seconds, the folder has been deleted, no errors in the console. Working correctly, closing ticket.
          nfreese Nowlan Freese made changes -
          Assignee Nowlan Freese [ nfreese ] Karthik Raveendran [ karthik ]
          nfreese Nowlan Freese made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

            People

            • Assignee:
              karthik Karthik Raveendran
              Reporter:
              nfreese Nowlan Freese
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: