Libraries updated. See commit

It seems like IntelliJ is adding version to the child pom and removing the scope. The version should be supplied by the parent pom, I do not think we should/need to specify version in the child poms. Scope is still needed as far as I know and should not be removed.

Unclear why IntelliJ is making these changes, do not recommend pull request for the time being.

To complete this ticket:

• Review and check that the parent pom lists up-to-date correct artifact versions.
• Compare to versions listed in the Description above.
• Check the child POMs to ensure that the parent POM is being referenced.

Since NF did the work, Karthik Raveendran should review, doing the 3 tasks in the preceding comment.

In regards to child POMs specifying version:

• The core/igb/pom.xml specifies a version for <artifactId>git-commit-id-plugin</artifactId>
  • UPDATE - This artifact only occurs in this location and does not appear in parent pom. Newest version would be 4.9.10
• The core/menu-api/pom.xml specifies a version for <artifactId>maven-javadoc-plugin</artifactId>
  • UPDATE - This artifact is specified in the parent pom. Can most likely remove the version from menu-api/pom.xml
    • It is unclear to me if the version is inherited from the parent pom, as the artifact is not within the dependencyManagement section of the parent pom. Leaving as is for now, but will need to update both versions on the 3275 branch.
• The core/shared-lib-wrapper/pom.xml specifies a version for <artifactId>org.lorainelab.igb.error.reporter.api</artifactId>
  • UPDATE - This artifact is specified in the parent pom. Can most likely remove the version from shared-lib-wrapper/pom.xml
    • Leaving this as it is for now as it is an IGB specific API and there is no newer version.
• The core/taglets/pom.xml specifies a version for <artifactId>tools</artifactId>
  • UPDATE - This artifact only occurs in this location and does not appear in parent pom. This artifact specifies version 1.8 which according to this stackoverflow may not be correct for Java 11: https://stackoverflow.com/questions/55207885/could-not-find-artifact-com-suntoolsjar0/55207956#55207956
    • This issue will be further investigated in IGBF-3312
• The main/pom.xml specifies a version for <artifactId>maven-antrun-plugin</artifactId> and <artifactId>install4j-maven-plugin</artifactId>
  • UPDATE - The maven-antrun-plugin is specified in the parent pom, can most likely remove the version from main/pom.xml.
    • It is unclear to me if the version is inherited from the parent pom, as the artifact is not within the dependencyManagement section of the parent pom. Leaving as is for now, but will need to update both versions on the 3275 branch.
  • UPDATE - The install4j-maven-plugin only occurs in this location and does not appear in parent pom. Newest version would be 1.1.2

Most libraries are up to date or close to the latest version (latest version is released too recently and may be unstable). JDOM, however, seems to be significantly behind.

Apache Commons Compress: Up to date (1.22.0)
Apache Commons IO: Up to date (2.11.0)
Apache Commons Lang: Up to date (3.12.0)
Apache Commons Net: Up to date (3.9.0)
Guava: Up to date (31.1)
JUnit: Up to date (4.13.2)
MiGLayout Core: Up to date (11.0)
MiGLayout Swing: Up to date(11.0)
SLF4J API Module: Up to date (2.0.6)
SwingX Complete: Up to date(1.6.5)
Apache Commons CSV: 1.9.0 (1.10.0 is available)
Apache Felix Main: 7.0.4 (7.0.5 is available)
Gson: 2.10.0 (2.10.1 is available)
Logback Classic Module: 1.4.5 (1.4.6 is available)
Logback Core Module: 1.4.5 (1.4.6 is available)
AQute Bndlib: 6.4.0 (7.0.0 is available)
JDOM: 1.1.3 (2.0.2 is available)

Based on reading about inheritance of versions from parent to child poms, I'm not 100% clear if maven-antrun-plugin and maven-javadoc-plugin would inherit the version from the parent pom. My guess is that they would, but because I'm not sure, I think it is best not to make changes to the master branch for these artifacts. Instead, I will update the versions in both the parent and child poms on the 3275 branch.

Update artifact versions in child poms: https://bitbucket.org/nfreese/nowlanfork-igb/commits/6166b5fab8953e3540485ea8b55bb9c6c7211f4a

Update jdom artifact to jdom2 version 2.0.6.1: https://bitbucket.org/nfreese/nowlanfork-igb/commits/41bc7a9f93c6fa95529fdcf0a2c995c5d588f5e4

To test:
Pull two latest commits and test that IGB builds successfully (mvn clean install).

Pulled latest commits and was able to build the project. Test passed.

As the commits are merged into branch 3275, I am considering this ticket closed.