Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.0.0 Major Release
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Spring 8 2023 Apr 24
Description
Situation: Unable to resolve com.google.guava. Guava was updated in the pom to Bundle-Version: 31.1.0.jre. However, Guava is unable to be resolved. The package com.google.common.util.concurrent.internal is in every error line that also mentions Guava. The com.google.common.util.concurrent.internal package is set as an Import-Package in the Guava manifest.
14:49:00.226 [main] ERROR com.affymetrix.main.OSGiHandler - Unable to resolve com.google.guava [35](R 35.0): missing requirement [com.google.guava [35](R 35.0)] osgi.wiring.package; (&(osgi.wiring.package=com.google.common.util.concurrent.internal)(version>=1.0.0)(!(version>=2.0.0))) Unresolved requirements: [[com.google.guava [35](R 35.0)] osgi.wiring.package; (&(osgi.wiring.package=com.google.common.util.concurrent.internal)(version>=1.0.0)(!(version>=2.0.0)))]
Task: Determine why this error is appearing, if it can be fixed then update this ticket as needed.
Attachments
Issue Links
Activity
Downloaded and installed 3310 installer as advised. Opened latest human genome and observed no errors in log.
Moving to "ready for PR"
In order to update the guava version to 31.1-jre we needed to also add the guava dependency failureaccess. Adding the failureaccess artifact to the project pom and the main pom worked correctly for the IGBF-3275 branch on Java 11.
- Java 11 commit: https://bitbucket.org/nfreese/nowlanfork-igb/commits/083548ee69a98176dfde7090eee186f2890b3b09
To test, pull latest changes from myIGBF-3275branch, build IGB (mvn clean install) and then run the jar, there should be no errors related to com.google.guava.
I also tested updating guava on the IGB master branch. IGB built and ran correctly.
- Java 8 commit: https://bitbucket.org/nfreese/nowlanfork-igb/commits/f2c177b645efbdfaa040901ca775238b4b8c57c3
To test, download my IGBF-3310 installer, install and run IGB, and look for IGB to run correctly with no errors in the log.
It looks like there are additional requirements for using guava versions >= 27.01:
- Guava documentation
- Discussion about additional requirements for guava here and here
- OpenCast updating guava
Backing guava down to version 27.0-jre removes the guava errors, but this version does have reported vulnerabilities.
guava manifest:
Manifest-Version: 1.0 Automatic-Module-Name: com.google.common Bnd-LastModified: 1646083102234 Build-Jdk: 11.0.12 Built-By: cpovirk Bundle-Description: Guava is a suite of core and expanded libraries that include utility classes, Google's collections, I/O classes, and much more. Bundle-DocURL: https://github.com/google/guava/ Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt Bundle-ManifestVersion: 2 Bundle-Name: Guava: Google Core Libraries for Java Bundle-SymbolicName: com.google.guava Bundle-Version: 31.1.0.jre Created-By: Apache Maven Bundle Plugin Export-Package: com.google.common.annotations;version="31.1.0",com.googl e.common.base;version="31.1.0";uses:="javax.annotation",com.google.comm on.cache;version="31.1.0";uses:="com.google.common.base,com.google.comm on.collect,com.google.common.util.concurrent,javax.annotation",com.goog le.common.collect;version="31.1.0";uses:="com.google.common.base,javax. annotation",com.google.common.escape;version="31.1.0";uses:="com.google .common.base,javax.annotation",com.google.common.eventbus;version="31.1 .0",com.google.common.graph;version="31.1.0";uses:="com.google.common.c ollect,javax.annotation",com.google.common.hash;version="31.1.0";uses:= "com.google.common.base,javax.annotation",com.google.common.html;versio n="31.1.0";uses:="com.google.common.escape",com.google.common.io;versio n="31.1.0";uses:="com.google.common.base,com.google.common.collect,com. google.common.graph,com.google.common.hash,javax.annotation",com.google .common.math;version="31.1.0";uses:="javax.annotation",com.google.commo n.net;version="31.1.0";uses:="com.google.common.base,com.google.common. collect,com.google.common.escape,javax.annotation",com.google.common.pr imitives;version="31.1.0";uses:="com.google.common.base,javax.annotatio n",com.google.common.reflect;version="31.1.0";uses:="com.google.common. collect,com.google.common.io,javax.annotation",com.google.common.util.c oncurrent;version="31.1.0";uses:="com.google.common.base,com.google.com mon.collect,com.google.common.util.concurrent.internal,javax.annotation ",com.google.common.xml;version="31.1.0";uses:="com.google.common.escap e" Import-Package: com.google.common.util.concurrent.internal;version="[1.0 ,2)",javax.annotation;resolution:=optional;version="[3.0,4)",javax.cryp to;resolution:=optional,javax.crypto.spec;resolution:=optional,sun.misc ;resolution:=optional Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))" Tool: Bnd-2.3.0.201405100607
Master branch installers are built and deployed to the downloads section of the team repository.
Ready for testing.