Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3349

Remove guava (google) upper bound version requirement for ProtAnnot

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Summer 2 2023 May 29, Summer 4 2023 June 26, Summer 5 2023 July 10, Summer 6 2023 July 24, Summer 7 2023 Aug 7

      Description

      Situation: As part of IGBF-3310 we updated the com.google.guava dependency on IGB master to a newer version (32.1.1-jre) as the newer version does not have a known vulnerability. However, the Protannot manifest currently specifies an Import-Package for:

      com.google.common.base;version="\"[16.0,17)\"",
      com.google.common.collect;version="\"[16.0,17)\"",
      com.google.common.eventbus;version="\"[16.0,17)\"",
      

      This prevents ProtAnnot from appearing in the IGB app store while running the current version of master.

      Task: Update/Release a new version of Protannot that can use the newer version of com.google.guava. If possible, set it so that Protannot is not dependent on a specific version of com.google.guava.

        Attachments

          Issue Links

            Activity

            Hide
            kgopu Kaushik Gopu added a comment - - edited

            *Reverted non guava version changes. here is the commit.
            *pipeline build was successful.
            *moving to first level review.

            Show
            kgopu Kaushik Gopu added a comment - - edited *Reverted non guava version changes. here is the commit . *pipeline build was successful. *moving to first level review.
            Hide
            nfreese Nowlan Freese added a comment -

            Retested following testing outlined in previous commit, everything is working.

            Please squash commits then submit pull request.

            Show
            nfreese Nowlan Freese added a comment - Retested following testing outlined in previous commit, everything is working. Please squash commits then submit pull request.
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Regarding running out of build minutes, I contacted Bitbucket and this was the response:

            John commented:

            Hi Nowlan,

            Thank you for reaching out to Atlassian. My name is John and I'm from the Billing and Licensing team. I'll be happy to look into your request.

            Unfortunately, we can't increase build minutes for Bitbucket standard Free plans (max 5 users). However, upon taking a look into your account, you may be eligible to receive a free academic Bitbucket Cloud subscription that is intended for members (students, professors, and so forth) of colleges and universities (criteria listed below). This may be a good direction for increasing build minutes.

            Special pricing is available for qualified Academic institutions. The following organizations are eligible for an Atlassian Academic License:

            Collegiate-level or higher educational institutions: vocational schools, junior colleges, colleges, universities, or scientific or technical schools that are accredited by a national accrediting agency.
            Administrative offices & boards of education: Provincial, district, regional, national and state administrative offices and authorities of the Educational Institutions defined above.
            K-12 administrative offices: K-12 educational institutions for administrative office use only (i.e. no K-12 student data may be submitted to the products or services).
            Public libraries
            Collegiate-level or higher home-school programs
            Research institutes that are affiliated with an accredited university.
            Teaching hospitals that are affiliated with an accredited university.
            Training and teaching organizations that are accredited by a statutory government qualifications body.
            You can apply and provide details of your academic institution by requesting a Bitbucket academic subscription. Our team will then review the application and get back to you. We can further proceed, once approved.

            I hope the above information helps.

            I have used the link to submit my information for an academic subscription.

            UPDATE: I am now on a University license.

            Show
            nfreese Nowlan Freese added a comment - - edited Regarding running out of build minutes, I contacted Bitbucket and this was the response: John commented: Hi Nowlan, Thank you for reaching out to Atlassian. My name is John and I'm from the Billing and Licensing team. I'll be happy to look into your request. Unfortunately, we can't increase build minutes for Bitbucket standard Free plans (max 5 users). However, upon taking a look into your account, you may be eligible to receive a free academic Bitbucket Cloud subscription that is intended for members (students, professors, and so forth) of colleges and universities (criteria listed below). This may be a good direction for increasing build minutes. Special pricing is available for qualified Academic institutions. The following organizations are eligible for an Atlassian Academic License: Collegiate-level or higher educational institutions: vocational schools, junior colleges, colleges, universities, or scientific or technical schools that are accredited by a national accrediting agency. Administrative offices & boards of education: Provincial, district, regional, national and state administrative offices and authorities of the Educational Institutions defined above. K-12 administrative offices: K-12 educational institutions for administrative office use only (i.e. no K-12 student data may be submitted to the products or services). Public libraries Collegiate-level or higher home-school programs Research institutes that are affiliated with an accredited university. Teaching hospitals that are affiliated with an accredited university. Training and teaching organizations that are accredited by a statutory government qualifications body. You can apply and provide details of your academic institution by requesting a Bitbucket academic subscription . Our team will then review the application and get back to you. We can further proceed, once approved. I hope the above information helps. I have used the link to submit my information for an academic subscription. UPDATE: I am now on a University license.
            Hide
            kgopu Kaushik Gopu added a comment - - edited
            Show
            kgopu Kaushik Gopu added a comment - - edited commits squashed Pull request submitted
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on IGB 9.1.10 and main-JDK8. Everything is working correctly. On 9.1.10 with ProtAnnot 9.1.3 installed, I could see the update button in the App Manager to update to 9.1.4.

            Closing ticket.

            Show
            nfreese Nowlan Freese added a comment - Tested on IGB 9.1.10 and main-JDK8. Everything is working correctly. On 9.1.10 with ProtAnnot 9.1.3 installed, I could see the update button in the App Manager to update to 9.1.4. Closing ticket.

              People

              • Assignee:
                kgopu Kaushik Gopu
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: