Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.0.0 Major Release
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Summer 2 2023 May 29
Description
Situation: When running IGB master from Netbeans I noticed that IGB was unable to resolve com.google.guava. This is due to a missing requirement for <artifactId>failureaccess</artifactId>.
Task: Add <artifactId>failureaccess</artifactId> such that com.google.guava is able to resolve.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Note: My understanding of the shared-lib-wrapper pom.xml is limited, but it seems like dependencies/artifactItem need to be included to properly run through Netbeans, as I do not see the same errors if something is missing from shared-lib-wrapper when running maven through the terminal. Likewise, if something is missing from the main pom.xml but included in the shared-lib-wrapper then IGB seems to build fine from Netbeans but throws errors when building through the terminal.
For future reference, when testing a change that affects a library/dependency entry in a POM, need to test IGB running in IDEs as well as from command line and from installer.
See this case study on issues with running IGB in development mode: https://canvas.instructure.com/courses/1164217/files/67490997?module_item_id=19105206
| Assignee | Kaushik Gopu [ kgopu ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
I have a verbal confirmation that testing was successful for Kaushik, so I have included the pull request below.
Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/931
| Attachment | bundle_status_igb.png [ 17899 ] |
Status:
i) no errors were found while running the application in IDE development mode.
ii) all bundles are in active mode.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged and building master branch installers.
Since the error is visible during development mode and the change has solved the development mode issue, skipping further testing. Moving to Done.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Kaushik Gopu [ kgopu ] | Nowlan Freese [ nfreese ] |
| Fix Version/s | 10.0.0 Major Release [ 10900 ] |
| Issue Type | Task [ 3 ] | Bug [ 1 ] |
Commit: https://bitbucket.org/nfreese/nowlanfork-igb/commits/d03c4c7871b19fc856846aad38bbb00b0e10c37b
To test:
Fetch my branch and clean and build in Netbeans and then run from Netbeans and IntelliJ, the two IDEs the core team is using.
There should be no errors such as "unable to resolve".
Once IGB is running check that all bundles are active: http://localhost:7080/system/console/bundles