Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3382

Remove remote error dependencies

        Details

          Description

          Situation: While updating dependencies as part of IGBF-3335 I was unable to update the dependency org.apache.felix.dependencymanager as the following three dependencies specified a lower version:

          • org.lorainelab.igb.remote.services.discovery.provider.configured
          • org.lorainelab.igb.remote.services.distribution.provider.http
          • org.lorainelab.igb.remote.services.topology.manager

          After speaking with Dr. Loraine, the above dependencies (hosted on https://maven.bioviz.org/repo2/org/lorainelab/igb/) may not be needed in the IGB codebase, however we are unsure.

          Task: Determine if the discovery.provider.configured, distribution.provider.http, and topology.manager are being used in the IGB code base. If they are not being used by IGB, please remove them as dependencies.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-2596 Remove repo1 and repo3 from IGB 9.1.8 POM

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-3335 Update IGB java 1.8 dependencies

              • Major - Major loss of function.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Testing:

                • Installed the main-JDK8 branch, downloaded from the "early access" section of the Web site.
                • IGB launched as expected.
                • Loaded latest human genome by clicking the Mona Lisa image on the home screen
                • Open the felix Web console and entered user name admin password admin to view the installed bundles
                • Observed that all bundles have "Status" of "active"
                • Observed there were no errors in the Consle

                Moving to Done.

                Show
                ann.loraine Ann Loraine added a comment - - edited Testing: Installed the main-JDK8 branch, downloaded from the "early access" section of the Web site. IGB launched as expected. Loaded latest human genome by clicking the Mona Lisa image on the home screen Open the felix Web console and entered user name admin password admin to view the installed bundles Observed that all bundles have "Status" of "active" Observed there were no errors in the Consle Moving to Done.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Merged. Main branch installers are built and deployed to bioviz.org and the team repository downloads section.

                Show
                ann.loraine Ann Loraine added a comment - - edited Merged. Main branch installers are built and deployed to bioviz.org and the team repository downloads section.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/935

                Show
                nfreese Nowlan Freese added a comment - Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/935
                Hide
                Permalink
                kgopu Kaushik Gopu added a comment -

                Fetched IGBF-3382 and tested basic functionalities, all bundles are in resolved state and logs are clean. it is good to go.

                Show
                kgopu Kaushik Gopu added a comment - Fetched IGBF-3382 and tested basic functionalities, all bundles are in resolved state and logs are clean. it is good to go.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment - - edited

                Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3382

                I have commented out the org.lorainelab.igb.error.reporter.manager module in the project pom. The org.lorainelab.igb.error.reporter.manager code is still within IGB, but should not build as the module has been commented out. Dependencies have been removed from the project/main/shared poms, as well as version variables.

                I have squashed commits and rebased onto main-JDK8. Everything in IGB seems to be working.

                To test,

                1. Fetch my branch IGBF-3382 (my bitbucket account is out of pipeline minutes).
                2. Build IGB (mvn clean install)
                3. Start IGB, look for any errors in the log.
                4. Launch the App Manager (Plug-ins tab) in IGB, check that you can install an app
                5. Open a genome and load some data, i.e. check that IGB appears to be functioning correctly in a general sense
                6. In a web browser, go to http://localhost:7080/system/console/bundles and check to see that all bundles are active and that no bundles are listed as installed or fragments.
                Show
                nfreese Nowlan Freese added a comment - - edited Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3382 I have commented out the org.lorainelab.igb.error.reporter.manager module in the project pom. The org.lorainelab.igb.error.reporter.manager code is still within IGB, but should not build as the module has been commented out. Dependencies have been removed from the project/main/shared poms, as well as version variables. I have squashed commits and rebased onto main-JDK8. Everything in IGB seems to be working. To test, Fetch my branch IGBF-3382 (my bitbucket account is out of pipeline minutes). Build IGB (mvn clean install) Start IGB, look for any errors in the log. Launch the App Manager (Plug-ins tab) in IGB, check that you can install an app Open a genome and load some data, i.e. check that IGB appears to be functioning correctly in a general sense In a web browser, go to http://localhost:7080/system/console/bundles and check to see that all bundles are active and that no bundles are listed as installed or fragments.
                5 older comments

                  People

                  • Assignee:
                    nfreese Nowlan Freese
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: