Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:Summer 6 2023 July 24
Description
Situation: The SNP file converter plugin does not appear in the IGB main-JDK8 app manager. Most likely this is due to a dependence on Google Guava 16.0.1 similar to IGBF-3349.
Task: Refactor the app so that it appears in the IGB main-JDK8 app manager.
Link: https://bitbucket.org/lorainelab/snp-file-converter/src/master/
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1908 [ 17998 ] |
| Description |
Situation: The SNP file converter plugin does not appear in the IGB main-JDK8 app manager. Most likely this is due to a dependence on Google Guava 16.0.1 similar to Task: Refactor the app so that it appears in the IGB main-JDK8 app manager. |
Situation: The SNP file converter plugin does not appear in the IGB main-JDK8 app manager. Most likely this is due to a dependence on Google Guava 16.0.1 similar to Task: Refactor the app so that it appears in the IGB main-JDK8 app manager. Link: https://bitbucket.org/lorainelab/snp-file-converter/src/master/pom.xml |
| Description |
Situation: The SNP file converter plugin does not appear in the IGB main-JDK8 app manager. Most likely this is due to a dependence on Google Guava 16.0.1 similar to Task: Refactor the app so that it appears in the IGB main-JDK8 app manager. Link: https://bitbucket.org/lorainelab/snp-file-converter/src/master/pom.xml |
Situation: The SNP file converter plugin does not appear in the IGB main-JDK8 app manager. Most likely this is due to a dependence on Google Guava 16.0.1 similar to Task: Refactor the app so that it appears in the IGB main-JDK8 app manager. Link: https://bitbucket.org/lorainelab/snp-file-converter/src/master/ |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Attachment | 23andMeExampleData.txt [ 17921 ] |
Tested the application by using sample file and it is working fine. moving to first level review.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Kaushik Gopu [ kgopu ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Testing Kaushik's branch locally on Mac.
IGB release-9.1.10
Installed version 9.1.0 of SNP File Converter through the App Manager. After adding Kaushik's SNP File Converter as a new repository the app manager showed that I could update SNP File Converter from 9.1.0 to 9.1.1. SNP File Converter worked correctly on the attached example data.
IGB main-JDK8
With the default app manager repositories SNP File Converter is not available. After adding Kaushik's SNP File Converter as a new local repository the app manager showed that I could install SNP File Converter version 9.1.1. SNP File Converter worked correctly.
Note: The name of the app was changed in this commit along with a change from version 9.1.0 to 9.1.1. However, the 9.1.1 version of the app was never released on the app store. In Kaushik's branch the app version is 9.1.1 which I think should work, since 9.1.1 was never released.
2nd note: Please make sure your IDE is not auto formatting tabs/spaces as they make commits more difficult to read.
Ready for pull request.
| Assignee | Nowlan Freese [ nfreese ] | Kaushik Gopu [ kgopu ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Pull request submitted:https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/10
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Kaushik Gopu [ kgopu ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested on Mac using https://bitbucket.org/lorainelab/snp-file-converter/downloads/ and the testing strategy outlined above.
Everything is working correctly.
Closing ticket.
| Assignee | Nowlan Freese [ nfreese ] | Kaushik Gopu [ kgopu ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
The SNP-file-converter-plugin is coming up after upgrading guava dependency. However, I would like to perform run time testing so that I can conclude that application is working fine.