The function confirm_submission was returning the error that Dr. Freese reported only after sending the email. I've changed the logic such that the user permissions are checked first, then saved in a variable called response. If that response is not an error, then an email will be sent letting the user know the app was submitted successfully. Otherwise, no email will be sent.

I'm having a tough time testing these changes locally because I do have editor permissions in my appstore development environment. However, I can see that the logic changed as I expected.

First, I added SNP File Converter v10.0.1. I encountered an error upon submission (not a permissions error but rather a local host error), but still received an email letting me know the app was submitted successfully. I then made the above code changes, incremented the SNP File Converter version to v10.0.2, and tried submitting again. Now, I still see the error but no email has been sent.

The error I reported in my last comment was related to the development environment I was running. After setting up a new environment, I am now able to test properly.

I repeated my testing steps above with the Hello World app and am now able to see the message "You are not authorized to add releases, because you are not an editor" when uploading a new version of the app. With my changes, I no longer receive the email incorrectly stating that the app was submitted successfully.

Ready for review!

Branch: https://bitbucket.org/pkulzer-lorainelab/appstore/branch/IGBF-3405

Testing locally. When submitting a new version of an app when NOT the superuser I am not getting the email response (correct behavior). However, I am seeing the same error page that Paige was seeing. Most likely something is not configured correctly in my local app store. I think we should wait on this issue until we can test in a deployed dev environment.

Dev set up instructions: https://docs.google.com/document/d/1_9C03q6TD5wjLqfVLKsuDsIEQ4-qrS0JhONO5VBOwaA/edit?usp=sharing