Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.0.0 Major Release
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 1 - Sep 5, Summer 7 2023 Aug 7, Summer 8 2023 Aug 21
Description
After updating the annotations in IGB DAS bundle, it build without errors in Karthik Raveendran's system but showed NoClassDefError in Nowlan Freese's system. Need to investigate why this is happening.
Note: Nowlan Freese uses a Mac system whereas Karthik Raveendran uses a Windows system.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Assignee | Karthik Raveendran [ karthik ] |
| Summary | Update R6 annotations for Core - DAS | Update Core DAS |
| Summary | Update Core DAS | Update Core/DAS |
| Summary | Update Core/DAS | Investigate: Update Core/DAS error |
| Sprint | Summer 7 2023 Aug 7 [ 176 ] | Summer 7 2023 Aug 7, Summer 8 2023 Aug 21 [ 176, 177 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
After pushing the changes to my fork, the Btibucket pipeline threw an NoClassDefinition error for test classes in core/das/src/test/java/com/lorainelab/das :
1) DasDataProviderTest
2) DasServerInfoTest
3) DASFeatureParserTest
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
This issue is seems to be caused because the test classes was not able to access org.osgi.framework.FrameworkUtil in Felix main. Adding that dependency in DAS pom resolved this issue. See commit
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Karthik Raveendran [ karthik ] | Nowlan Freese [ nfreese ] |
Commit looks good and I did not see any errors when building IGB.
Ready for pull request.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
PR submitted
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Summer 7 2023 Aug 7, Summer 8 2023 Aug 21 [ 176, 177 ] | Testing 2 : 4 Nov - 15 Nov, Summer 7 2023 Aug 7, Summer 8 2023 Aug 21 [ 82, 176, 177 ] |
| Rank | Ranked higher |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Built the main-JDK8-r6 branch with tests - everything built/tested successfully.
Used installer for main-JDK8-r6 - IGB installed without any issues on macOS 13.5.1
Ran using both main-JDK8-r6 jar file and through installer, no issues in log, IGB appeared to be working correctly.
All bundles were listed as Active in the felix web console.
Closing ticket.
| Fix Version/s | 10.0.0 Major Release [ 10900 ] |
| Issue Type | Task [ 3 ] | Bug [ 1 ] |
Changing the module this time did not throw an error - See branch