Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Sprint:Fall 2 2023 Sep 17, Fall 3 2023 Oct 2
Description
After all declarative services in IGB has been migrated to osgi.annotations and the maven-bundle-plugin version has been appropriately selected, the IGB application works without any errors in Java 8. The next step is to try and migrate the project Java 11 and possibly fix any errors (which is presumably errors that is not as profound as annotation changes). This ticket is to investigate those potential errors and check if the Java 8 project is ready to move to Java 11.
Attachments
Issue Links
Activity
Please close it, I checked again and it is up to date with main-JDK8. I think the most recent version of main-JDK8 just hasn't been pushed to Karthik's fork, so when I was initially comparing commits it looked odd, but comparing it to lorainelab/main-JDK8 it looks good.
I'm pretty sure this branch is coming from main-JDK8. I looked at the commit histories for branch IGBF-3452 on KR's fork and main-JDK8 on the team repository. I don't seen any differences apart from the commits KR has added, forking from commit hash 7b84b92, a merge commit which is the tip of main-JDK8. I have added an image as an attachment to this ticket showing this.
Nowlan Freese - is it OK if I close this ticket now or do you want to take a look yourself, as well?
The commits look good to me. I just want to double-check that the branch has been rebased off of main-JDK8. Also please double-check that the newest version of main-JDK8 has been pushed to your branch, it makes comparing the two branches a lot easier.
Question for Karthik Raveendran and/or Nowlan Freese:
The branch in its current state looks like a good reference branch we could use for "cherrypicking" commits onto whatever becomes the main development branch. Do you agree the "investigate" task is now complete?
The first error that appeared after moving project to Java 11 is maven-compile-plugin error. The version we used is 3.11.0 and downgrading the version to 3.6.0 seems to be working.
Loraine comment: Updated a JDK version property corrected the above problem. Not sure if it is necessary to downgrade the compiler plugin version?
The above commits deals with compile time errors with Java 11 in main-JDK8. Runtime errors will be dealt with in another ticket.