Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3452

Investigate main-JDK8-r6 errors on Java 11

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      After all declarative services in IGB has been migrated to osgi.annotations and the maven-bundle-plugin version has been appropriately selected, the IGB application works without any errors in Java 8. The next step is to try and migrate the project Java 11 and possibly fix any errors (which is presumably errors that is not as profound as annotation changes). This ticket is to investigate those potential errors and check if the Java 8 project is ready to move to Java 11.

        Attachments

          Issue Links

            Activity

            Hide
            karthik Karthik Raveendran added a comment - - edited

            The first error that appeared after moving project to Java 11 is maven-compile-plugin error. The version we used is 3.11.0 and downgrading the version to 3.6.0 seems to be working.

            Loraine comment: Updated a JDK version property corrected the above problem. Not sure if it is necessary to downgrade the compiler plugin version?

            Show
            karthik Karthik Raveendran added a comment - - edited The first error that appeared after moving project to Java 11 is maven-compile-plugin error. The version we used is 3.11.0 and downgrading the version to 3.6.0 seems to be working. Loraine comment: Updated a JDK version property corrected the above problem. Not sure if it is necessary to downgrade the compiler plugin version?
            Hide
            karthik Karthik Raveendran added a comment -

            After that the next error was JavaFX error, where, even though Zulu Java 11 that we are using has JavaFX, javafx.application.Platform class does not exist. According to some, adding jfxrt.jar from JDK8 will resolve the issue because JavaFX was removed from OpenJDK Java 11 but since we are using Zulu Java 11 with JavaFX, I wonder if there are any replacements included for that class. If not, adding jfxt.jar is always an option.

            Show
            karthik Karthik Raveendran added a comment - After that the next error was JavaFX error, where, even though Zulu Java 11 that we are using has JavaFX, javafx.application.Platform class does not exist. According to some, adding jfxrt.jar from JDK8 will resolve the issue because JavaFX was removed from OpenJDK Java 11 but since we are using Zulu Java 11 with JavaFX, I wonder if there are any replacements included for that class. If not, adding jfxt.jar is always an option.
            Hide
            karthik Karthik Raveendran added a comment - - edited

            javax.xml.bind was removed in Java 11 and it deprecated from Java 9 and 10. This is causing an error in org/lorainelab/igb/das/model/gff/Feature.java.

            Adding the following dependencies seems to resolve it:

            <dependency>
              <groupId>javax.xml.bind</groupId>
              <artifactId>jaxb-api</artifactId>
              <version>2.3.0</version>
            </dependency>
            <dependency>
              <groupId>com.sun.xml.bind</groupId>
              <artifactId>jaxb-core</artifactId>
              <version>2.3.0</version>
            </dependency>
            <dependency>
              <groupId>com.sun.xml.bind</groupId>
              <artifactId>jaxb-impl</artifactId>
              <version>2.3.0</version>
            </dependency>
            
            Show
            karthik Karthik Raveendran added a comment - - edited javax.xml.bind was removed in Java 11 and it deprecated from Java 9 and 10. This is causing an error in org/lorainelab/igb/das/model/gff/Feature.java. Adding the following dependencies seems to resolve it: <dependency> <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> <version>2.3.0</version> </dependency> <dependency> <groupId>com.sun.xml.bind</groupId> <artifactId>jaxb-core</artifactId> <version>2.3.0</version> </dependency> <dependency> <groupId>com.sun.xml.bind</groupId> <artifactId>jaxb-impl</artifactId> <version>2.3.0</version> </dependency>
            Hide
            karthik Karthik Raveendran added a comment -

            Instead of adding jidesoft classes, removing the two classes in jide folder is the easier option to go forward

            Show
            karthik Karthik Raveendran added a comment - Instead of adding jidesoft classes, removing the two classes in jide folder is the easier option to go forward
            Hide
            ann.loraine Ann Loraine added a comment -

            Next step:

            • Push a branch with the above changes to a fork
            • To review: another developer pulls the branch and attempts to build it
            Show
            ann.loraine Ann Loraine added a comment - Next step: Push a branch with the above changes to a fork To review: another developer pulls the branch and attempts to build it
            Hide
            karthik Karthik Raveendran added a comment -
            Show
            karthik Karthik Raveendran added a comment - Branch with changes for above errors: https://bitbucket.org/KarthikRavee91/karthikfork-igb/branch/IGBF-3452
            Hide
            ann.loraine Ann Loraine added a comment -

            We discussed this after the scrum today. Karthik Raveendran is working on a new version of the branch, using suggestions from the discussion.

            Show
            ann.loraine Ann Loraine added a comment - We discussed this after the scrum today. Karthik Raveendran is working on a new version of the branch, using suggestions from the discussion.
            Hide
            ann.loraine Ann Loraine added a comment -

            Question for Karthik Raveendran and/or Nowlan Freese:

            The branch in its current state looks like a good reference branch we could use for "cherrypicking" commits onto whatever becomes the main development branch. Do you agree the "investigate" task is now complete?

            Show
            ann.loraine Ann Loraine added a comment - Question for Karthik Raveendran and/or Nowlan Freese : The branch in its current state looks like a good reference branch we could use for "cherrypicking" commits onto whatever becomes the main development branch. Do you agree the "investigate" task is now complete?
            Hide
            nfreese Nowlan Freese added a comment -

            The commits look good to me. I just want to double-check that the branch has been rebased off of main-JDK8. Also please double-check that the newest version of main-JDK8 has been pushed to your branch, it makes comparing the two branches a lot easier.

            Show
            nfreese Nowlan Freese added a comment - The commits look good to me. I just want to double-check that the branch has been rebased off of main-JDK8. Also please double-check that the newest version of main-JDK8 has been pushed to your branch, it makes comparing the two branches a lot easier.
            Hide
            ann.loraine Ann Loraine added a comment -

            I'm pretty sure this branch is coming from main-JDK8. I looked at the commit histories for branch IGBF-3452 on KR's fork and main-JDK8 on the team repository. I don't seen any differences apart from the commits KR has added, forking from commit hash 7b84b92, a merge commit which is the tip of main-JDK8. I have added an image as an attachment to this ticket showing this.

            Nowlan Freese - is it OK if I close this ticket now or do you want to take a look yourself, as well?

            Show
            ann.loraine Ann Loraine added a comment - I'm pretty sure this branch is coming from main-JDK8. I looked at the commit histories for branch IGBF-3452 on KR's fork and main-JDK8 on the team repository. I don't seen any differences apart from the commits KR has added, forking from commit hash 7b84b92, a merge commit which is the tip of main-JDK8. I have added an image as an attachment to this ticket showing this. Nowlan Freese - is it OK if I close this ticket now or do you want to take a look yourself, as well?
            Hide
            nfreese Nowlan Freese added a comment -

            Please close it, I checked again and it is up to date with main-JDK8. I think the most recent version of main-JDK8 just hasn't been pushed to Karthik's fork, so when I was initially comparing commits it looked odd, but comparing it to lorainelab/main-JDK8 it looks good.

            Show
            nfreese Nowlan Freese added a comment - Please close it, I checked again and it is up to date with main-JDK8. I think the most recent version of main-JDK8 just hasn't been pushed to Karthik's fork, so when I was initially comparing commits it looked odd, but comparing it to lorainelab/main-JDK8 it looks good.
            Hide
            karthik Karthik Raveendran added a comment -

            The above commits deals with compile time errors with Java 11 in main-JDK8. Runtime errors will be dealt with in another ticket.

            Show
            karthik Karthik Raveendran added a comment - The above commits deals with compile time errors with Java 11 in main-JDK8. Runtime errors will be dealt with in another ticket.

              People

              • Assignee:
                karthik Karthik Raveendran
                Reporter:
                karthik Karthik Raveendran
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: