Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Please update the README in the results folder to show the new files.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-3446 [ 22548 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-3460 [ IGBF-3460 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Mdavis4290 Molly Davis made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Show
            Mdavis4290 Molly Davis added a comment - Branch : https://bitbucket.org/mdavis4290/molly3-flavonoid-rnaseq/branch/IGBF-3463
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            Mdavis4290 Molly Davis made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            unassigning because others can review this besides me.

            Show
            ann.loraine Ann Loraine added a comment - unassigning because others can review this besides me.
            Mdavis4290 Molly Davis made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Mdavis4290 Molly Davis made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            Mdavis4290 Molly Davis made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Hide
            Mdavis4290 Molly Davis added a comment - - edited

            Reviewer:

            Repo: https://bitbucket.org/hotpollen/flavonoid-rnaseq/src/main/72_F3H_PollenTube/results/

            • Check that the README file explains each output file thoroughly and clearly.
            • Also check that my branch is adding the final files _MvW-temp-[assembly].xlsx _ explanation correctly.

            Thanks!

            Show
            Mdavis4290 Molly Davis added a comment - - edited Reviewer : Repo : https://bitbucket.org/hotpollen/flavonoid-rnaseq/src/main/72_F3H_PollenTube/results/ Check that the README file explains each output file thoroughly and clearly. Also check that my branch is adding the final files _MvW-temp- [assembly] .xlsx _ explanation correctly. Thanks!
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            To view the proposed edits, I visited this link: https://bitbucket.org/mdavis4290/molly3-flavonoid-rnaseq/src/IGBF-3463/

            I navigated to the "results" folder: 72_F3H_PollenTube/results and looked at the README.md in the bitbucket interface.

            The text looks good. It basically says that the file FindTreatmentEffectAcrossGenotypes-DESeq2.Rmd makes MvW-temp-[assembly].xlsx for both assemblies SL4 and SL5.

            To make sure I could assess statements about these files, I looked at the code in FindTreatmentEffectAcrossGenotypes-DESeq2.Rmd. The README.md text made this possible because it identified the source .Rmd file used to create the documented results files.

            I saw the code imports 3rd party excel input/output code to create spreadsheets with tabs for each treatment duration collection.

            I did not try to run the code due to laziness.

            Moving to "ready for pull request."

            Show
            ann.loraine Ann Loraine added a comment - - edited To view the proposed edits, I visited this link: https://bitbucket.org/mdavis4290/molly3-flavonoid-rnaseq/src/IGBF-3463/ I navigated to the "results" folder: 72_F3H_PollenTube/results and looked at the README.md in the bitbucket interface. The text looks good. It basically says that the file FindTreatmentEffectAcrossGenotypes-DESeq2.Rmd makes MvW-temp- [assembly] .xlsx for both assemblies SL4 and SL5. To make sure I could assess statements about these files, I looked at the code in FindTreatmentEffectAcrossGenotypes-DESeq2.Rmd. The README.md text made this possible because it identified the source .Rmd file used to create the documented results files. I saw the code imports 3rd party excel input/output code to create spreadsheets with tabs for each treatment duration collection. I did not try to run the code due to laziness. Moving to "ready for pull request."
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Molly Davis [ molly ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 3 2023 Oct 2 [ 179 ] Fall 3 2023 Oct 2, Fall 4 2023 Oct 16 [ 179, 180 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Show
            Mdavis4290 Molly Davis added a comment - PR : https://bitbucket.org/hotpollen/flavonoid-rnaseq/pull-requests/27
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            Mdavis4290 Molly Davis made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged. Ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged. Ready for testing.
            Hide
            Mdavis4290 Molly Davis added a comment -

            Everything looks up to date in the README in the main repo.
            Moving to done!

            Show
            Mdavis4290 Molly Davis added a comment - Everything looks up to date in the README in the main repo. Moving to done!
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Mdavis4290 Molly Davis made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                Mdavis4290 Molly Davis
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: