Details
-
Type:
Task
-
Status: To-Do (View Workflow)
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 6, Fall 7
Description
IGB uses JideTable which can be replaced by JTable.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Attachment | Jidesoft_DataManagement.png [ 18093 ] |
| Attachment | Simple JTable.png [ 18094 ] |
| Attachment | StyledJTable_WebLinksView.png [ 18108 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
StyledJTable which used to extends JideTable and now, after IGBF-3486, it extends JTable instead. Instances of this class is created in:
DataProviderManagementGIU (table 98)
DataProviderTableModel (infoDsTable 357)
TrackDefaultview (table 103)
TrackPreference (table 82)
WebLinksView (serverTable 94, localTable 95)
BookmarkManagerViewGUI (infoTable 94, dataTable 97)
BookmarkPropertiesGUI (table 119)
BundleRepositoryPrefsView (table 100)
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
I think we can delete the following two lines in StyledJTable.java
private static final int AUTO_RESIZE_LAST_COLUMN_FILL = 259;
setAutoResizeMode(AUTO_RESIZE_LAST_COLUMN_FILL);
AUTO_RESIZE_LAST_COLUMN_FILL was part of JideTable but was deprecated, I'm not sure it was even being used in IGB with Jidesoft.
The setAutoResizeMode only accepts 5 legal values (javadocs). My hunch is that the AUTO_RESIZE_LAST_COLUMN_FILL value of 259 being passed to setAutoResizeMode isn't doing anything as it is not a valid value for a JTable. I can't see any difference in how the tables in IGB behave if I get rid of setAutoResizeMode and AUTO_RESIZE_LAST_COLUMN_FILL.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
Changes implemented. See Commit: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/1e68c06adcf88127702e9c1e49c5f15e89d894a0
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Sprint | Fall 6 [ 182 ] | Fall 6, Fall 7 [ 182, 183 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Rationale seems good to me. Please submit PR.
| Assignee | Ann Loraine [ aloraine ] | Karthik Raveendran [ karthik ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Ann Loraine [ aloraine ] |
Merged. Main branch installers built and ready for testing.
see: https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Ann Loraine - The pull request contained other various commits that affect features such as LAF and colorComboBox that are affecting the UI in IGB.
The only commits we need in order to remove JideTable are:
7d6592e
1e68c06
Commits 8909781 and 1c24fc5 can be removed.
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Sprint | Fall 6, Fall 7 [ 182, 183 ] | Fall 6, Fall 7, Fall 8 [ 182, 183, 184 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | Pull Request Submitted [ 10101 ] |
I have created a pull request that reverts all of the current Jidesoft commits that were merged into main-JDK8.
Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/960
Merged branch that reverted commits.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Sprint | Fall 6, Fall 7, Fall 8 [ 182, 183, 184 ] | Fall 6, Fall 7 [ 182, 183 ] |
Tested main-JDK8 installer. Changes to Jidesoft were successfully reverted.
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
See Commit: https://bitbucket.org/KarthikRavee91/karthikfork-igb/commits/7d6592eeb7a9f161a2bca53f0acca8982392af54